[kovarex] [0.17.50] Crash during save after removed rails (talung's map)

[boskid]

Bug Report Revive (Ref 72006)

Steps to reproduce:
1/ Download "Experimental 17-3.zip"

Experimental 17-3.zip

(44.3 MiB) Downloaded 125 times

2/ Sync mods (i found only LTN +opteralib are required.. without them trains would stop)
3/ Open this save
4/ Wait 5s (time required for construction bots to remove some rails and go back into roboports)
5/ Try to save
6/ Crash

Add couple of seconds in step 4 for extra effects different crashes

crash RailBlock-checkConsistency line 314, +0s in step 4

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\railblock.cpp (314): RailBlock::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (956): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

52.149 Error RailBlock.cpp:314: countedReservations == this->reservedForCount was not true

crash TrainManager-checkConsistency line 981, +10s in step 4

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (981): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

141.091 Error TrainManager.cpp:981: signal->reservedFor.isZero() was not true

crash RailSignalBase-checkConsistency line 359, -2s in step 4

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\entity\railsignalbase.cpp (359): RailSignalBase::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\entity\railsignalbase.cpp (67): RailSignalBase::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\entity\railchainsignal.cpp (48): RailChainSignal::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\surface\chunk.cpp (101): Chunk::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\surface\surface.cpp (765): Surface::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1339): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

120.576 Error RailSignalBase.cpp:359: this->reservedFor.isZero() == (this->reservedForCount == 0) was not true

crash TrainManager-checkConsistency line 984, earliest tick found using editor single tick

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (984): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

  69.457 Error TrainManager.cpp:984: signal->reservedFor == position->second.first was not true

Code: Select all

  69.458 Error CrashHandler.cpp:181: Map tick at moment of crash: 27064381

---
more deterministic reproduction:
1/ Download "Experimental 17-4.zip"

Experimental 17-4.zip

(43.57 MiB) Downloaded 129 times

2/ Sync mods
3/ Open save
4/ In editor -> time, press "Tick once"
5/ Try to save
6/ Crash

log

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (984): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

 107.890 Error TrainManager.cpp:984: signal->reservedFor == position->second.first was not true

4/ Tick custom -> 300

log

Code: Select all

c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\railblock.cpp (302): RailBlock::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (956): TrainManager::checkConsistency
c:\cygwin64\tmp\factorio-build-oyvgrk\src\rail\trainmanager.cpp (52): TrainManager::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\map\map.cpp (1276): Map::save
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (1001): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\scenario.cpp (897): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-oyvgrk\src\scenario\parallelscenariosaver.cpp (99): ParallelScenarioSaver::doSave

Code: Select all

  51.030 Error RailBlock.cpp:302: inboundSignal->getReservation() == nullptr was not true

[kovarex]

Thanks for the prepared report, I was able to use it to discover the problem.

Fixed for the next release.