[2.0.66] Seemingly edge case stack overflow in platform tile destruction

We are aware of them, but do not have solutions that don't cause other issues. They go here in order not to take space in the main bug thread list.
Techjar
Inserter
Inserter
Posts: 26
Joined: Tue Jan 13, 2015 11:33 pm
Contact:

[2.0.66] Seemingly edge case stack overflow in platform tile destruction

Post by Techjar »

Description
Somehow, under specific circumstances, space platform tiles being destroyed by asteroids can cause a stack overflow. It happened randomly when screwing with a mod that adds ultra powerful thrusters (4 GN), but I don't think the mod is strictly necessary to cause the crash as it occurs purely in C++ code. I'm sure we weren't intended to make things this crazy, but mods are mods and I would think the game shouldn't outright crash. :P
Reproduction
I don't actually know how to consistently reproduce the crash. It's a random occurrence on a platform that's going over 2000 km/s using some modded thrusters. I doubt the exact set of mods is strictly necessary, but it's probably more likely to happen. This save should have all the mods and a platform already built that can trigger the crash: https://qimg.techjargaming.com/f/8cQdWG ... save17.zip

I've attached the log file to the post, the stack trace is far too big to put here directly.
Attachments
factorio-previous.log
(607.1 KiB) Downloaded 9 times
Rseding91
Factorio Staff
Factorio Staff
Posts: 16168
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.66] Seemingly edge case stack overflow in platform tile destruction

Post by Rseding91 »

One of the mods you’re using is creating an entity on tile destruction which does damage around it on creation which triggers other tiles to die which repeats over and over until it crashes.

There’s no fix for this on the engine side since we can’t just *not* run triggers when supposed to. The fix is on the mod side to not do things like cause damage on entity creation, and or not create those entities in reaction to damage events.
If you want to get ahold of me I'm almost always on Discord.
Techjar
Inserter
Inserter
Posts: 26
Joined: Tue Jan 13, 2015 11:33 pm
Contact:

Re: [2.0.66] Seemingly edge case stack overflow in platform tile destruction

Post by Techjar »

Ah I see! I did not realize that effect was coming from a mod, thought it was a vanilla thing removing fully disconnected platform tiles or something. I will investigate which mod is adding that effect and forward the report to that developer to see if/how they want to address it. Thanks!

Oh, one weird thing though, it only crashes the clients and not the dedicated server. Why would that be?

Edit: For the curious, I found the cause of this to be Lily's Cubeine Technologies. Made a bug report here: https://mods.factorio.com/mod/lilys-cub ... e4f6d98b11
Post Reply

Return to “Minor issues”