[Genhis][2.0.32] Crash in WaitConditions::isFulfilled when space platform hub takes damage

[synchromach]

Hi, you guys probably already fixed this bug internally in 2.0.33 (several people in a multiplayer server got the same crash at the same C++ function from 2.0.31 and you guys probably already saw the anonymous logs) but I just want to report this nonetheless just in case since it wasn't mentioned in 2.0.33 changelogs.

This save crashes on 2.0.32 roughly 20 seconds after being loaded:

rich world - ship benchmark 2 - game crash.zip

(29.8 MiB) Downloaded 26 times

Some notes:
- Crash does not occur if you load this save which was made around 1 minute before the crash, then use stack inserters to throw away all biter eggs that would later damage the space platform hub:

rich world - ship benchmark 2.zip

(32.49 MiB) Downloaded 23 times

- I cannot reproduce this in 2.0.33 which is why I assume it's already fixed there.

Log:

factorio-current.log

(12.39 KiB) Downloaded 25 times

[Genhis]

Thanks for reporting this. Your shattered planet platforms have no schedule, yet they are moving forward and when platform B transitions to the shattered planet connection, it causes the crash. Changing mods or updating the game temporarily fixes the issue because platforms recalculate their path when prototypes change. Do you know how you got your platforms to this state - no schedule but still moving forward?

EDIT: As soon as I finished writing this, I tried copying hub settings and it caused the crash.

[synchromach]

Thanks for reporting this. Your shattered planet platforms have no schedule, yet they are moving forward and when platform B transitions to the shattered planet connection, it causes the crash. Changing mods or updating the game temporarily fixes the issue because platforms recalculate their path when prototypes change. Do you know how you got your platforms to this state - no schedule but still moving forward?

I actually did not notice that platform B was the one causing the crash.

EDIT: As soon as I finished writing this, I tried copying hub settings and it caused the crash.

Oh, this didn't make much sense to me until I remembered that I copied hub settings from one platform to another and then flipped the "Automatic / Paused thrust" switch to "Automatic" at some point in the past before the "rich world - ship benchmark 2.zip" save file was made. I guess that caused it to copy the temporary schedules in an incorrect way, so the platform keeps moving with a corrupt schedule and eventually crashes the game?

[synchromach]

To add, based on what you said and what I'm seeing, I guess the simplest steps to reproduce this bug is to
- have 2 similar platforms, A and B
- make platform A have some temporary stops
- copy hub A to B
- flip B's "Automatic / Paused thrust" switch to "Automatic"
- wait for it to reach a destination and crash the game

[Genhis]

Duplicate of 125892, fixed for 2.0.34.

[synchromach]

Thank you for fixing!