[2.1.14] FluidWagonPrototype base_valve_offset issues

[protocol_1903]

After following up on boskid's advice in 135371, I noticed that base_valve_xy_offset_when_horizontal and base_valve_xy_offset_when_vertical do not function independently. Neither will function properly when the other is nil or set to {0, 0}. This isn't documented, so I assuming it's a bug, probably something to do with this being a 2 tank wagon. I can get away with this for now by setting the other offset to something very small, but it'd be nice not to need that workaround.

Specific valve rendering code, if desired. I've been modifying the mk02-fluid wagon (Advanced fluid wagon) from pYIndustry

Code: Select all

    tank_count = 2,
    valve_to_valve_offset_when_horizontal         = {1.64, 0},
    base_valve_xy_offset_when_horizontal          = {0.1, 0},  -- does not work (can set higher for testing)
    base_valve_z_offset_projected_when_horizontal = -1.55,
    valve_to_valve_offset_when_vertical           = {0, 1.2},
    base_valve_xy_offset_when_vertical            = {0, 0},    -- ???
    base_valve_z_offset_projected_when_vertical   = -1.57,

[PennyJim]

From protocol, since his account isn't working right now: Upon further investigation, it seems that the offsets don't function properly when the opposite axis for the other direction is 0 or nil, i.e. the vertical y offset will not function when the horizontal x offset is 0. I haven't checked but this issue may also be present in valve_to_valve_offset, but wouldn't show up because there's no reason to use the y offset horizontally or the x offset vertically.