[2.0.73] FluidWagonPrototype::tank_spacing does nothing

Bugs that are actually features.
User avatar
protocol_1903
Filter Inserter
Filter Inserter
Posts: 539
Joined: Fri Sep 09, 2022 4:33 pm
Contact:

[2.0.73] FluidWagonPrototype::tank_spacing does nothing

Post by protocol_1903 »

Title, the tank_spacing property on fluid wagons doesn't seem to do anything. I got a bug report that describes an issue with 2-port fluid wagons. Since the tank_spacing property is new, I tried that out to fix it. It seems to fix the issue, but as far as I can tell it doesn't do anything else.

All of the screenshots were taken after rebuilding the setup from scratch. pYAE+dependencies used, tested on the "Advanced fluid wagon"
spacing = 0.1
spacing = 0.1
07-30-2026, 18-27-09.png (110.19 KiB) Viewed 378 times
spacing = 0.5
spacing = 0.5
07-30-2026, 18-28-25.png (103.62 KiB) Viewed 378 times
spacing = 2
spacing = 2
07-30-2026, 18-29-32.png (117.1 KiB) Viewed 378 times
spacing = 8
spacing = 8
07-30-2026, 18-32-13.png (117.35 KiB) Viewed 378 times
Last edited by protocol_1903 on Sat Aug 01, 2026 9:34 pm, edited 1 time in total.
pY and pYblock developer, wielder of fluid networks and subtick events in arbitrary ways. I make mods. Check them out, maybe.
https://mods.factorio.com/user/protocol_1903

Buy me a coffee
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4801
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.73] FluidWagonPrototype::tank_spacing does nothing

Post by boskid »

Thanks for the report. This is Not a bug.

Realistically the tank_spacing becomes meaningful only when fluid wagon has at least 3 tanks and since you are showing fluid wagon with 2 tanks, you will not see any behavior changes. There are 2 sets of tank spacing: one is visual related to valves (https://lua-api.factorio.com/latest/pro ... horizontal, https://lua-api.factorio.com/latest/pro ... n_vertical) and one is logical related to selecting tank to connect to (https://lua-api.factorio.com/latest/pro ... nk_spacing) as i did not want to rely on visual valve positioning when pump selects which valve a pump should connect to since there is projection involved. When a fluid wagon has 2 tanks, you effectively have "front tank" (when pump is more forward than fluid wagon position) and "back tank" (when pump is more backwards than fluid wagon position) and no amount of tweaking this parameter will change anything as the transition is always in the center. If a fluid wagon has at least 3 tanks, this value will have meaningful impact on pumps as this value will set the distance between 2 thresholds, first on the boundary of tanks 1-2 and second on the boundary of tanks 2-3.

-- edit:

Wait a second, in the report title you are refering to version 2.0.73. In that version there was no "tank_spacing" as this property was added in 2.1. This makes your report completly invalid.
User avatar
protocol_1903
Filter Inserter
Filter Inserter
Posts: 539
Joined: Fri Sep 09, 2022 4:33 pm
Contact:

Re: [2.0.73] FluidWagonPrototype::tank_spacing does nothing

Post by protocol_1903 »

boskid wrote: Fri Jul 31, 2026 7:38 am Thanks for the report. This is Not a bug.

Realistically the tank_spacing becomes meaningful only when fluid wagon has at least 3 tanks and since you are showing fluid wagon with 2 tanks, you will not see any behavior changes. There are 2 sets of tank spacing: one is visual related to valves (https://lua-api.factorio.com/latest/pro ... horizontal, https://lua-api.factorio.com/latest/pro ... n_vertical) and one is logical related to selecting tank to connect to (https://lua-api.factorio.com/latest/pro ... nk_spacing) as i did not want to rely on visual valve positioning when pump selects which valve a pump should connect to since there is projection involved. When a fluid wagon has 2 tanks, you effectively have "front tank" (when pump is more forward than fluid wagon position) and "back tank" (when pump is more backwards than fluid wagon position) and no amount of tweaking this parameter will change anything as the transition is always in the center. If a fluid wagon has at least 3 tanks, this value will have meaningful impact on pumps as this value will set the distance between 2 thresholds, first on the boundary of tanks 1-2 and second on the boundary of tanks 2-3.
Thanks, that makes sense. Does setting the value relate at all to how it 'fixes' the bug mentioned, where tanks do not connect? Or does it do functionally nothing?
boskid wrote: Fri Jul 31, 2026 7:38 am Wait a second, in the report title you are refering to version 2.0.73. In that version there was no "tank_spacing" as this property was added in 2.1. This makes your report completly invalid.
I meant 2.1.13 i swear
pY and pYblock developer, wielder of fluid networks and subtick events in arbitrary ways. I make mods. Check them out, maybe.
https://mods.factorio.com/user/protocol_1903

Buy me a coffee
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 4801
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [2.0.73] FluidWagonPrototype::tank_spacing does nothing

Post by boskid »

protocol_1903 wrote: Sat Aug 01, 2026 9:34 pm Does setting the value relate at all to how it 'fixes' the bug mentioned, where tanks do not connect? Or does it do functionally nothing?
It defaults to 2, however if you specify this value manually it will just trigger usual "prototypes changed" loading mode where various structures are rebuilt and this may fix the pump in the same way as loading save while holding Ctrl to force prototypes changed mode manually.
User avatar
protocol_1903
Filter Inserter
Filter Inserter
Posts: 539
Joined: Fri Sep 09, 2022 4:33 pm
Contact:

Re: [2.0.73] FluidWagonPrototype::tank_spacing does nothing

Post by protocol_1903 »

boskid wrote: Sat Aug 01, 2026 9:45 pm It defaults to 2, however if you specify this value manually it will just trigger usual "prototypes changed" loading mode where various structures are rebuilt and this may fix the pump in the same way as loading save while holding Ctrl to force prototypes changed mode manually.
Would the generic prototypes changing also rebuild those structures, or does one of a few related prototypes need to be updated for fluid wagons/pumps to update?
pY and pYblock developer, wielder of fluid networks and subtick events in arbitrary ways. I make mods. Check them out, maybe.
https://mods.factorio.com/user/protocol_1903

Buy me a coffee
Post Reply

Return to “Not a bug”