[2.0.32] Crash when flipping blueprint

[TopFu]

Main mod is pyAE. I pressed H to flip the following blueprint horizontally:

0eNqVlNtyozAMQP9Fz6YTLuY2/ZPODmOI0qoFmxpDN5Ph39cOu7BtnWZ4C0Q6PhKSL1C3I/aapIHyAtQoOUD5dIGBnqVo3TspOoQS+rHrX0XzFnRvhxBmBiSP+BvKcP7FAKUhQ7ikXh/OlRy7GrUNYCuCegQGvRpssJIObgFBFqUPnMEZypjHD3ye2TdGdJ/B7zHi+4zkHiPZUwv3M/geRuJnpCujUaol+RwY9YF6+TY/V+asGBxJY7OE2Jrsb6ey0T6Escf8+6N6H0Vrj7cBUunOjoVHKWP+SfHYxOFfl+yzSRj9p3JVCE4acZ9HvnpMop1wsJ3pq7H3diVbu5J97YpzsctgtGqrGl/EREq7xIZ0M5KpUIq6xSOURo/I1tc25bgeciI9mGrbJHO+VjaRNrYQWEWXiAAn1GfzYvvv1sttohFuLYuDe+p6oYVxEvAIs28oij2DlfkHKzzsgaQ3INvKn8RgApID6mWgvtOin76BDx7tMcxvGMY7DLebpfhqmPvY2yVRK2pvQLeFzGd3g5LBzmWstzEDOw7DNYenUZEUBec8zJM0mec/MEvWrA==

Copy blueprint

Instead of flipping, the game immediately crashed.
I'm able to repro the crash whether the blueprint is in the blueprint library or I'm pasting from the clipboard. The crash also happens consistently every time.

The culprit seems to be the Top Up Valve from the Valves mod. I can repro the crash from just copying the valve to clipboard and trying to flip it horizontally.

[Loewchen]

Post a log of a session with the crash please, see 3638.

[Muche]

For a crash when flipping valves from Valves mod see also 121887 Crash flipping modded pump: flipResult.direction != Direction::None.

[Lou]

Could you also provide a savefile where you observed this? Provided info was not suffiscient for reproduction.

[Stringweasel]

Could you also provide a savefile where you observed this? Provided info was not suffiscient for reproduction.

Lou for a breaking unit test you can just create a new entity based on a pump, and change the pipe connections to

Code: Select all

pipe_connections =
  {
    { connection_type = "linked", flow_direction = "output", linked_connection_id=31113 },
    { direction = defines.direction.south, position = {0, 0.5}, flow_direction = "input" }
  }

Then create one, and flip it. Might also be that you need to assert the direction is flipped, because sometimes the direction is wrong instead of broken. And the issue is during prototype loading when it determines all the flip directions before hand it doesn't take linked connections into account. As comparison, crafters do take linked connections into account but it has some extra code around the flipping logic.

It would be awesome if this bug could be fixed