[1.1.69] not-modded luasurface.get_tile() returns invalid tile

[Honktown]

If a tile is in a chunk that's not generated(?) get_tile returns an invalid tile:
1) start new game

Code: Select all

/c
local tile = game.player.surface.get_tile(1000, 0)
game.print(tile.name)

Expectation: The game should not return invalid objects. No tile (new change) or valid tile should be the only returns?

[Rseding91]

Thanks for the report however I don't see this changing in 1.1 since it would break every mod that uses the API and expects non-nil from the function call. It has worked that way since it was added and can easily be .valid checked to see if the chunk exists.

We could probably change it for 1.2.

[curiosity]

You probably should. It's a pretty major expectation.

[Rseding91]

You probably should. It's a pretty major expectation.

You didn't say what should be done.

[curiosity]

You didn't say what should be done.

Maintain the expectation.

[Xorimuth]

Surely any mod that is expecting a non-nil result from get_tile is also expecting a valid result? What could a mod do with an invalid LuaTile that it can't do with a nil LuaTile?

[pleegwat]

The existing interface is that a LuaTile is always returned and you need to check .valid. So most likely all existing mods assume the returned value is non-nil and check .valid, which would trigger an error if they suddenly got nil.

[curiosity]

The existing interface is that a LuaTile is always returned and you need to check .valid. So most likely all existing mods assume the returned value is non-nil and check .valid, which would trigger an error if they suddenly got nil.

Supposedly they check valid. Most likely, I would guess, they don't.