[1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

This subforum contains all the issues which we already resolved.
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

[1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

When my friend (Joined, Linux) desyncs from what we think is packet loss my game crashes (Host, Windows)
I attached all logs that I think are relevant, if more information is necessary just say so as we get this crash fairly often so we can recreate the logs.
Attachments
desync-report-2022-06-24_09-53-49.zip
User who desync's: Desync report - MapData (170 MB)
(644.33 KiB) Downloaded 56 times
factorio-current (2).log
User who desync's: Log
(133.42 KiB) Downloaded 67 times
factorio-dump-current.dmp
Host's: Dump
(1012.29 KiB) Downloaded 71 times
factorio-current.log
Host's: Log
(948.01 KiB) Downloaded 68 times
Last edited by Sakari119 on Sun Jun 26, 2022 10:23 am, edited 1 time in total.
Loewchen
Global Moderator
Global Moderator
Posts: 9448
Joined: Wed Jan 07, 2015 5:53 pm
Contact:

Re: [1.1.59] Desync into crash (ConstructionManager::save)

Post by Loewchen »

Post a link to the complete desync report please.
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

Loewchen wrote: Fri Jun 24, 2022 7:54 pm Post a link to the complete desync report please.
When I upload it to the forum the server validation fails, the full report is 140* MB
Loewchen
Global Moderator
Global Moderator
Posts: 9448
Joined: Wed Jan 07, 2015 5:53 pm
Contact:

Re: [1.1.59] Desync into crash (ConstructionManager::save)

Post by Loewchen »

Do not upload to the forum, post a link. See 53851.
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

https://mega.nz/file/iXJ2Vbja#dR-W7lHOW ... CjU18CusTI
Here is a mega upload of the dysinc report
UpsideDownFoxxo
Burner Inserter
Burner Inserter
Posts: 10
Joined: Mon Aug 30, 2021 2:19 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by UpsideDownFoxxo »

Experiencing the same issue. No desync report since the server crashed before I could finish downloading
Attachments
factorio-current.log
Factorio current as a person that desynced
(127.73 KiB) Downloaded 76 times
Rseding91
Factorio Staff
Factorio Staff
Posts: 14476
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Rseding91 »

UpsideDownFoxxo wrote: Sun Jun 26, 2022 11:53 am Experiencing the same issue. No desync report since the server crashed before I could finish downloading
This crash log doesn't contain a crash. Are you sure you uploaded the right log file?
If you want to get ahold of me I'm almost always on Discord.
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

Rseding91 wrote: Sun Jun 26, 2022 1:26 pm
UpsideDownFoxxo wrote: Sun Jun 26, 2022 11:53 am Experiencing the same issue. No desync report since the server crashed before I could finish downloading
This crash log doesn't contain a crash. Are you sure you uploaded the right log file?
He was a client connected to the server
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

It has come to my attention that the logs may not contain the information that caused the desync / crash

Things that have been thought to cause the issue:
Building any entity / Mining any entity / Blueprinting / deconstructing
Rseding91
Factorio Staff
Factorio Staff
Posts: 14476
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Rseding91 »

Looking into the crash report it's crashing due to a nullptr entry in a set of entities that can never be nullptr: every insertion is checked to not be nullptr. So, I have zero clue how this could ever happen.

The desyncs are around pollution being different. With the number of mods you have unless someone can show otherwise I'm likely to blame one of them for being broken.
If you want to get ahold of me I'm almost always on Discord.
Rseding91
Factorio Staff
Factorio Staff
Posts: 14476
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Rseding91 »

By chance are you using landmines? There's a fix in rampant a month ago around them and i notice you are using rampant fixed which does not have that fix.
If you want to get ahold of me I'm almost always on Discord.
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

Rseding91 wrote: Sun Jun 26, 2022 2:36 pm By chance are you using landmines? There's a fix in rampant a month ago around them and i notice you are using rampant fixed which does not have that fix.
No, we have not used a single mine
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

Rseding91 wrote: Sun Jun 26, 2022 2:22 pm Looking into the crash report it's crashing due to a nullptr entry in a set of entities that can never be nullptr: every insertion is checked to not be nullptr. So, I have zero clue how this could ever happen.

The desyncs are around pollution being different. With the number of mods you have unless someone can show otherwise I'm likely to blame one of them for being broken.
Is there any way we can attempt to replicate this issue so that it can be solved?
Rseding91
Factorio Staff
Factorio Staff
Posts: 14476
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Rseding91 »

Sakari119 wrote: Sun Jun 26, 2022 2:56 pm
Rseding91 wrote: Sun Jun 26, 2022 2:22 pm Looking into the crash report it's crashing due to a nullptr entry in a set of entities that can never be nullptr: every insertion is checked to not be nullptr. So, I have zero clue how this could ever happen.

The desyncs are around pollution being different. With the number of mods you have unless someone can show otherwise I'm likely to blame one of them for being broken.
Is there any way we can attempt to replicate this issue so that it can be solved?
A smaller save file and finding exact steps to reproduce it will tell if it's due to a mod or a base game issue.

Something like:

* Load save
* Do X/Y/Z
* Desyncs
If you want to get ahold of me I'm almost always on Discord.
Rseding91
Factorio Staff
Factorio Staff
Posts: 14476
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Rseding91 »

Hmm, Boskid and i looked into this more and we found at least one way to trigger this issue.

Were you marking cliffs for deconstruction and then canceling them at any point?
If you want to get ahold of me I'm almost always on Discord.
Sakari119
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Sun Oct 22, 2017 9:47 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Sakari119 »

Rseding91 wrote: Sun Jun 26, 2022 8:49 pm Hmm, Boskid and i looked into this more and we found at least one way to trigger this issue.

Were you marking cliffs for deconstruction and then canceling them at any point?
Yes

You seem to be correct with the rampant fixed mod causing the issue swapping it out fixes the desyncs

I will attempt to recreate the issue with a smaller file today
Rseding91
Factorio Staff
Factorio Staff
Posts: 14476
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [1.1.59] - [1.1.61] Desync into crash (ConstructionManager::save)

Post by Rseding91 »

The desync (if it was caused by that or the other issue we found) should be fixed in the next release.
If you want to get ahold of me I'm almost always on Discord.
Post Reply

Return to “Resolved Problems and Bugs”