[posila] [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

[Therax]

Happened when dragging an upgrade planner over some belts that were already marked for upgrade.

[Therax]

The entity was a yellow transport belt.
It was marked for upgrade to a red transport belt.
The upgrade planner had an entry for red->blue, but no entry for yellow->*.
Dragging an upgrade planner with a yellow->blue configuration worked as expected on these belts.

[ViridisWolf]

I encountered what looks like the same crash.
- Was connected to a dedicated server (1.1.30) with mods: Krastorio 2 and FNEI.
- Had upgrade planner which included blue inserter to green inserter upgrade.
- Did generic upgrade of a yellow inserter to blue inserter.
- While the inserter was pending upgrade to blue, used blue-to-green upgrade planner on it.
- Crash.

I reproduced this crash three times when connected to the multiplayer server. I then tried saving the game, loading it in single player, and attempting to reproduce the crash; it did not reproduce there, however.

[acuifex]

i have pretty much same story as @ViridisWolf

happened on my friend's server:
1) go to the map view
2) deupgrade green splitters from krastorio 2 to red
3) upgrade them back
4) crash, addr2line loads 1 core

my frozen game after crash (friend stands to the right):


addr2line:


i won't upload my save file because i'm a bit afraid of leaking chat messages.

[sp55aa]

i have pretty much same story as @ViridisWolf

happened on my friend's server:
1) go to the map view
2) deupgrade green splitters from krastorio 2 to red
3) upgrade them back
4) crash, addr2line loads 1 core

my frozen game after crash (friend stands to the right):


addr2line:


i won't upload my save file because i'm a bit afraid of leaking chat messages.

chat history is not in save file, it's in your game directory

[posila]

chat history is not in save file, it's in your game directory

Chat is also in the save file ... the history in player data json is used for repeating commands by "Arrow up"

[Loewchen]

Ref.: 97769

[posila]

Thanks for the report.
Fixed for next release (1.1.31?)

Upgrading an entity marked for an upgrade in latency state by a planner that doesn't have upgrade rule for original entity but does have a rule for the current upgrade target causes this crash