[1.1.5] Crashing on Mac when loading/updating a (very) large map from previous version

[cshotton]

Running version 1.1.5, no mods, on a MacBookPro13,2. macOS 10.14.6. After launching the game, I attempted to load a very large map ( https://mods.factorio.com/mod/Nauvis-Post-Collapse ) that had been loaded, played, and saved under 1.0. The net result was a crash with no recovery. Here's the relevant log fragment:

Code: Select all

26.609 Factorio initialised
  26.731 Steam Storage Quota: 2605/4768
 177.208 Loading map /Users/xxxx/Library/Application Support/factorio/saves/Nauvis.zip: 464598271 bytes.
 185.915 Loading level.dat: 859116996 bytes.
 185.924 Info Scenario.cpp:196: Map version 1.0.0-0
 185.930 Info PrototypeMigrationList.cpp:194: Activating migration base/1.1.0.json
 264.326 Loading blueprint storage: Local timestamp 1604354401, Cloud timestamp 1604354401
 275.035 Loading script.dat: 386 bytes.
 293.017 Error CrashHandler.cpp:621: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
#1  0x0000000105397c82 in Logger::logStacktrace(StackTraceInfo*) + 0x12
#2  0x0000000104814039 in CrashHandler::writeStackTrace(CrashHandler::CrashReason) + 0xb9
#3  0x000000010537eb64 in CrashHandler::commonSignalHandler(int) + 0x74
#4  0x000000010537e049 in CrashHandler::SignalHandler(int) + 0x9
#5  0x00007fff65681b5d in _sigtramp + 0x1d
#6  0x0000000104211b21 in Chart::flagForDelete() + 0x111
#7  0x00000001046f2939 in ForceData::~ForceData() + 0x159
#8  0x00000001046fdd70 in ForceManager::~ForceManager() + 0x30
#9  0x0000000104f17e03 in Map::~Map() + 0x923
#10 0x00000001050ce6ee in Scenario::~Scenario() + 0xee
#11 0x000000010417accf in Scenario::loadFactory(MapInterface, Filesystem::Path const*, Filesystem::Path const&, ScenarioExecutionContext, LoadType, MapDeserialiser*, InputType, InputHandler*, MultiplayerManagerBase*, ProgressObserver*, bool, InputListener*) + 0x414f
#12 0x00000001050c218b in ParallelScenarioLoader::doLoad(MapInterface, ParallelScenarioLoader*, MapDeserialiser*, InputType, InputHandler*, MultiplayerManagerBase*, NamedBool<EnableReplayTag>) + 0x3ab
#13 0x00000001057733dc in _ZNSt3__114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFv12MapInterfaceP22ParallelScenarioLoaderP15MapDeserialiser9InputTypeP12InputHandlerP22MultiplayerManagerBase9NamedBoolI15EnableReplayTagEES7_S9_SB_SC_SE + 0x8c
#14 0x00007fff6568a2eb in _pthread_body + 0x7e
#15 0x00007fff6568d249 in _pthread_start + 0x42
Stack trace logging done
 293.169 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
 307.807 Uploading log file
 307.844 Info SystemUtil.cpp:547: Started /Users/xxxxx/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents/MacOS/factorio; trampoline PID: 12036
 307.924 Info ChildProcessAgent.cpp:60: Child 12036 exited with return value 0
 307.970 Error Util.cpp:83: mutex lock failed: Invalid argument
 307.970 Error CrashHandler.cpp:621: Received SIGSEGV
1110.705 Received SIGTERM, shutting down

[Loewchen]

Post a link to the save file, see 3638.

[cshotton]

The save file is 464 megabytes. I provided a link to the scenario files in my initial post, which, if you install under 1.0 will create a save file that fails to open in 1.1.5.

I'll try to attach the save file here, but your forum software seems to be refusing it as an attachment due to its size. I can post the file online, but do not want to provide a public URL here due to the size of the file. If you can provide a way for me to tell you the URL privately, I'm happy to make the file available to you that way.

[cshotton]

Here is a link for a version of a save file that loads fine in 1.0 but crashes consistently on 1.1.5 on Mac and Linux.
http://cael.us/NauvisStart.zip

It is simply too large to attach to a forum message. Sorry, but nothing I can do about htat.

[Rseding91]

When I test that save file it loads fine but errors with a script error. After I fix that; it loads without issue.

Could it be you're running out of RAM? You didn't include the full log file so I can't see how much free RAM you had available when the game started.

[cshotton]

After the first crash, it's refused to crash again the same way and simply reports a truncated error message in a dialog and the returns to the main screen (probably what you are seeing).

The save file loads fine and the game runs with no issues under 1.0 on both Mac and Linux. If I switch to 1.1.5 on either O/S, it fails to load. I doubt it is a RAM issue with all the machines being tested having 16 gB of RAM. Unless there's some kind of radical memory footprint increase between 1.0 and 1.1.5, I'd think free memory wouldn't be a likely cause.

What was the script error you were seeing (and fix)? I can try that here, too.

[Rseding91]

The control script in the save file needed to be replaced with the 1.1 freeplay scenario files. For some reason it has non-standard script files and they don't work in 1.1.

[cshotton]

I'll see what I can do with that info. I assume I can lift those files out of a freeplay 1.1 save and copy them into the "broken" save?

Is this something that the migration process could/should catch? Or is that script left alone because it is non-standard to start with?

[Twinsen]

I'll see what I can do with that info. I assume I can lift those files out of a freeplay 1.1 save and copy them into the "broken" save?

Is this something that the migration process could/should catch? Or is that script left alone because it is non-standard to start with?

Yes, just copying the script files from a save should work.
Non-standard scripts should not be migrated so custom saves/custom scenarios are not overwritten.

Moving this to pending...