[1.1.4] Crash on autosaving: this->target.circuitConnectorID == CircuitConnectorID(-1) was not true

[Choumiko]

Right before the autosave i was either pressing Q on a electric pole ghost or already clicking to place it (or the mod MouseOverConstruction was doing it for me, can't remember if i had it turned on)

Error WireConnection.cpp:36: this->target.circuitConnectorID == CircuitConnectorID(-1) was not true

[Loewchen]

Can you reproduce this with the latest loadable save?

[Choumiko]

The last autosave was 10 minutes ago and the ghost didn't exist then. I'm trying to time the autosave and press Q as it happens, but i doubt it's going to work.

[gacekssj4]

Game crashed while autosaving. Broken save attached.

Code: Select all

   0.000 2020-12-03 20:40:09; Factorio 1.1.4 (build 57237, win64, steam)
   0.000 Operating system: Windows 10 (version 1903) 
   0.001 Program arguments: "D:\gry\steam\steamapps\common\Factorio\bin\x64\Factorio.exe" 
   0.001 Read data path: D:/gry/steam/steamapps/common/Factorio/data
   0.001 Write data path: C:/Users/grzegorz/AppData/Roaming/Factorio [11837/113856MB]
   0.001 Binaries path: D:/gry/steam/steamapps/common/Factorio/bin
   0.010 System info: [CPU: AMD Ryzen 5 1500X Quad-Core Processor, 8 cores, RAM: 6270/32700 MB, page: 10337/40700 MB, virtual: 4329/134217727 MB, extended virtual: 0 MB]
   0.010 Display options: [FullScreen: 1] [VSync: 1] [UIScale: automatic (100.0%)] [Native DPI: 1] [Screen: 255] [Special: lmw] [Lang: en]
   0.022 Available displays: 2
   0.022  [0]: \\.\DISPLAY1 - Radeon RX 590 Series {0x80005, [0,0], 1920x1080, 32bit, 60Hz}
   0.023  [1]: \\.\DISPLAY2 - Radeon RX 590 Series {0x80001, [1920,0], 1920x1080, 32bit, 60Hz}
   0.102 [Direct3D11] Display: 0, Output: 0, DisplayAdapter: 0, RenderingAdapter: 0; d3dcompiler_47.dll
   0.227 Initialised Direct3D[0]: Radeon RX 590 Series; id: 1002-67df; driver: aticfx64.dll 27.20.12027.1001
   0.227   D3D Feature Level: 11.1, DXGI 1.5+, SwapChain: 3,flip-discard,-,-,-,none
   0.228   [Local Video Memory] Budget: 6946MB, CurrentUsage: 0MB, Reservation: 0/3677MB
   0.228   [Non-Local Vid.Mem.] Budget: 14715MB, CurrentUsage: 0MB, Reservation: 0/7766MB
   0.228   Tiled resources: Tier 2
   0.228   Unified Memory Architecture: No
   0.228   BGR 565 Supported: Yes
   0.228   MaximumFrameLatency: 3, GPUThreadPriority: 0
   0.228 Graphics settings preset: very-high
   0.228   Dedicated video memory size 8171 MB
   0.292 Desktop composition is active.
   0.292 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 25%] [DXT: high-quality] [Color: 32bit]
   0.292                   [Max threads (load/render): 32/8] [Max texture size: 0] [Tex.Stream.: 0] [Rotation quality: normal] [Other: STDCWT] [B:0,C:0,S:100]
   0.375 DSound: Starting _dsound_update thread
   0.375 [Audio] Backend:default; Depth:16, Channel:2, Frequency:44100; MixerQuality:linear
   0.375 DSound: Enter _dsound_update; tid=11224
   0.514 Error GlobalModSettings.cpp:177: Failed to read mod settings: Map version 0.17.69-1 cannot be loaded because it is lower than the minimum input version (0.18.0-0).
   0.515 Loading mod core 0.0.0 (data.lua)
   0.654 Loading mod base 1.1.4 (data.lua)
   1.072 Loading mod base 1.1.4 (data-updates.lua)
   1.264 Checksum for core: 2991549523
   1.264 Checksum of base: 3534851188
   1.494 Prototype list checksum: 1154245852
   1.559 Loading sounds...
   1.725 Info PlayerData.cpp:72: Local player-data.json unavailable
   1.725 Info PlayerData.cpp:75: Cloud player-data.json available, timestamp 1606964887
   1.878 Crop bitmaps.
  16.730 Parallel Sprite Loader initialized (threads: 7)
  24.751 Initial atlas bitmap size is 16384
  24.800 Created atlas bitmap 16384x16368 [none]
  24.805 Created atlas bitmap 16384x13064 [none]
  24.805 Created atlas bitmap 8192x4188 [decal]
  24.806 Created atlas bitmap 16384x5568 [low-object, linear-minification]
  24.807 Created atlas bitmap 8192x4432 [mipmap, linear-minification, linear-magnification, linear-mip-level]
  24.807 Created atlas bitmap 16384x6064 [terrain, mipmap, linear-minification, linear-mip-level]
  24.808 Created atlas bitmap 4096x3216 [terrain-effect-map, mipmap, linear-minification, linear-mip-level]
  24.808 Created atlas bitmap 4096x1840 [smoke, mipmap, linear-minification, linear-magnification]
  24.808 Created atlas bitmap 4096x3104 [mipmap]
  24.809 Created atlas bitmap 8192x2208 [icon, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level]
  24.809 Created atlas bitmap 8192x1496 [alpha-mask]
  24.812 Created atlas bitmap 16384x14768 [shadow, linear-magnification, alpha-mask]
  24.813 Created atlas bitmap 8192x2352 [shadow, mipmap, linear-magnification, alpha-mask]
  24.813 Created atlas bitmap 2048x240 [icon-background, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, ]
  24.825 Texture processor created (2048). GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
  25.713 Parallel Sprite Loader initialized (threads: 7)
  35.052 Sprites loaded
  35.090 Generated mipmaps (4) for atlas [3] of size 16384x5568   
  35.101 Generated mipmaps (3) for atlas [4] of size 8192x4432   
  35.123 Generated mipmaps (3) for atlas [5] of size 16384x6064   
  35.134 Generated mipmaps (3) for atlas [6] of size 4096x3216   
  35.145 Generated mipmaps (3) for atlas [7] of size 4096x1840   
  35.195 Generated mipmaps (3) for atlas [8] of size 4096x3104   
  35.206 Generated mipmaps (5) for atlas [9] of size 8192x2208   
  35.218 Generated mipmaps (3) for atlas [12] of size 8192x2352   
  35.221 Custom mipmaps uploaded.
  35.677 Factorio initialised
  35.741 Steam Storage Quota: 4457/4768
  56.346 Loading map C:\Users\grzegorz\AppData\Roaming\Factorio\saves\jakas fun gra[item=transport-belt].zip: 5351385 bytes.
  56.389 Loading level.dat: 12724631 bytes.
  56.393 Info Scenario.cpp:196: Map version 1.1.3-1
  56.795 Loading script.dat: 398 bytes.
  56.799 Checksum for script C:/Users/grzegorz/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 2501771973
 205.931 Info AppManager.cpp:306: Saving to _autosave3 (blocking).
 206.344 Info AppManagerStates.cpp:1930: Saving finished
 511.006 Info AppManager.cpp:306: Saving to _autosave1 (blocking).
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-build-uj2pbl\src\wireconnection.cpp (36): BasicWireConnection<PersistentTargeter<Entity,0> >::checkConsistency
c:\cygwin64\tmp\factorio-build-uj2pbl\src\entity\entityghost.cpp (208): EntityGhost::save
c:\cygwin64\tmp\factorio-build-uj2pbl\src\surface\chunk.cpp (109): Chunk::save
c:\cygwin64\tmp\factorio-build-uj2pbl\src\surface\surface.cpp (919): Surface::save
c:\cygwin64\tmp\factorio-build-uj2pbl\src\map\map.cpp (1370): Map::save
c:\cygwin64\tmp\factorio-build-uj2pbl\src\scenario\scenario.cpp (1027): Scenario::saveMap
c:\cygwin64\tmp\factorio-build-uj2pbl\src\scenario\scenario.cpp (923): Scenario::saveAs
c:\cygwin64\tmp\factorio-build-uj2pbl\src\scenario\parallelscenariosaver.cpp (118): ParallelScenarioSaver::doSave
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (230): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl LogitechLEDController::*)(void),LogitechLEDController *>,std::default_delete<std::tuple<void (__cdecl LogitechLEDController::*)(void),LogitechLEDController *> > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (209): std::_Pad::_Call_func
minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC0A387BD4)
00007FFC0A387BD4 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC0BC4CED1)
00007FFC0BC4CED1 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
 514.137 Error WireConnection.cpp:36: this->target.circuitConnectorID == CircuitConnectorID(-1) was not true
Logger::writeStacktrace skipped.
 514.137 Error CrashHandler.cpp:189: Map tick at moment of crash: 1530001
 514.137 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
 593.418 Uploading log file
 593.488 Error CrashHandler.cpp:258: Heap validation: success.
 593.491 Creating crash dump.
 593.955 CrashDump success

[Loewchen]

Can you reproduce the crash with a loadable save file?

[gacekssj4]

I managed fully reproduce crash. Even on new map.

Created new map, built ghost big power pole traction by drag and drop and viola. Game crashes on each save.

[Mdc211]

From my testing it only occurs with ghost power poles and they have to be drag placed not click placed. Upon doing that I get a consistent failure when saving the game. This occurs with small electric poles also.

[Rseding91]

Thanks for the report and the reproduction steps. It's now fixed for the next release.

[Ordep]

I got the same crash, the last thing i did was open the production statistics window, then the game started the autosave and just before ending the autosave the crash appeared.

I attach my report and a link to the last save files.

https://drive.google.com/drive/folders/ ... sp=sharing

autosave2.tmp.zip - The autosave that maked the crash.
mundoferroviario2.0.zip - The last save maked by myself.

[Durr]

I just got the same crash. Autosave started and failed as I was adding fuel to a train. A few minutes earlier I placed ghosts for quite a few medium electric poles, maybe related?

Edit: Replaced the save file with one closer to the time of the crash

[CrimsonGhost0]

I'm pretty sure I encountered the same crash. I've attached a crash dump along with my log, hope it helps.