[posila] [1.1.1] Crash because of undo

[floppnow]

I blue-printed a structure into my new created 1.1.1 world. I accidentaly misplaced a large power pole. So I hit control-Z to undo which crashed the game. I reproduced it accidentally a second time, so now i'm reporting it here. save is attached. powerpole marked by a concrete arrow on the map. I reproduced it several times...

[billbo99]

Something similar happened on our server.

Code: Select all

23265.578 Error CrashHandler.cpp:621: Received SIGSEGV
23274.180 Warning Logger.cpp:526: Symbols.size() == 42, usedSize == 26
Factorio crashed. Generating symbolized stacktrace, please wait ...
Raw stacktrace: 0xb1aec5, 0xd4b635, 0xd4bcc1, 0xd4bd79, 0x3b8f0, 0x6b9b6a, 0xebb323, 0xb31bbc, 0xc87946, 0x96e485, 0xce91e6, 0xede383, 0x978e6c, 0x978f81, 0xdba0f2, 0xdce0c1, 0xf0f770, 0x12d61ff, 0x12d6655, 0x12fbad9, 0x12fc633, 0x12fe49a, 0x12ff3ff, 0x5b6a88, 0, 0x5c824e
23282.777 Warning Logger.cpp:526: Symbols.size() == 37, usedSize == 25
#0  0x0000000000d4b635 in GlobalContext::getMap() at /tmp/factorio-build-Y4D1DE/src/GlobalContext.cpp:2007
#1  0x0000000000d4bcc1 in CrashHandler::writeStackTrace(CrashHandler::CrashReason) at /tmp/factorio-build-Y4D1DE/src/Util/CrashHandler.cpp:188
#2  0x0000000000d4bd79 in CrashHandler::commonSignalHandler(int) at /tmp/factorio-build-Y4D1DE/src/Util/CrashHandler.cpp:623
#3  0x000000000003b8f0 in CrashHandler::SignalHandler(int) at /tmp/factorio-build-Y4D1DE/src/Util/CrashHandler.cpp:638
#4  0x00000000006b9b6a in ?? at ??:0
#5  0x0000000000ebb323 in EntityGhost::haveCommonNeighbour(Entity const*) const at /tmp/factorio-build-Y4D1DE/src/Entity/EntityGhost.cpp:765
#6  0x0000000000b31bbc in EntityGhost::setup(SetupData const&) at /tmp/factorio-build-Y4D1DE/src/Entity/EntityGhost.cpp:443
#7  0x0000000000c87946 in Entity::runSetup(SetupData const&) at /tmp/factorio-build-Y4D1DE/src/Entity/Entity.cpp:361
#8  0x000000000096e485 in Surface::setupEntity(Entity*, SetupData const&, bool) at /tmp/factorio-build-Y4D1DE/src/Surface/Surface.cpp:195
#9  0x0000000000ce91e6 in Surface::addEntity(Entity*, PropertyTree const*, bool, Surface::GhostForKilledEntity, EntityToEntityMapping const*) at /tmp/factorio-build-Y4D1DE/src/Surface/Surface.cpp:190
#10 0x0000000000ede383 in TargeterBase::clear() at /tmp/factorio-build-Y4D1DE/src/Util/Targeter.cpp:103
#11 0x0000000000978e6c in RemovedEntityUndoAction::apply(UndoApplyContext&) at /tmp/factorio-build-Y4D1DE/src/RemovedEntityUndoAction.cpp:168
#12 0x0000000000978f81 in UndoItem::undo(Player*) at /tmp/factorio-build-Y4D1DE/src/UndoItem.cpp:41
#13 0x0000000000dba0f2 in std::vector<std::unique_ptr<UndoAction, std::default_delete<UndoAction> >, std::allocator<std::unique_ptr<UndoAction, std::default_delete<UndoAction> > > >::~vector() at /home/build/gcc-9.2/include/c++/9.2.0/bits/stl_vector.h:677
#14 0x0000000000dce0c1 in UndoItem::~UndoItem() at /tmp/factorio-build-Y4D1DE/src/UndoItem.hpp:36
#15 0x0000000000f0f770 in UndoQueue::undo() at /tmp/factorio-build-Y4D1DE/src/UndoQueue.cpp:38
#16 0x00000000012d61ff in CommonActionHandler::undo(Controller*) at /tmp/factorio-build-Y4D1DE/src/Input/CommonActionHandler.cpp:1849
#17 0x00000000012d6655 in GameActionHandler::undo(InputAction const&, Controller*) at /tmp/factorio-build-Y4D1DE/src/GameActionHandler.cpp:1403
#18 0x00000000012fbad9 in GameActionHandler::actionPerformed(InputAction const&) at /tmp/factorio-build-Y4D1DE/src/GameActionHandler.cpp:376 (discriminator 1)
#19 0x00000000012fc633 in InputHandler::flushToListeners(InputAction const&, bool) at /tmp/factorio-build-Y4D1DE/src/Input/InputHandler.cpp:72
#20 0x00000000012fe49a in InputHandler::flushActions(bool, unsigned int) at /tmp/factorio-build-Y4D1DE/src/Input/InputHandler.cpp:64
#21 0x00000000012ff3ff in NetworkInputHandler::flushActions(bool, unsigned int) at /tmp/factorio-build-Y4D1DE/src/Net/NetworkInputHandler.cpp:180
#22 0x00000000005b6a88 in InputHandler::nextTick(unsigned int) at /tmp/factorio-build-Y4D1DE/src/Input/InputHandler.cpp:52
#23 (nil) in NetworkInputHandler::nextTick(unsigned int) at /tmp/factorio-build-Y4D1DE/src/Net/NetworkInputHandler.cpp:127
#24 0x00000000005c824e in NetworkInputHandler::tryToApplyNextTickClosure() at /tmp/factorio-build-Y4D1DE/src/Net/NetworkInputHandler.cpp:120
#25 (nil) in ServerMultiplayerManager::updateMultiplayerInputInternal() at /tmp/factorio-build-Y4D1DE/src/Net/ServerMultiplayerManager.cpp:734
#26 (nil) in ServerMultiplayerManager::updateMultiplayerInputInternal() at /tmp/factorio-build-Y4D1DE/src/Net/ServerMultiplayerManager.cpp:721
#27 0xfffbd37500003ce6 in MultiplayerManagerBase::updateMultiplayerInput() at /tmp/factorio-build-Y4D1DE/src/Net/MultiplayerManagerBase.cpp:174
#28 (nil) in MainLoop::gameUpdateStep(MultiplayerManagerBase*, Scenario*, AppManager*, MainLoop::HeavyMode) at /tmp/factorio-build-Y4D1DE/src/MainLoop.cpp:1231
#29 (nil) in MainLoop::gameUpdateLoop(MainLoop::HeavyMode) at /tmp/factorio-build-Y4D1DE/src/MainLoop.cpp:1115
#30 0x0000000000000001 in MainLoop::mainLoopStepHeadless(MainLoop::HeavyMode) at /tmp/factorio-build-Y4D1DE/src/MainLoop.cpp:621
#31 0x00007f8dd00166d0 in MainLoop::run(Filesystem::Path const&, Filesystem::Path const&, bool, bool, std::function<void ()>, Filesystem::Path const&, MainLoop::HeavyMode) at /tmp/factorio-build-Y4D1DE/src/MainLoop.cpp:387
#32 0x00007f8dd14e8300 in hostMultiplayerGameInternal(cxxopts::ParseResult const&, bool) at /tmp/factorio-build-Y4D1DE/src/CommandLineMultiplayer.cpp:290 (discriminator 2)
#33 (nil) in CommandLineMultiplayer::hostCommandLineMultiplayerGame(cxxopts::ParseResult const&, Filesystem::Path const&, Filesystem::Path const&, bool) at /tmp/factorio-build-Y4D1DE/src/CommandLineMultiplayer.cpp:341 (discriminator 2)
#34 0x000000001c74c4a8 in main at /tmp/factorio-build-Y4D1DE/src/Main.cpp:653
#35 0x000000001c74c420 in ?? at ??:0
#36 0x7fffffff7fffffff in _start at ??:?
Stack trace logging done
23282.777 Error CrashHandler.cpp:189: Map tick at moment of crash: 6280008
23282.777 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
23282.777 Uploading log file

[posila]

Thanks for the report.
Fixed for 1.1.2: 91945