[MOD 0.17] Crafting Combinator

[arbarbonif]

The new 0.18 version errors for me on load.

12.695 Mods to disable:Failed to load mods: __rusty-locale__/prototypes.lua:21: table index is nil
stack traceback:
__rusty-locale__/prototypes.lua:21: in function 'inherits'
__rusty-locale__/prototypes.lua:29: in function 'find'
__rusty-locale__/locale.lua:54: in function 'f'
__rusty-locale__/util.lua:10: in function '__index'
__rusty-locale__/locale.lua:57: in function 'f'
__rusty-locale__/util.lua:10: in function '__index'
__crafting_combinator__/data-final-fixes.lua:128: in function 'make_signal_for_recipe'
__crafting_combinator__/data-final-fixes.lua:142: in function 'process_recipe'
__crafting_combinator__/data-final-fixes.lua:173: in main chunk


EDIT: It also looks like the latest Bottleneck update broke stuff. The API was changed.

[theRustyKnife]

...

Seems like I missed something in the main product logic... Could I have your modlist, so I can find the offending recipe?

[theRustyKnife]

...

I fixed an issue that could cause this in rusty-locale 1.0.1 - let me know if it's still broken after updating.

[arbarbonif]

That appears to have fixed it. Thanks!

[caribou666]

Hi,

Sorry for my english, i'm not fluent at all :/

Well, i'd like to propose a feature to the mod, an option which could prevent to stop the manufacturing in progress if there a new recipe incoming or machine empty. I saw a solution with a timer and some calculation, but i'm not clever enought to do it.

Thanks for that incredible mod.
Stay safe.

J

[theRustyKnife]

...

Do I understand correctly that you'd want the combinator to wait for the current craft to finish before switching the recipe?

If that's the case then I'm afraid it's not happening. There are a few reasons, but the main issue is that there is no event for when machines finish crafting. To be clear, it's possible with the current api, but it will require a pretty big rewrite and probably cause performance issues (which there are enough of already ), so I just don't find it worth the time and effort...

[caribou666]

Yes you understood perfectly. As the combinator can read the speed and some people do it with some other calculators i thought it was possible. I'll wait for an update of the API
Thanks for your answer.

[Kiu]

Updated to 0.18 today, got that crash while loading a 0.17 game.
Removing and readding the mod seems to fix the issue, game can still be loeaded after readding all the combinators to the map, so it is not a big issue...

[theRustyKnife]

...

I feel like broken migrations are going to become my legacy at this point... I'll have a look at it when I get to working on the mod again, but for now it's a low priority thing since, as you said, it's not a big issue. There were also some semi-breaking changes in 0.15.0, so there's a good chance something would break anyway.

[Eclipt]

I, and many other people had to update the game to 1.0 lately. I get the same error message as Kiu and it stops me from opening my over 400h heavily modded save. I can`t disable the crafting combinator since it is integral to some of my builds. I suppose there are many people in similar situation. It would be great if this bug was fixed if you have the time and energy to come back to the mod.

[theRustyKnife]

...

Alright, I'll see what I can do about it. It would be quite helpful if I could have the save tho, since I don't really have one of my own that would be good for testing this kind of thing and replicating all the possible scenarios by hand would take forever...

Also, I can't really promise anything, since as I said multiple times already, there were some pretty major changes so it's possible there are things that I just can't make reasonable migrations for. I should at least be able to get it to load tho, so you can at least go in and fix things manually if it comes to that...

[SHOOROOP]

I have not found information anywhere on how to use the Recipe Combinator. I gave the usual signals and signals from the mod, but nothing happened. Can you explain please

[gex87]

Block A works like it should but is not fully what i want
Block C and D are set up with the Multiplicator and the Multiplication is working BUT the recipe combinator get the multiplied Product Count (in this case the Product is Multiplied with 3) but also get the Multiplier M and because of this the recipe combinator is not working. I had to get rid of the M Constant in the Input of the Recipe Combinator

Second Problem
Block A is working because the export Inserter is et to the Product Lamp and get the On/Off Signal from the "Order Combinator" on Top of the Screenshot
Block B and therefore C and D (where it should work in the End) the inserter is not working because i don't set the Product in the Enable Condition. I don't want to do the Manually I want that the export inserter is Exporting the Number of Items set in the "Order Combinator" without that i have to set the condition by myself. I thought i can read the recipe with the recipe combinator (like i have don't it for the Material order in the Requester Chest) and give that "Recipe" as enable condition to the inserter.
So when i change the Recipe, the Requester Chest is change the ordered materials (multiplied by the Player given Multiplier) and the exporting inserter is automatic set to the right Product and gets his Amount of exported Products from the "Order Combinator"

[Trigun]

is possible to disable the autoload feature from the chest?
i want use inserters for loading so i can control the loading

[mycrazyautomation]

Has anyone had luck using crafting combinator with anything that produces different fluid results? E.g. I'm working with floatation cells in SeaBlock.

I've tried essentially everything I can think of (combinators to pump down the outlets network before switching, circulating fluid, etc.) but no matter what I seem to get a deadlock where the fluid mixture exists in the outlet network and I have no way to empty it automatically.

[sticklord]

Made a tiny little skin for this so they stand from other combinators:

image_2021-10-31_103406.png (558.8 KiB) Viewed 6525 times

add this to the data.lua file and put the image in graphics folder
for _, dir in pairs(rc.multiply_symbol_sprites) do
dir.hr_version.filename = '__crafting_combinator__/graphics/hr-combinator-displays.png'
end

[theRustyKnife]

...

Damn, wish I'd thought of checking the forum a couple minutes earlier, now I'll have to make another release lol. Either way, thanks for this, it was sorely needed for ages now.

[danbopes]

Would it be possible to have the crafting combinator output a signal (Perhaps a red signal), when the machine is trying to stop. I'd like to have my machine intelligently shutdown by preventing inserters from putting more items in. I currently have one combinator writing the signal to the machine, and another one reading. I'd like to avoid some complicated logic to determine if the current signals contains the current one.

[Trigun]

i think this function can be improved

Code: Select all

function _M:insert_items()
	local inventory = self.inventories.chest
	if not inventory or not inventory.valid or inventory.is_empty() then return; end
	local target = self.inventories.assembler.input
	
	for i = 1, #inventory do
		local stack = inventory[i]
		if stack.valid_for_read then
			local r = target.insert(stack)
			if r < stack.count then stack.count = stack.count - r
			else stack.clear(); end
		end
	end
end

if i understand the lua (i don't know lua, only java, javascript and other languages) the for is on all the chest inventory, if u have 100 different items is a for on 100 elements
in the move_items function instead is used this

Code: Select all

if self.assembler.crafting_progress > 0 then
		local success = true
		for _, ing in pairs(self.assembler.get_recipe().ingredients) do
			if ing.type == 'item' then
				if not target then return false, 'no-chest'; end
				local r = target.insert{name = ing.name, count = ing.amount}
				if r < ing.amount then success = false; end
			end
		end
		self.assembler.crafting_progress = 0
		if not success then return false, 'chest-full'; end
	end

so the for is only for the recipe ingredients, much less items
and i noticed a boring thing with the insert_items, if u have a big craft (like the cargo rocket silo on Space exploration) it will drain all the steel/cement and if u have a way for refull the chest automatically, for ex buffer chest, u will end with 20k of steel in the chest, bc every time it will put all the steel on the assembler, the chest get more steel, and this will go in the assembler again, until it say chest is full
tried to switch my signal in pulse for prevent this, it will slow the process but every time it need to craft 1 of the expensives items it will increase the resource

i think the best way should be to get something like

Code: Select all

local r = target.insert{name = ing.name, count = ing.amount*signal_value}

this problem happens with smaller recipes if u share the same chest for multiple assemblers, all assemblers get filled and empty the chest that get reloaed

cc1.png (514.58 KiB) Viewed 5333 times

cc2.png (748.28 KiB) Viewed 5333 times

if u wanna try the mall u need space exploration (or change with normal assemblers), moon logic, crafting combinator, inventory sensor, aai containers & warehouses
this code is for the v2 where i added a tons of combinator for reduce the problem

Code: Select all

0eNrlHGtu87jxKoaAArvfWgs9/QiQ/dEr7M/NB4OWaJuNRGopyqkb5AC9Rc/Wk3Qo2RZlUzJpO/mSboAklkQOh/Oe4civzjKrcMEJFc7Dq0MSRkvn4Y9XpyRrijJ5T+wK7Dw4RODcGTsU5fKqxG5ZoAS7OaLVCiWC8Z3zNnYITfE/nQf/7fvYwVQQQXADr77YLWiVLzGHAcOQxk7BSpjMqMQAAE7jX+Oxs3MeQvgA66SE46R5Howd+ExqJDOWsJwJssUAQmJcyvllgXHq5iytMuyGzgNA6tyaS4TfxmdIBkckU1ggxdwF6EtCEeB4juJkdkBxDggCIQVn2WKJN2hLYDwM2kNZwLO0nlljtyK8FIszem8JFxXcaQlVj3DXHGPqNCuUAkm++fIiLxCvEXtw/vvv/8A0VomisgCMt5jvxIbQdQO92AGiFRWLFWf5glAA5jwIXuG3ZnHaMKDegy//cJyqrCZwFcJIwpOKiPrSV4gsryfdx8HJ4/npYxCqZvsnywRnAwHFQOJkMvwUq/Acmk46QjvpmH8W6Xj8JLJxgQvR6eM+5kfDcILoJuEIhtE6fex7PdISHUmKOBGbHAuSDArM1LskMC2gO8lMiSWcRSs6LsgOKzBITo2X8+0K0dlDv8Vo9HH+fOAgZw31OrbT6+meTZH/Ja3+3wcUeoWyslejtSSe2hr0QYbNzvmrY9jkOjf98Qybzu9gihXAd2LarJcrJlZbz5Ppdc6x5okS20UfzKGZ98U4pB0em/FodrVL6lWd93JJdubsnV2WGYvGQyw5fRzEtqZwPGR3L8TZfQIxt1Laqf8hhvT3rooGP1pBdTZxcpsFHd+kxr533F/C0UpAkL5o+fZwuDfMy/DAS69Or43F3jCm8v074Bic4XgmcSuSCcx7Khhn4jCISl0haISkkoIXeZ53rG80HDaNZz1DRrb1BoSI+4I43rCqxO6yWq2wjiKThh6RBS46UyALKH9WGLRSpd+hlHNEap2hsnSOBIk9T27iQJHjMMIZdYsMCdw3ts2cQQHBVg+PbjOnUmCcnQ72vc7oNnqHcaX0aEvE+0BP1CrUtsoSRIkAemcsee6soMxpIxucAcFhs9JrNiTtxUpxtekW0QSnF6fMT9aBVTBdE4rdiqrTujtSjEHBWYLLUsry4AylFCcYgF/CUs+9owOFdzTheIAVfsvnjL24KaYgvTu3FLxKRMWViUF3XsvxJRIgjztH1UJ1ZKwycIORcMsNwVkqCxV9O+gwPUfJRtI0w4hTSaoUCaROVWdOVdqmsAmylRs6FhZ7ps00tU7COeN9E1rWlyxDoB6I4qxncNAyHCVJlVfZ3npqhTc4YXYf0EBFGYzTLstIlbtAICZ6YYfqpITvWK1MQKneGdE5ZThKSXcHXcy6HGdZrsGrO6Pld8VBv2H4qgIzkuCsl6bTc7wMONHhM6aYr3duAuKUsXWFXb8z7bvO/oeDnqnEQt4q3WbakBP3awcpgySIxWt7/irN4W6JkufFlmWVXARE4XhvnbElyrLdPvYZO3DBXhYFy3bFhtHD/Tf5AHOx6IIuNzC2fnCcX99idJGjoikMHmbmYJLQWu7xNXn0x+mjN17BfwK/+eOT8/LkjDl8LuH+vx69N0frKKN7Ecr7PydUfCOhgq9PKF4TygNC+QOEao2EPDVyS/BV2hg06hLkcqnCLiIldLtf2wUXAxE3BFxtCOop52vjy0d0SrTUwghnMyWKvQyljubW4B3dlw3AUyD5UroOEZ0BJE241AIL/BatyASYEgopUI4wYhMCdY8FWzDtvia2YOYqgY5gplbpgmG2roQjkBsnz+AFS9AHbaIQq2KrgzW70VBEX9/1mBmK+Y2EmvxFfLQSl9odo4QfUpW/qq54h+OW3+9ZdvIvnHxOTCtNp5AuFLAmZkUfJdkwLDC3ZzPhDzvz9Lr141+uO1OzYaNnd4wZGJaTlCTOlPzzjyI/hrT73U6cG+A2HLA7AQut1U7PH7sGkvbwJfzgc0v303aQBMYNQlPLJpDIkIfRlUcm4cedcx50rWPiOvz87Wolu4qTeoqHdhwKDRkUq/XKev+GhwzhaYI3uUeCd65lJ6mC35sq3NIiEUyujMbir2hr7hpkXegHG/DeGmjzC67DM4ys2tQvz5IhRx5f58hbhkR+6M+kFl0KlP7mvF1/JNZvucPQyjfPjUPeUHsQJtC6RhzICltNJYVdN8Vl8pBDuvVEQRRHj6PXtyeawH/via4YHz2PR9sRoaMCAfF+ArR+HqXsiY7gh6xGMBBGjsQG0+be/n4pOHjDX1eg+D8BhCdniTjH2ZPz88lY+QPr/vHk4LwQO/cw7jtg4LfDMAh2d5JukRUqhcsohhxu5I9H0k7r1mvXPExw82d/1DRany2tX/4A41mO3n/4ZbQ9mUZTZQuHi+OHpFmovtYRu+btJyH34F4vbS3FkOfDnQnIlJS4w9W3+MnRJ9izK9ve3tWkn4Z5fSHHZ2jb0BihIdNi2PkWDFeIGg0yjPTNSsy9tvySyf5mY7JtQ2jTrofQuzKEfl85/mxBs4Yj/oB3mw9HLeHZDbsWpgvtaMHUkPf+jdXUjqZ89lqqrKMS+JU1VNgWeGAGV+LR7ymhhsG1uUv8jg1SewMmSK4eK7lz+PEvnE/d1oB1skRglygZm6PwVvPdBt/Ttx9psMPYsuZhqrQ3nr536fM1lHZ/QoSTy0obX1nVm/7V3ZnGBfW98TXsnULD2lA4sW6A969W7S9dIPfPXnObDHMgNn6Fy9QsK4fd1RJoUW9fc9DdsGemhTGz86etoZpf50+7fQKZoOpySvHPrq8jY2tSN7YKjgh1S8EKbe+CSXeHktwH2nKkSWNHgviauS9ozahL8pxxATKWP4dagCbNHausIqkpwNguDoj6XtAM59dKx+we0qG2HenrwmOTl/LbXs3Txp+g074+Nn/D/9CR6QbaTpvQDNahVXMILRPZWJK1e2yIBtevwoo9u/6fww5lp3iO3LXs2TzVTbtWoNY0abGa2tMdYLkZWrIasZ0Ws5kNVKWPtcNQBcu5AbzuCwoFKkuyxbJnbSuDFb0Eeya2RKN6qrC00AwVgrPkGQsgYUWTDSCa6nEz1Ii6c5jjFaG4hxm+iT6sShfkXj8/MsMEYc5WMr49VQJfUSjfUA2KXdYRWZXOEzv9TtCyHx1L+SdZ9/2bFpCJyMv57n6M3tnOTaEkm9rTDsAKPEs31He0E3mWSb93FqQYJsSz02826EXJt0TJv6tnrGOUY2+j0slq2w7b6ZHUwglswq9kgwExJN8C0Vq+2NZF7p1RXV1h7poDmFQvbSY24h9YFHLHgRYlE8Ng+qaeLiowsRq6l2iiOzhO9VUNLTQT66Ge/fSYs7kNUgKClhISZawll5FvPMLad1LnaE1lplnqA4TA2lc20CEYwvwiSKsQckkYaEtOEojjLwG2UxbEgQAgNyhJgCq8Vx5N3WoDFiwOkBfLGPMyca1CzQ085QkDl92D58QGGtiIF7FxVyghmay1aSFa6Y7YYA6quIP7vXv37fxwf5u9rSvG8szXlVZND+V+Tji41gnfxePVa8qXJGXwz9mSiR6q2birATiBZShN5fuVvbG0lQKXCcG0NjpLrfRGRiFaivgd0sBU1toECD5t0i6NWlmmg7AvssJlVRSMi2F4Uzv7VOJ8mUku7F9g1ccJs2vy/Ds4KNixtHJ5UYHIu/4NTgnwQWswS4g+9wTxV8Rs+7fdcV8RLrIHOZQBe1f6ChkJ9iRlhtLCcbJLajEZlD2zdArshxTj++Q/4fw0+zj7/jfv9Iha+30Y35vveZSVoeMXWY4dMCcQtknfA4Qcydat0TaA+1uwwM2XRs78aDoPpnEcRfF08vb2P+t2C/c=

[MrVSV]

Is it possible to update recipe list? Too many recipes are missing. AB mods