[HELPER 0.13-1.1] Screenshot Maker Deluxe 3.0 (EN,DE,JP)

Topics and discussion about specific mods
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

[HELPER 0.13-1.1] Screenshot Maker Deluxe 3.0 (EN,DE,JP)

Post by eradicator »

This post is outdated.

See Eradicator's Screenshot Maker Deluxe 3.0 on the mod-portal for the latest information and releases.

Old 2.0 Post
Pictures
Changelog
How to take a picture
Version Archive
Last edited by eradicator on Mon Mar 15, 2021 10:56 pm, edited 19 times in total.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
Liono2010
Inserter
Inserter
Posts: 24
Joined: Mon Nov 17, 2014 9:06 pm
Contact:

Re: [UTILITY 0.13.10] Screenshot Hotkey

Post by Liono2010 »

I thought to create such a mod, but I found that it had already been made.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [HELPER 0.16.49] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by eradicator »

After getting no requests whatsoever, i finally decided to bring this best of all screenshot tools to 0.16.
Enjoy Screenshot Hotkey 2.0! :mrgreen:

melie
Manual Inserter
Manual Inserter
Posts: 3
Joined: Sat Aug 03, 2019 1:08 am
Contact:

Re: [HELPER 0.16.49] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by melie »

Hey, can you fix lines 141..145 (control.lua) from

Code: Select all

    args.xpos = tonumber (pmain['xpos_text'    ].text)
    args.ypos = tonumber (pmain['ypos_text'    ].text)
    args.xres = tointeger(pmain['xres_text'    ].text)
    args.yres = tointeger(pmain['yres_text'    ].text)
    args.zoom = tonumber (pmain['scale_text'   ].text) --may be decimal
to

Code: Select all

    args.zoom = tonumber (pmain['scale_text'   ].text) --may be decimal
    args.xpos = tonumber (pmain['xpos_text'    ].text)
    args.ypos = tonumber (pmain['ypos_text'    ].text)
    args.xres = math.ceil(tointeger(pmain['xres_text'    ].text)* args.zoom)
    args.yres = math.ceil(tointeger(pmain['yres_text'    ].text)* args.zoom)
?

After this mod will capture exactly what is highlighted by a rectangle with any zoom, not a rectangle zoom-times larger than the selected rectangle. This is ten times more intuitive behavior, it seems to me.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [HELPER 0.16.49] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by eradicator »

Thanks for the detailed bugreport! That's probably been sitting there since version 1 and nobody ever reported it. The fixed version is on the portal now, and i also updated the opening post ;). (Btw, the engine is nice enough to do the math.floor() on it's own, so unless you have an argument for using math.ceil() instead?...)
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

melie
Manual Inserter
Manual Inserter
Posts: 3
Joined: Sat Aug 03, 2019 1:08 am
Contact:

Re: [HELPER 0.16/0.17] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by melie »

I chose ceil, because it’s better to take one extra pixel and guaranteed to capture the selected rectangle than not to get one pixel. However, there is no difference, this is just one pixel.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [HELPER 0.16/0.17] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by eradicator »

melie wrote:
Sat Aug 03, 2019 1:17 pm
I chose ceil, because it’s better to take one extra pixel and guaranteed to capture the selected rectangle than not to get one pixel. However, there is no difference, this is just one pixel.
I see. The default numbers in the gui are already enlarged to fit all tiles within the rectangle though, so anyone who's not manually inputting the resolution is already getting quite a few more pixels than they selected.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

melie
Manual Inserter
Manual Inserter
Posts: 3
Joined: Sat Aug 03, 2019 1:08 am
Contact:

Re: [HELPER 0.16/0.17] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by melie »

It's still work with 1.1
Sorry for my English again.

Need change "clean" to "clear" (control.lua:259 and data.lua:23)
And change strings 122..126 (add "tostring") in control.lua to

Code: Select all

  pmain['xres_text'    ].text = tostring(camera_settings.w)
  pmain['yres_text'    ].text = tostring(camera_settings.h)
  pmain['xpos_text'    ].text = tostring(camera_settings.x or math.floor(player.position.x))
  pmain['ypos_text'    ].text = tostring(camera_settings.y or math.floor(player.position.y))
  pmain['scale_text'   ].text = tostring(camera_settings.zoom)

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [HELPER 0.16/0.17] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by eradicator »

melie wrote:
Wed Dec 02, 2020 7:41 pm
It's still work with 1.1
Hi again! :D

Thanks for being faithful to such an old mod! I've meant to update it for a long time - to use more of the new api features implemented in the last years and apply a bit of polishing to the gui. Never got enough motivation but knowing there's still someone out there using it i've now finally started working on it. I should be able to push a release in the next 1-2 weeks if all goes well.

(PS: Also your English is really fine. Most people here aren't native speakers.)
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [HELPER 0.16/0.17] Screenshot Hotkey 2.0 (EN,DE,JP)

Post by eradicator »

The next version is coming along steadily.
screenshot_001h_20m_41s.png
screenshot_001h_20m_41s.png (922.19 KiB) Viewed 3571 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5206
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [HELPER 0.16-1.1] Screenshot Maker Deluxe 3.0 (EN,DE,JP)

Post by eradicator »

Eradicator's Screenshot Maker Deluxe 3.0 has been released on the portal.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Post Reply

Return to “Mods”