[Dominik][0.17.59] Fluid mixing bypass using underground pipe on other input

[boskid]

fluid-mixing-bypass-with-underground-pipe.gif (2.53 MiB) Viewed 3823 times

73793-fluid-mixing-bypass-with-pipe-on-oil-refinery.gif (1.12 MiB) Viewed 3813 times

Severity:

1. Same as 73600
2. Makes game state to be not save-load stable (and so will desync on connect)
3. Fails consistency after recipe finishes once

log

Code: Select all

0.001 2019-07-29 19:56:45; Factorio 0.17.59 (build 46446, win64, steam)

Code: Select all

c:\cygwin64\tmp\factorio-build-pldjx5\src\fluid\fluidbox.cpp (599): FluidBox::checkConsistency
c:\cygwin64\tmp\factorio-build-pldjx5\src\map\map.cpp (2026): Map::checkConsistency
c:\cygwin64\tmp\factorio-build-pldjx5\src\script\luagamescript.cpp (6074): LuaGameScript::postUpdate
c:\cygwin64\tmp\factorio-build-pldjx5\src\scenario\scenario.cpp (1118): Scenario::postUpdate
c:\cygwin64\tmp\factorio-build-pldjx5\src\mainloop.cpp (1192): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-build-pldjx5\src\mainloop.cpp (1060): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-build-pldjx5\src\util\workerthread.cpp (42): WorkerThread::loop

Code: Select all

1166.254 Error FluidBox.cpp:599: this->fluid.getID() == this->getSystemFluidID() was not true

replay

73793-fluid-mixing-bypass-with-underground-pipe.zip

(159.04 KiB) Downloaded 145 times

[boskid]

Same issue when recipe has two same outputs: only one is checked if both are connected to different fluid systems

73793-fluid-mixing-bypass-with-pipe-on-other-output.gif (831.21 KiB) Viewed 3801 times

-- edit:
confirmed desync when connecting and changing recipe

desync

desync-report-2019-07-29_21-20-20.zip

(33.76 MiB) Downloaded 211 times

[Dominik]

Jeez man this is ridiculous. How can this be possible??

[Dominik]

Kinda looks like an error in some more basic algorithm. Should be interesting.

[boskid]

Dunno why, i was just doing more tests for previous bug report with pump, so i built this contraption (to get setup where any rotation will keep input fluid boxes connected to same fluid systems):

73793-initial-concept.png (900.39 KiB) Viewed 3713 times

And when i accidently set lubricant recipe (instead of solid fuel) and it succedded i just kept digging for underlying issue.

Btw in upper right is my test where two underground pipes connected internally because of game.merge_forces, should i create next bug report?

[Dominik]

Kill meee....
I mean
Yes, make a report, please.

[Dominik]

Now I don't know how this even worked until now...