[0.17.39] Mods with icon beside their name not sorted correctly

This subforum contains all the issues which we already resolved.
Pi-C
Fast Inserter
Fast Inserter
Posts: 190
Joined: Sun Oct 14, 2018 8:13 am
Contact:

[0.17.39] Mods with icon beside their name not sorted correctly

Post by Pi-C » Thu May 16, 2019 2:24 pm

As suggested by Dominik, I'll post this as a bug report:

Mods that have an icon next to their name are listed after the alphabetically sorted mods in mod settings menus and in the mods manager:
modsettings.png
View of incorrectly sorted mod under mod settings
modsettings.png (110.05 KiB) Viewed 785 times
modmanager.png
View of incorrectly sorted mod in mods manager
modmanager.png (110.15 KiB) Viewed 785 times
Among the mods I'd installed, only Rocket-Silo Construction had icons as part of the name. So I figured I'd try to install all other mods released by its author. This is what the new list in the mods manager looks like:
modmanager2.png
View of many incorrectly sorted mods in mods manager
modmanager2.png (123.79 KiB) Viewed 785 times
Having Big-Monsters and Explosive Biters below the others seems awkward but can be explained by the icon before the name. When there's only an icon after the name, however, it looks wrong. Anyway, seems like these mods can't be sorted correctly because the names contain rich text.
A good mod deserves a good changelog. Here's a tutorial (WIP) about Factorio's way too strict changelog syntax!

Rseding91
Factorio Staff
Factorio Staff
Posts: 9179
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by Rseding91 » Thu May 16, 2019 6:25 pm

Thanks for the report however as the primary person who manages mods and works on the features put in for mods I'm going to say: play stupid games win stupid prizes.

I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
If you want to get ahold of me I'm almost always on Discord.

User avatar
MasterBuilder
Filter Inserter
Filter Inserter
Posts: 292
Joined: Sun Nov 23, 2014 1:22 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by MasterBuilder » Thu May 16, 2019 6:33 pm

Rseding91 wrote:
Thu May 16, 2019 6:25 pm
I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
What about some middle-ground:
Strip the rich text / images / colors / etc out of the text and sort with that? Stripping out [] with regex shouldn't be too hard.

This would do a 'good enough' sort, esp. given that most images happen to be at the end of the name.


Alternatively, you could add another field to info.json for authors to put the clean name to be used for sorting. If omitted, it would just fall back to the current sort.
Give a man fire and he'll be warm for a day. Set a man on fire and he'll be warm for the rest of his life.

Rseding91
Factorio Staff
Factorio Staff
Posts: 9179
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by Rseding91 » Thu May 16, 2019 7:22 pm

That's what I meant by 100s of lines of code to handle it.
If you want to get ahold of me I'm almost always on Discord.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3033
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by eradicator » Thu May 16, 2019 7:39 pm

Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Or I can disable it for mod names to be sure people don't do it.
Better kill it now before the plague spreads. Before it kicks us back into the 90's.
top-10-worst-90s-website-designs-2.png
top-10-worst-90s-website-designs-2.png (160.93 KiB) Viewed 748 times
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
steinio
Smart Inserter
Smart Inserter
Posts: 2173
Joined: Sat Mar 12, 2016 4:19 pm
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by steinio » Thu May 16, 2019 9:21 pm

Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Thanks for the report however as the primary person who manages mods and works on the features put in for mods I'm going to say: play stupid games win stupid prizes.

I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
I vote for disabling it for mod names.
It looks already awful and it got just started.
Imagine whole mod names consisting only of this icons...
Image
Transport Belt Repair Man
My little mods: Link | My favourite mods: Bob's Mods | Angel's Mods | Yuoki Railway Core | EvoGUI | Logistic Train Network
Factorio Cheat Sheet by Denis Zholob

View unread Posts

User avatar
fishycat
Fast Inserter
Fast Inserter
Posts: 201
Joined: Thu Apr 09, 2015 7:38 pm
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by fishycat » Thu May 16, 2019 9:37 pm

steinio wrote:
Thu May 16, 2019 9:21 pm
Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Thanks for the report however as the primary person who manages mods and works on the features put in for mods I'm going to say: play stupid games win stupid prizes.

I'm not going to implement some multiple hundreds of lines of code to handle sorting things like this. If mods put rich text bull shit in their mod names then they can deal with the fallout. Or I can disable it for mod names to be sure people don't do it.
I vote for disabling it for mod names.
It looks already awful and it got just started.
Imagine whole mod names consisting only of this icons...
+1

orzelek
Smart Inserter
Smart Inserter
Posts: 3563
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by orzelek » Thu May 16, 2019 9:40 pm

I was surprised after noticing that mod list is going rainbow/picture style.
Another vote to remove rich text from mod names.

Pi-C
Fast Inserter
Fast Inserter
Posts: 190
Joined: Sun Oct 14, 2018 8:13 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by Pi-C » Fri May 17, 2019 5:30 am

eradicator wrote:
Thu May 16, 2019 7:39 pm
Better kill it now before the plague spreads. Before it kicks us back into the 90's.
That picture must be fake: In the 90s, websites used <marquee>, <blink>, and flashing backgrounds! :-D

About rich text in mod names: I think it's all about the right measure. Used sparingly, it could be used to some effect -- but there is a real danger that such a feature will be abused, and overused. Actually, rich text in mod names would only make sense (because that is the only places where it would be seen) in the mod manager/mod settings menus, right? But there, it breaks stuff, namely sorting. So I'm not sure how to argue for keeping it enabled …
A good mod deserves a good changelog. Here's a tutorial (WIP) about Factorio's way too strict changelog syntax!


User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 3618
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by Klonan » Fri May 17, 2019 11:20 am

Rseding91 wrote:
Thu May 16, 2019 6:25 pm
Or I can disable it for mod names to be sure people don't do it.
+1

User avatar
mexmer
Filter Inserter
Filter Inserter
Posts: 823
Joined: Wed Aug 03, 2016 2:00 pm
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by mexmer » Fri May 17, 2019 12:01 pm

+2 for disabling RT

User avatar
ZwerOxotnik
Inserter
Inserter
Posts: 41
Joined: Tue Dec 19, 2017 6:58 pm
Contact:

Re: Mods with icon beside their name not sorted correctly

Post by ZwerOxotnik » Wed May 22, 2019 2:15 pm

examples of mod names
Consequences

I want use rich text for localization.
If some mod developer did the mistake we can just to write to him if we really want it:
  • ~"Hey, your rich text breaks mods sorting in the mod list. Please, change your rich text or to make it better."
  • or simpler to send to him a link on this topic
  • or (for example) to create a special link/information for mod developers, players about rich text in the mod list or somewhere else
And also

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3033
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by eradicator » Wed May 22, 2019 4:53 pm

Have you tried translating your mod name with a locale.cfg?

Code: Select all

[mod-name]
your-mod-name=translated-mod-name

[mod-description]
your-mod-name=translated-mod-description
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
ZwerOxotnik
Inserter
Inserter
Posts: 41
Joined: Tue Dec 19, 2017 6:58 pm
Contact:

Re: Mods with icon beside their name not sorted correctly

Post by ZwerOxotnik » Wed May 22, 2019 5:10 pm

I will show you fixing
Before
After
Screenshots: https://imgur.com/a/mrg4sZO

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3033
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by eradicator » Wed May 22, 2019 5:16 pm

If you want the font contrast fixed you should submit a bug report instead of abusing rich text. That way it's fixed for everybody.
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
ZwerOxotnik
Inserter
Inserter
Posts: 41
Joined: Tue Dec 19, 2017 6:58 pm
Contact:

Re: Mods with icon beside their name not sorted correctly

Post by ZwerOxotnik » Wed May 22, 2019 5:18 pm

Do we need to remove the feature a result of a mod developer mistake?
Last edited by ZwerOxotnik on Wed May 22, 2019 5:36 pm, edited 1 time in total.

User avatar
Deadlock989
Filter Inserter
Filter Inserter
Posts: 914
Joined: Fri Nov 06, 2015 7:41 pm
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by Deadlock989 » Wed May 22, 2019 5:19 pm

ZwerOxotnik wrote:
Wed May 22, 2019 5:18 pm
Do we need to remove the feature a result of a mod developer mistake?
Apparently.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3033
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.39] Mods with icon beside their name not sorted correctly

Post by eradicator » Wed May 22, 2019 5:26 pm

ZwerOxotnik wrote:
Wed May 22, 2019 5:18 pm
Do we need to remove the feature a result of a mod developer mistake?
I assume it was removed to preserve consistently readable menus for everyone.
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
ZwerOxotnik
Inserter
Inserter
Posts: 41
Joined: Tue Dec 19, 2017 6:58 pm
Contact:

Re: Mods with icon beside their name not sorted correctly

Post by ZwerOxotnik » Wed May 22, 2019 5:34 pm

eradicator wrote:
Wed May 22, 2019 5:26 pm
I assume it was removed to preserve consistently readable menus for everyone.
Players write bug reports to me when I made a mistake in my mod, but no one did in this case.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users