[Dominik][0.16.28] Loss of inventory slot filters

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3178
Joined: Tue Jul 12, 2016 9:03 am
Contact:

[Dominik][0.16.28] Loss of inventory slot filters

Post by eradicator » Sat Mar 10, 2018 9:11 am

Now of course it's awesome that we can filter inventory slots now (thank's for that again), but those slots have some "persistency issues":

a) If the inventory size is reduced, then all filters from the removed section of the inventory are lost, even if the size is increased again afterwards. This happens for example when you have the bottom row of your inventory filtered and then (accidentally) take off your armor for a second.

b) On death all slot filters are lost.

I realize that preserving the filters on an inventory that no longer exists would probably be annoying to implement. But so is re-setting filters when they're lost :D. So it would be nice if this could somehow be fixed.

Rseding91
Factorio Staff
Factorio Staff
Posts: 9471
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.16.28] Loss of inventory slot filters

Post by Rseding91 » Sat Mar 10, 2018 4:19 pm

I fixed the filters not persisting through death. The other things I don't know on and will leave for one of the other devs to answer.
If you want to get ahold of me I'm almost always on Discord.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3178
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.16.28] Loss of inventory slot filters

Post by eradicator » Sat Mar 10, 2018 4:37 pm

Thanks =). Armor is lost on death too though, so that kinda coincides. Hope someone will have the time.

Dominik
Factorio Staff
Factorio Staff
Posts: 538
Joined: Sat Oct 12, 2013 9:08 am
Contact:

Re: [0.16.28] Loss of inventory slot filters

Post by Dominik » Mon Mar 12, 2018 12:15 pm

Ok let me look into the other part.

mrvn
Smart Inserter
Smart Inserter
Posts: 3411
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by mrvn » Mon Mar 12, 2018 12:57 pm

Would it make sense to link the filters to the armor? I could have 2 sets of armors with different filters. E.g. a weaker builder armor with lots of extra inventory slots and filters for tons of belts, inserters, ... And a stong fighter armor with few inventory slots filtered for weapons and ammo.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3178
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by eradicator » Mon Mar 12, 2018 1:15 pm

The value of LuaControl.character_inventory_slots_bonus is also lost on death by the way, causing the same effect. (Tested via console)

Dominik
Factorio Staff
Factorio Staff
Posts: 538
Joined: Sat Oct 12, 2013 9:08 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by Dominik » Mon Mar 12, 2018 2:01 pm

mrvn wrote:Would it make sense to link the filters to the armor? I could have 2 sets of armors with different filters. E.g. a weaker builder armor with lots of extra inventory slots and filters for tons of belts, inserters, ... And a stong fighter armor with few inventory slots filtered for weapons and ammo.
I understand the use case you are talking about, but I don't see how would the filters help anything practically.
Technically it is not very simple because the armor does not have the inventory - it only alters the player inventory size.

Rseding91
Factorio Staff
Factorio Staff
Posts: 9471
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by Rseding91 » Mon Mar 12, 2018 2:18 pm

eradicator wrote:The value of LuaControl.character_inventory_slots_bonus is also lost on death by the way, causing the same effect. (Tested via console)
That's intended. All of the character-specific bonuses are erased on death. It's up to mods to restore them should they want to.
If you want to get ahold of me I'm almost always on Discord.

Dominik
Factorio Staff
Factorio Staff
Posts: 538
Joined: Sat Oct 12, 2013 9:08 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by Dominik » Mon Mar 12, 2018 2:51 pm

a) issue now solved.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3178
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by eradicator » Mon Mar 12, 2018 3:38 pm

Rseding91 wrote:
eradicator wrote:The value of LuaControl.character_inventory_slots_bonus is also lost on death by the way, causing the same effect. (Tested via console)
That's intended. All of the character-specific bonuses are erased on death. It's up to mods to restore them should they want to.
What i meant is: Even if a mod reinstated the slots_bonus in an on_player_respawned event, the filters would probably already be lost.
Dominik wrote:a) issue now solved.
Yay! Does that include the situation above? I'm guessing the filters are now stored per character?

someone1337
Long Handed Inserter
Long Handed Inserter
Posts: 84
Joined: Wed Apr 26, 2017 11:29 pm
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by someone1337 » Mon Mar 12, 2018 7:27 pm

Consider to make the player blueprintable or a way to export settings, including autotrash, requests and filters.

At least my filters are pretty the same on all games I play, so a way to easily copy the settings across savegames would be cool and would practically solve this problem.

ethernal
Inserter
Inserter
Posts: 26
Joined: Fri Jan 05, 2018 7:07 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by ethernal » Mon Mar 12, 2018 9:57 pm

someone1337 wrote:Consider to make the player blueprintable or a way to export settings, including autotrash, requests and filters.

At least my filters are pretty the same on all games I play, so a way to easily copy the settings across savegames would be cool and would practically solve this problem.
This would allow to create "profiles" so we could save our filter settings as ex. builder, exterminator etc. and restore them via gui. ex. when I want to gather ore, plates etc and when I want to have all of that in autotrash. Would be seriously awesome.

Dominik
Factorio Staff
Factorio Staff
Posts: 538
Joined: Sat Oct 12, 2013 9:08 am
Contact:

Re: [Dominik][0.16.28] Loss of inventory slot filters

Post by Dominik » Wed Mar 14, 2018 12:36 pm

Feel free to add it to the suggestions forum topic. But honestly, even though I understand you, I think that only a handful of players are so advanced and deep that they would appreciate it and we still have a lot of work that can improve lives of nearly everyone.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users