[15.9+] Hang/KILL when maximising window

[Paul17041993]

... with the achievements display open. Basically all you need to do is load a world > open achievements list > shrink the game window (if it isn't already) and then maximise the window and boom! game locks up and eventually gets collected/terminated by windows (ie; "application has stopped responding"/"encountered a problem...")

Havn't tested linux yet but I would assume the condition is the same.
Result is exactly the same between platforms, linux collects the broken process almost immediately however.

[Loewchen]

Post the log please, see my signature.

[Paul17041993]

There's nothing logged at the time of hanging, due to it being a hang and not a crash.
Is the logging system on a separate thread alongside a watchdog? because you need these to debug hang conditions, without triggering the event yourself with the debugger attached (of which the log and watch threads are in the debugger instead).

[Paul17041993]

Double-post for linux update, bug still exists in 15.10, it also seems to be possible for a crash/KILL to not occur if the window was already close to the maximised size when performing the maximise...

Again, nothing useful logged to file and any crash files, dumps or kernel logs are non-existant, seems to be a case of an ASSERT? (if you are using asserts in your code, you need to stop and remove all of them as they're just bad to use, period...)

[Rseding91]

Double-post for linux update, bug still exists in 15.10, it also seems to be possible for a crash/KILL to not occur if the window was already close to the maximised size when performing the maximise...

Again, nothing useful logged to file and any crash files, dumps or kernel logs are non-existant, seems to be a case of an ASSERT? (if you are using asserts in your code, you need to stop and remove all of them as they're just bad to use, period...)

That's not how asserts work. If we left asserts enabled in the release build and one failed it would halt at that line of code and terminate the program - not hang it. As for the freeze I'll look into it.

It has something to do with the steam integration because it doesn't happen in the non-steam version. Nevermind - I can make it happen regardless of steam.

[Rseding91]

Thanks for the report. It's now fixed for the next version of 0.15.

[Paul17041993]

That's not how asserts work. If we left asserts enabled in the release build and one failed it would halt at that line of code and terminate the program - not hang it.

It varies with implementation actually, it can either be a one-line 'exit(1);' call (I think this is the default for C) or it can make a call to the OS signalling an assert (which is the default for windows last I checked, and likely why there's a debug option).

Just don't use asserts, they're lazy, unhelpful and you don't ever need them. Use a crash handler, which can be as simple as a few lines of code that prints a link to the source line, stack and dumps it to a file. C++ has exception handling that can be used and you could make a full-fledged crash logger like minecraft's if you wanted.