[0.15.3] crash when sprite rect doesn't match icon size.

[credomane]

The color-coding mod seems to have a "bad" icon size, I've reported this to the mod author to get it resolved.

The reason I'm reporting this here is the "bad" icon size crashes factorio. I think instead of crashing the disable mod dialog should appear and ask you to disable color-coding (or whatever mod actually caused the error) to appear.

Code: Select all

   0.001 2017-04-29 08:44:41; Factorio 0.15.3 (build 29201, win64, steam)
   0.001 Operating system: Windows 8.1 
   0.001 Program arguments: "C:\Steam\steamapps\common\Factorio\bin\x64\Factorio.exe" 
   0.001 Read data path: C:/Steam/steamapps/common/Factorio/data
   0.001 Write data path: C:/Users/bb002/AppData/Roaming/Factorio
   0.001 Binaries path: C:/Steam/steamapps/common/Factorio/bin
   0.008 System info: [CPU: Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz, 8 cores, RAM: 8104MB]
   0.009 Display options: [FullScreen: 0] [VSync: 1] [UIScale: 80%] [MultiSampling: OFF] [Screen: 255]
   0.009 Available display adapters: 1
   0.009  [0]: \\.\DISPLAY1 - Intel(R) HD Graphics 4600 {0x05, [0,0], 1366x768, 32bit, 60Hz}
   0.010 Create display on adapter 0. Size 1280x720 at position [33, 6].
   0.030 Initialised Direct3D:[0] Intel(R) HD Graphics 4600; driver: igdumdim64.dll 10.18.14.4264
   0.031     Video memory size (dedicated video/dedicated system/shared system/available): 128/0/1792/1916 MB
   0.052 DSound: Starting _dsound_update thread
   0.052 DSound: Enter _dsound_update; tid=6252
   0.053 Device reset internal.
   0.056 Desktop composition is active.
   0.056 You have vsync and desktop composition enabled on Direct3d. Consider disabling vsync to increase performance on some confirgurations.
   0.056 Graphics settings preset: medium
   0.057 Graphics options: [Graphics quality: low] [Video memory usage: low] [Light scale: 100%] [DXT: auto]
   0.211 Loading mod settings Factorissimo2 2.1.1 (settings.lua)
   0.212 Loading mod settings reverse-factory 4.0.3 (settings.lua)
   0.217 Loading mod core 0.0.0 (data.lua)
   0.227 Loading mod base 0.15.3 (data.lua)
   0.348 Loading mod rso-mod 3.0.1 (data.lua)
   0.417 Loading mod TheFatController 2.0.1 (data.lua)
   0.486 Loading mod angelsinfiniteores 0.6.1 (data.lua)
   0.565 Loading mod auto-research 3.1.0 (data.lua)
   0.637 Loading mod autofill 1.4.7 (data.lua)
   0.720 Loading mod Big_Brother 0.4.2 (data.lua)
   0.805 Loading mod bobinserters 0.15.0 (data.lua)
   0.885 Loading mod Bottleneck 0.6.3 (data.lua)
   0.979 Loading mod color-coding 1.15.1 (data.lua)
   1.055 Loading mod Factorissimo2 2.1.1 (data.lua)
   1.218 Loading mod More signal color 1.15.0 (data.lua)
   1.423 Loading mod More_Floors 1.2.2 (data.lua)
   1.613 Loading mod nixie-tubes 0.15.13 (data.lua)
   1.812 Loading mod Nuclear Locomotives 1.0.2 (data.lua)
   2.052 Loading mod pushbutton 0.15.6 (data.lua)
   2.235 Loading mod research-queue 1.5.1 (data.lua)
   2.438 Loading mod reverse-factory 4.0.3 (data.lua)
   2.684 Loading mod robotarmy 0.3.0 (data.lua)
   2.876 Loading mod textplates 0.2.1 (data.lua)
   3.099 Loading mod water-fix 0.2.1 (data.lua)
   3.416 Loading mod GDIW 0.15.2 (data.lua)
   3.642 Loading mod base 0.15.3 (data-updates.lua)
   3.907 Loading mod rso-mod 3.0.1 (data-updates.lua)
   4.220 Loading mod Big_Brother 0.4.2 (data-updates.lua)
   4.446 Loading mod bobinserters 0.15.0 (data-updates.lua)
   4.675 Loading mod robotarmy 0.3.0 (data-updates.lua)
   4.922 Loading mod Squeak Through 1.1.7 (data-updates.lua)
   5.148 Loading mod angelsinfiniteores 0.6.1 (data-final-fixes.lua)
   5.382 Loading mod auto-research 3.1.0 (data-final-fixes.lua)
   5.623 Loading mod PeppeBotStart 0.15.0 (data-final-fixes.lua)
   5.963 Loading mod research-queue 1.5.1 (data-final-fixes.lua)
   6.200 Loading mod reverse-factory 4.0.3 (data-final-fixes.lua)
   6.464 Loading mod GDIW 0.15.2 (data-final-fixes.lua)
   6.787 Checksum for core: 2926038370
   6.788 Checksum of base: 2896593033
   6.788 Checksum of rso-mod: 1351416498
   6.788 Checksum of TheFatController: 3811666260
   6.788 Checksum of angelsinfiniteores: 2324242983
   6.788 Checksum of auto-research: 1568893371
   6.788 Checksum of AutoDeconstruct: 0
   6.788 Checksum of autofill: 3086359458
   6.788 Checksum of Big_Brother: 1188679049
   6.788 Checksum of bobinserters: 2966285250
   6.788 Checksum of Bottleneck: 110869948
   6.788 Checksum of color-coding: 257728962
   6.788 Checksum of Factorissimo2: 1794429973
   6.788 Checksum of More signal color: 1804919520
   6.788 Checksum of More_Floors: 3182885990
   6.788 Checksum of nixie-tubes: 1164799181
   6.788 Checksum of Nuclear Locomotives: 1674757153
   6.788 Checksum of PeppeBotStart: 961234746
   6.788 Checksum of pushbutton: 2389042828
   6.788 Checksum of research-queue: 615097349
   6.788 Checksum of reverse-factory: 1093216125
   6.788 Checksum of robotarmy: 521617393
   6.788 Checksum of Squeak Through: 3430405470
   6.788 Checksum of textplates: 1623549897
   6.788 Checksum of water-fix: 2613022438
   6.788 Checksum of GDIW: 2359646124
   7.136 Info PlayerData.cpp:55: Local player-data.json available, timestamp 1493473476
   7.136 Info PlayerData.cpp:62: Cloud player-data.json unavailable
   7.283 Loaded shader file C:/Steam/steamapps/common/Factorio/data/core/graphics/shaders/game.cso
   7.284 Loaded shader file C:/Steam/steamapps/common/Factorio/data/core/graphics/shaders/zoom-to-world.cso
   7.308 Initial atlas bitmap size is 8192
   7.309 Created atlas bitmap 7785x96
   7.330 Created atlas bitmap 4096x4096
   7.334 Created atlas bitmap 4096x908
   7.334 Created atlas bitmap 4096x2124
   7.334 Created atlas bitmap 4096x1052
  26.149 Error AtlasSystem.cpp:939: Loading sprites failed: The given sprite rectangle (left_top=0x0, right_bottom=64x64) is outside the actual sprite size (left_top=0x0, right_bottom=32x32).
Sprite name: __color-coding__/graphics/concrete/cyan/icon.png.
If this is being used as an icon you may need to define the icon_size property.
  26.149 Error Util.cpp:58: The given sprite rectangle (left_top=0x0, right_bottom=64x64) is outside the actual sprite size (left_top=0x0, right_bottom=32x32).
Sprite name: __color-coding__/graphics/concrete/cyan/icon.png.
If this is being used as an icon you may need to define the icon_size property.
  46.237 Error CrashHandler.cpp:232: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-orhqod\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-orhqod\src\util\logger.cpp (354): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-orhqod\src\util\logger.cpp (408): Logger::logStacktrace
c:\cygwin64\tmp\factorio-orhqod\src\util\crashhandler.cpp (105): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-orhqod\src\util\crashhandler.cpp (235): CrashHandler::SignalHandler
d:\th\minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp (219): _seh_filter_exe
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (269): `__scrt_common_main_seh'::`1'::filt$0
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF6FC027E48)
00007FF6FC027E48 (Factorio): (filename not available): __C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDCB2D33FD)
00007FFDCB2D33FD (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDCB294847)
00007FFDCB294847 (ntdll): (filename not available): RtlRaiseException
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDCB2D258A)
00007FFDCB2D258A (ntdll): (filename not available): KiUserExceptionDispatcher
c:\cygwin64\tmp\factorio-orhqod\src\globalcontext.cpp (788): GlobalContext::onResize
c:\cygwin64\tmp\factorio-orhqod\src\graphics\loadingsplashscreen.cpp (36): LoadingSplashScreen::~LoadingSplashScreen
c:\cygwin64\tmp\factorio-orhqod\src\globalcontext.cpp (601): GlobalContext::clearResources
c:\cygwin64\tmp\factorio-orhqod\src\globalcontext.cpp (662): GlobalContext::~GlobalContext
c:\cygwin64\tmp\factorio-orhqod\src\mainloop.cpp (290): MainLoop::run
c:\cygwin64\tmp\factorio-orhqod\src\main.cpp (881): wmain
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (253): __scrt_common_main_seh
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDCABA13D2)
00007FFDCABA13D2 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDCB2554E4)
00007FFDCB2554E4 (ntdll): (filename not available): RtlUserThreadStart
  48.269 Error Util.cpp:76: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

[credomane]

OK. Some how crop-cache.dat is partially corrupted? I deleted that because nearly every mod started throwing that error after I made this report.

I've attached my bad crop-cache.dat so perhaps help you locate the issue. had to add the txt ext because dat isn't allowed.

[Sworn]

I got an weird scenario where I have deleted one mod, and during the restart I got this error:

The given sprite rectangle (left_top=0x0, right_bottom=64x64) is outside the actual sprite size (left_top=0x0, right_bottom=32x32).
Sprite name: __nixie-tubes__/graphics/nixie-base-icon.png.
If this is being used as an icon you may need to define the icon_size property.

But the thing is, was fine before, and every mod that I deleted, throws an error for the next mod. After deleting the crop-chach.data.txt
everything back to works.

Unfortunately I didn't backup the old file
But looks like something is messy on the cach.data

[Sworn]

Yehh happens again.
I have add the "hyperkiller-addons_0.15.1" and back to the sprite error on random mod name.

after deleting the file the game works fine.

Here is the copy of the file.


Quick background: I was playing the campaign again, then I realize that one of the mods make impossible to finish the campaign. So I remove that mod. During the restart, i got the Sprite error in another mod. I remove that, then i got the error on another mod. And keep looping. Deleting the crop file seems to resolve.

After while, I have add the hyperkiller addons, and again the sprite error back.

[credomane]

Yeah it seems like that it was triggers it for me as well. Starting with 0.15.3 (never had the error before then but perhaps by luck?) it seems like any time a mod is updated/deleted the game starts crashing with this error until crop-cache.dat is deleted.

Still getting this error in 0.15.4 as well.

[Kremnari]

I have begun encountering this as well in 0.15.4

Troubleshooting info:
After encounter, I deleted crop-cache.dat.
The next game load occurred without issue.
Started new world, then exited game completely.
Next game load (no mod changes) encountered same error.

Conclusion: Something is corrupting even newly generated cache-files

Second troubleshooting - use normal definition sprites:
Load game, set sprites, exit, delete cache
Load new world, exit
Load game again
Error still occurred.

Conclusion: Sprite resolution setting does not prevent error

Third troubleshooting - narrow down mod causing conflict:
process should be known enough

I have tracked down the mod causing the error in my case: It was Research Queue 1.5.1.
Troubleshooting included removing mods down to RQ, then adding mods with RQ until conflict resumed.

RQ 1.5.0/1 seems to not want to play nice with the following mods (from my install):
Color Coding 1.15.1
Devterevs Warefare 0.2.41
Inventory Sensor 1.4.1
Single-Splitter Z 0.0.11
Waterfill 0.1.1

Cross posted to RQ's mod discussion.

[credomane]

Still present in 0.15.5. Definitely caused by Research Queue. Now to figure out how and why...

[Helex288]

Not sure why this error occurred but i have the same error as well.
It is not only the research queue mods, i also have it with Yuoki's mod, waterfill mod.

I did find a way to create a workaround, but it is a temporary fix.
In the waterfill mod the icon for waterfill (that is used in the game), if you change the image size from 64x64 to 32x32 is temporary fixes the issue, but i have to change it now again to 16x16 in order to fix it.

But since it is with more mods, i assume it is not entirely mods related.

I also use the latest version of Factorio, but also had it in the previous 0.15 versions. no problem in the 0.14+ versions.

[credomane]

Seems like Research queue creates a ton of styles in the data construction phase.

In one place it names the size of a button style as 32x32 then says the images is 64x64 which matches with the error we are seeing.

I'm wondering if somewhere along the updates for 0.15 there were some consistency error checking updates to the sprite handling leading to this error in 0.15.
Curious if there are other mods triggering this error and if they do the same thing.

I also found a duplicate of this bug at 45700. I'm cross linking both so the info gets linked together no matter which gets moved to duplicates. Probably this one since devs replied to the other one already..and I'm going to make the request to move this one to dups.

So move focus to the "duplicate".

[Loewchen]

Ok, I declare this one the duplicate of 45700, if you can provide information not in that topic please share it over there.

[posila]

Ok, I declare this one the duplicate of 45700, if you can provide information not in that topic please share it over there.

Thx, it really is same bug

[credomane]

Ok, I declare this one the duplicate of 45700, if you can provide information not in that topic please share it over there.

Thanks Loewchen!