[posila] [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
Therax
Filter Inserter
Filter Inserter
Posts: 462
Joined: Sun May 21, 2017 6:28 pm
Contact:

[posila] [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

Post by Therax »

Happened when dragging an upgrade planner over some belts that were already marked for upgrade.
Attachments
factorio-current.log
(28.1 KiB) Downloaded 87 times
Miniloader — UPS-friendly 1x1 loaders
Bulk Rail Loaders — Rapid train loading and unloading
Beltlayer & Pipelayer — Route items and fluids freely underground

User avatar
Therax
Filter Inserter
Filter Inserter
Posts: 462
Joined: Sun May 21, 2017 6:28 pm
Contact:

Re: [1.1.30] Crash in EntityWithHealth::draw

Post by Therax »

The entity was a yellow transport belt.
It was marked for upgrade to a red transport belt.
The upgrade planner had an entry for red->blue, but no entry for yellow->*.
Dragging an upgrade planner with a yellow->blue configuration worked as expected on these belts.
Miniloader — UPS-friendly 1x1 loaders
Bulk Rail Loaders — Rapid train loading and unloading
Beltlayer & Pipelayer — Route items and fluids freely underground

ViridisWolf
Manual Inserter
Manual Inserter
Posts: 1
Joined: Wed Apr 07, 2021 6:32 am
Contact:

Re: [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

Post by ViridisWolf »

I encountered what looks like the same crash.
- Was connected to a dedicated server (1.1.30) with mods: Krastorio 2 and FNEI.
- Had upgrade planner which included blue inserter to green inserter upgrade.
- Did generic upgrade of a yellow inserter to blue inserter.
- While the inserter was pending upgrade to blue, used blue-to-green upgrade planner on it.
- Crash.

I reproduced this crash three times when connected to the multiplayer server. I then tried saving the game, loading it in single player, and attempting to reproduce the crash; it did not reproduce there, however.
Attachments
crash - upgrade yellow inserter to blue and then to green before blue gets placed.zip
save
(27.58 MiB) Downloaded 136 times
factorio-current.log
(78.7 KiB) Downloaded 190 times

acuifex
Manual Inserter
Manual Inserter
Posts: 1
Joined: Thu Apr 08, 2021 3:11 pm
Contact:

Re: [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

Post by acuifex »

i have pretty much same story as @ViridisWolf

happened on my friend's server:
1) go to the map view
2) deupgrade green splitters from krastorio 2 to red
3) upgrade them back
4) crash, addr2line loads 1 core

my frozen game after crash (friend stands to the right):
Image

addr2line:
Image

i won't upload my save file because i'm a bit afraid of leaking chat messages.
Attachments
factorio-current.log
(16.16 KiB) Downloaded 26 times

sp55aa
Inserter
Inserter
Posts: 39
Joined: Mon Oct 07, 2019 9:27 am
Contact:

Re: [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

Post by sp55aa »

acuifex wrote:
Thu Apr 08, 2021 3:24 pm
i have pretty much same story as @ViridisWolf

happened on my friend's server:
1) go to the map view
2) deupgrade green splitters from krastorio 2 to red
3) upgrade them back
4) crash, addr2line loads 1 core

my frozen game after crash (friend stands to the right):
Image

addr2line:
Image

i won't upload my save file because i'm a bit afraid of leaking chat messages.
chat history is not in save file, it's in your game directory
Last edited by sp55aa on Tue Apr 13, 2021 1:38 pm, edited 1 time in total.

posila
Factorio Staff
Factorio Staff
Posts: 4974
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

Post by posila »

sp55aa wrote:
Sat Apr 10, 2021 9:02 am
chat history is not in save file, it's in your game directory
Chat is also in the save file ... the history in player data json is used for repeating commands by "Arrow up"


posila
Factorio Staff
Factorio Staff
Posts: 4974
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila] [1.1.30] Crash dragging upgrade planner over belts marked for upgrade (EntityWithHealth::draw)

Post by posila »

Thanks for the report.
Fixed for next release (1.1.31?)

Upgrading an entity marked for an upgrade in latency state by a planner that doesn't have upgrade rule for original entity but does have a rule for the current upgrade target causes this crash

Post Reply

Return to “Resolved Problems and Bugs”