[1.1.21] (1/0)(mods) selection tool and operable flag sometimes crash the client.

[KeepResearchinSpoons]

repro: attempted to access the landmine operable (false) property with a gui tool... too fast?
mods: [creative mode, editor extensions]
comm: hardware fault probability exists this time but is very low.

log:

log

Code: Select all

timestamp.104 Error CrashHandler.cpp:621: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
Raw stacktrace: 0xd1b997, 0xf0de4d, 0xd71e45, 0xd724d1, 0xd72589, 0x46210, 0x76f771, 0x7f9027, 0xc80427, 0x10d10bf, 0x10d1339, 0x8ec4c4, 0xefd8a3, 0x98b59c, 0xf28ca3, 0x1309cab, 0x1309fe1, 0xd32991, 0x1ffde40, 0x9609, 0
2308.918 Warning Logger.cpp:526: Symbols.size() == 31, usedSize == 20
#0  0x0000000000f0de4d in std::__uniq_ptr_impl<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::_M_ptr() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:154
#1  0x0000000000d71e45 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::get() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:353
#2  0x0000000000d724d1 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::operator->() const at /home/build/gcc-9.2/include/c++/9.2.0/bits/unique_ptr.h:347
#3  0x0000000000d72589 in Logger::flush() at /tmp/factorio-build-QgErkP/src/Util/Logger.cpp:566
#4  0x0000000000046210 in Logger::logStacktrace(StackTraceInfo*) at /tmp/factorio-build-QgErkP/src/Util/Logger.cpp:552
#5  0x000000000076f771 in GlobalContext::getMap() at /tmp/factorio-build-QgErkP/src/GlobalContext.cpp:2027
#6  0x00000000007f9027 in CrashHandler::writeStackTrace(CrashHandler::CrashReason) at /tmp/factorio-build-QgErkP/src/Util/CrashHandler.cpp:188
#7  0x0000000000c80427 in CrashHandler::commonSignalHandler(int) at /tmp/factorio-build-QgErkP/src/Util/CrashHandler.cpp:623
#8  0x00000000010d10bf in CrashHandler::SignalHandler(int) at /tmp/factorio-build-QgErkP/src/Util/CrashHandler.cpp:638
#9  0x00000000010d1339 in ?? at ??:0
#10 0x00000000008ec4c4 in SelectionToolPrototype::entityPassesFilters(SelecionToolFilters const&, Entity const*) at /tmp/factorio-build-QgErkP/src/Item/SelectionToolPrototype.cpp:546
#11 0x0000000000efd8a3 in SelectionToolPrototype::entityPassesFilters(SelecionToolFilters const&, Entity const*) at /tmp/factorio-build-QgErkP/src/Item/SelectionToolPrototype.cpp:533
#12 0x000000000098b59c in SelectionToolPrototype::canSelect(unsigned int, SelecionToolFilters const&, Entity const*, ForceID) at /tmp/factorio-build-QgErkP/src/Item/SelectionToolPrototype.cpp:451
#13 0x0000000000f28ca3 in LuaGameScript::pushPlayerSelectedData(GameAction const&, bool) at /tmp/factorio-build-QgErkP/src/Script/LuaGameScript.cpp:6894 (discriminator 7)
#14 0x0000000001309cab in LuaEventDispatcher::run(LuaEventType, unsigned int, bool (LuaGameScript::*)(GameAction const&), GameAction const&) at /tmp/factorio-build-QgErkP/src/Script/LuaEventDispatcher.cpp:653 (discriminator 4)
#15 0x0000000001309fe1 in LuaEventDispatcher::dispatch(GameAction const&, unsigned int) at /tmp/factorio-build-QgErkP/src/Script/LuaEventDispatcher.cpp:397
#16 0x0000000000d32991 in GameActionDispatcher::sendToListeners(GameAction const&) at /tmp/factorio-build-QgErkP/src/GameActionDispatcher.cpp:14
#17 0x0000000001ffde40 in GameActionHandler::altSelectArea(InputAction const&, Controller*) at /tmp/factorio-build-QgErkP/src/GameActionHandler.cpp:3488
#18 0x0000000000009609 in GameActionHandler::actionPerformed(InputAction const&) at /tmp/factorio-build-QgErkP/src/GameActionHandler.cpp:370 (discriminator 1)
#19 (nil) in InputHandler::flushToListeners(InputAction const&, bool) at /tmp/factorio-build-QgErkP/src/Input/InputHandler.cpp:72
#20 (nil) in InputHandler::flushActions(bool, unsigned int) at /tmp/factorio-build-QgErkP/src/Input/InputHandler.cpp:64
#21 (nil) in GameActionHandler::update() at /tmp/factorio-build-QgErkP/src/GameActionHandler.cpp:409
#22 0x000000000000007c in MainLoop::gameUpdateStep(MultiplayerManagerBase*, Scenario*, AppManager*, MainLoop::HeavyMode) at /tmp/factorio-build-QgErkP/src/MainLoop.cpp:1247
#23 0x3f951453eae494c9 in MainLoop::gameUpdateLoop(MainLoop::HeavyMode) at /tmp/factorio-build-QgErkP/src/MainLoop.cpp:1119
#24 0x3f93f84f8036ddcc in std::function<void ()>::operator=(decltype(nullptr)) at /home/build/gcc-9.2/include/c++/9.2.0/bits/std_function.h:498
#25 0x00000000000001c0 in WorkerThread::loop() at /tmp/factorio-build-QgErkP/src/Util/WorkerThread.cpp:49
#26 0x0000000000000003 in std::default_delete<std::thread::_State>::operator()(std::thread::_State*) const at /home/build/gcc-9.2-source/gcc-9.2.0/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/unique_ptr.h:81
#27 0x3f00000000000048 in std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >::~unique_ptr() at /home/build/gcc-9.2-source/gcc-9.2.0/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/unique_ptr.h:284
#28 0x00007ff93f9a6577 in execute_native_thread_routine at /home/build/gcc-9.2-source/gcc-9.2.0/build/x86_64-pc-linux-gnu/libstdc++-v3/src/c++11/../../../../../libstdc++-v3/src/c++11/thread.cc:79
#29 0x00007ff95ff3fc70 in ?? at ??:0
#30 (nil) in ?? at ??:0
Stack trace logging done
2317.096 Warning Logger.cpp:526: Symbols.size() == 26, usedSize == 19

The log should have been sent already.
I am not _too_ willing to dive into this case too much for now. Since it's mods and well it's indeed a minor issue for me.

[Rseding91]

Thanks for the report. Have you been able to reproduce the crash at all? Looking at where it's crashing it's a comparison line that shouldn't ever have any issue.