[0.18.19] rail duplication when building curved rail with some damaged rail items

[jan1i3]

What and How

When

• Having 1 undamaged rail
• At least 3 damaged rails
• Using the undamaged rail to build a curved rail

Then

• The undamaged rail is used to place the whole curved rail
• The damaged rails remain unused

Which means 3 undamaged rails got duplicated / created out of nothing.

Demonstration

55ldJb4l25.gif (14.13 MiB) Viewed 3478 times

This is more of a general issue, something like
"the total item count of an item is used to determin if it's possible to place, but there are not enough items in all identical item stacks"

Reproduce

Code: Select all

/c
game.player.insert{name = "rail", count = 2}
game.player.insert{name = "rail", count = 3, health = 0.9}

Then put the undamaged ones in the cursor and start building
(1 additional to place the starting rail)

Expected

It should not be possible to place the entity in this case.
Whenever there is any kind of mismatch in identity between stacks, there is no way to know how to merge them.
Especially when the item is an item-with-tags.

Or well in this case specific case i guess it could use the average health value of all items used.

Up to you how to deal with it

[Rseding91]

Thanks for the report. It's now fixed for a future release.