Missing technology modifier-descriptions for character bonuses?

Place to discuss translation contributions. Recent and
oncoming changes related to translation.
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3840
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Missing technology modifier-descriptions for character bonuses?

Post by eradicator »

I feel like i've asked this before...
I noticed that the following bonus modifiers have no translation in the technology tooltip:

Code: Select all

modifier-description.character-crafting-speed
modifier-description.character-running-speed
modifier-description.character-build-distance
modifier-description.character-reach-distance
modifier-description.character-item-drop-distance
modifier-description.character-resource-reach-distance
modifier-description.character-item-pickup-distance
modifier-description.character-loot-pickup-distance
Of course i can manually fix them for english:

Code: Select all

[modifier-description]
character-crafting-speed=Crafting speed: +__1__
character-running-speed=Running speed: +__1__
character-build-distance=Building distance: +__1__
character-reach-distance=Manipulation distance: +__1__
character-item-drop-distance=Item drop distance: +__1__
character-resource-reach-distance=Mining distance: +__1__
character-item-pickup-distance=Item pickup distance: +__1__
character-loot-pickup-distance=Loot pickup distance: +__1__
But this seems weird as they are already correctly translated in the "Bonus Gui". I've found this old thread dealing with a similar problem, but i'm not sure if that discussion was more about modded "nothing" modifiers than built-in ones. And the locale system has no support for dynamically cross-referencing the translated strings from "[gui-bonus]".
____________________

So why are these only translated in the bonus gui? Would it be realistic to request them to be officially added?
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Honktown
Filter Inserter
Filter Inserter
Posts: 489
Joined: Thu Oct 03, 2019 7:10 am
Contact:

Re: Missing technology modifier-descriptions for character bonuses?

Post by Honktown »

If the strings have the same name, can you just copy and paste the entries from one locale to another?

If you tell me what I was looking for, I could write a script that does it for all locales/strings that are in one but not the other. I'd be more worried they have different names.
I have mods! I guess!
Link

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3840
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: Missing technology modifier-descriptions for character bonuses?

Post by eradicator »

The issue is not "how do i script around base game issues".
The issue is "why is this an issue in the first place and how do i get it fixed properly?".
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Honktown
Filter Inserter
Filter Inserter
Posts: 489
Joined: Thu Oct 03, 2019 7:10 am
Contact:

Re: Missing technology modifier-descriptions for character bonuses?

Post by Honktown »

To get it fixed properly, locale strings should have a global scope, and be accessed from there. That would be it. There could be a potential performance issue, depending on how Lua handles the key to a string (there would be a lot of strings in there).

Presumably strings have scoping, and it wasn't enough of an issue to go back and fix it for everything, as for the reason.
I have mods! I guess!
Link

Post Reply

Return to “Translations”

Who is online

Users browsing this forum: No registered users