[0.17.48] Possible to put offshore pump on the edge of shallow/deep water

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
Dev-iL
Filter Inserter
Filter Inserter
Posts: 266
Joined: Thu Jul 02, 2015 2:48 pm
Contact:

[0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Post by Dev-iL »

As I understand, the shallow (walkable) water terrain should not allow any buildings on top of it, however, it is currently possible to place an offshore pump on the interface between it and water (but not connect any pipes to it).

Image
Leading Hebrew translator of Factorio.

posila
Factorio Staff
Factorio Staff
Posts: 4648
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Post by posila »

Thanks for the report.

As Twinsen would say ... I fucked myself. Offshore pump is built on water (not on ground), but it has check that tile adjacent to it's pipe output has ground collision layer.

I really, really want to avoid adding new collision layers, as it would mean I would have to remove one of the few unused layers exposed to mods (layer-11 to layer-15), I absolutely didn't want to do full pipe buildability check and it made sense to me at that time to do it as "collision test" - test if tile has collision layer(s), as opposed to using regular "collision mask" which would test the tile doesn't collide with given layers. So solution would be to change the fluid_box_tile_collision_test to fluid_box_tile_collision_mask, but I don't want to bring more wrath of modders onto us, just because of this minor issue, so I'll do it after 0.17 is stable for future releases.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 4095
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Post by eradicator »

posila wrote:
Thu Jun 20, 2019 10:15 am
but I don't want to bring more wrath of modders onto us
The amount of wrath is linearly dependant on the usefulness of the "fix" to modders. If the fix happens to solve the sandpit only on sand problem you could easily generate negative wrath :mrgreen: . (I couldn't resist to make that joke...)
Author of: Hand Crank Generator, Screenshot Hotkey 2.0, /sudo
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
Dev-iL
Filter Inserter
Filter Inserter
Posts: 266
Joined: Thu Jul 02, 2015 2:48 pm
Contact:

Re: [0.17.48] Possible to put offshore pump on the edge of shallow/deep water

Post by Dev-iL »

This problem appears to be fixed by the introduction of the new pumps - feel free to move to "resolved".
Image
Leading Hebrew translator of Factorio.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users