Request: Upgrade of Smart Display Mod to 0.17

[Pixel_Builder]

Greetings,

I was wondering if anyone could upgrade the Smart Display mod from 0.16 to 0.17.
I've been waiting (and even tried and failed to do it myself) for someone to do it but nothing.

Here's the URL: https://mods.factorio.com/mod/SmartDisplayRedux_Fixed

Thanks for such a great game!

[darkfrei]

I was wondering if anyone could upgrade the Smart Display mod from 0.16 to 0.17.

Did you try just change the game version in the info.json?

[Pixel_Builder]

Yes - But that failed as well.

Here's the error msg I get when loading:

[darkfrei]

You are need to find and replace "textfield_style" to "textfield"

[eduran]

You are need to find and replace "textfield_style" to "textfield"

That is not correct, you need to replace every instance of "textfield_style" with "textbox_style":

Code: Select all

type = "textbox_style"  -- good
type = "textfield_style"  --bad

There were a lot of changes to GUI elements, so I would expect further errors after this one.

[Pixel_Builder]

Thank you so much for your assistance.
That fixed that error but you are correct - It led to another.

[eduran]

Sprite width and height can no longer be zero in 0.17. You need to replace all instances of "height = 0" and "width = 0" with "height = 1" and "width = 1".

[Pixel_Builder]

Which now produces this...

[eduran]

That's a 0.17 classic Delete every line that says

Code: Select all

flags = {"goes-to-quickbar"}

[Pixel_Builder]

OK - I was able to fix that and I was also able to fix the Research Tech packs but now I get this:

[eduran]

A bit more complicated. In prototypes/display.lua find

Code: Select all

if invisible then
  -- invisible.additional_pastable_entities = {"smart-display"}
  invisible.minable.result = "smart-display-visible"
  invisible.picture_off.filename = "__SmartDisplayRedux_Fixed__/graphics/empty.png"
  invisible.picture_off.width = 0
  invisible.picture_off.height = 0
  invisible.picture_on.filename = "__SmartDisplayRedux_Fixed__/graphics/empty.png"
  invisible.picture_on.width = 0
  invisible.picture_on.height = 0
end

and replace it with

Code: Select all

if invisible then
  invisible.minable.result = "smart-display-visible"
  invisible.picture_off = {
    filename = "__core__/graphics/empty.png",
    width = 1,
    height = 1,
  }
  invisible.picture_on = {
    filename = "__core__/graphics/empty.png",
    width = 1,
    height = 1,
  }
end

[darkfrei]

The prototype with the "empty.png" must be 1x1, not 1x2 as yo made

Code: Select all

filename = "__SmartDisplayRedux_Fixed__/graphics/empty.png"
width = 1
height = 1

Or just change this picture to 2x2, it can help too.

[Pixel_Builder]

OK - So now I'm getting this:

[eduran]

You must have missed one "width = 0".

[Pixel_Builder]

OK - Thanks for your help.


Maybe someone more knowledgeable in this can take a look because it's beyond me.

[darkfrei]

Maybe someone more knowledgeable in this can take a look because it's beyond me.

Place your work here and I can fix the rest, it's not so difficult as you think.

[Pixel_Builder]

Great - Here it is. I've done what is on this page. Thank you.

[eduran]

This version loads, but I can't promise it will work properly.

[Pixel_Builder]

Good Morning,

Thank you eduran for all your help. It did load as expected and I'll report back as soon as I test it.

Update 1: Works as it should!!!

Thank you so much for your help again and enjoy your weekend!