[Dominik][0.17.38]Character gui not updating when writing LuaPlayer.auto_trash_filters

[Choumiko]

To reproduce:

• Open the character gui, switch to the Auto Trash tab

• Code: Select all

  /c game.player.auto_trash_filters = {["wood"] = 0, ["iron-plate"] = 5};
   game.print(serpent.line(game.player.auto_trash_filters))

• Displayed filters are not updated, changing to the logistics tab and back to Auto Trash also doesn't update, although the game.print says they have been set (and robots come to pick it up without reopening the gui)
• Close the gui and open it again: filters are displayed

Doing the same with the request slots works as expected:

Code: Select all

/c game.player.character.set_request_slot({name="iron-plate", count = 100}, 1);
game.player.character.set_request_slot({name="copper-plate", count = 150}, 2)

(With the character gui open and the logistics tab selected)

factorio-current.log

Code: Select all

   0.000 2019-05-13 10:22:06; Factorio 0.17.38 (build 44914, linux64, alpha)
   0.027 Operating system: Linux (Ubuntu 18.04)
   0.027 Program arguments: "./factorio" 
   0.027 Read data path: /home/choumiko/factorio/data
   0.027 Write data path: /home/choumiko/factorio [27835/195884MB]
   0.027 Binaries path: /home/choumiko/factorio/bin
   0.031 System info: [CPU: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz, 8 cores, RAM: 15990 MB]
   0.031 Environment: DISPLAY=:1 WAYLAND_DISPLAY=<unset> DESKTOP_SESSION=ubuntu XDG_SESSION_DESKTOP=ubuntu XDG_CURRENT_DESKTOP=ubuntu:GNOME
   0.031 Display options: [FullScreen: 0] [VSync: 0] [UIScale: custom (100.0%)] [Native DPI: 1] [Screen: 0] [Special: 00] [Lang: en]
   0.188 Available displays: 2
   0.188  [0]: PLX2783H 27" - {[1920,0], 1920x1080, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.188  [1]: SMBX2450 24" - {[0,0], 1920x1080, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.215 Initialised OpenGL:[0] GeForce GTX 1070/PCIe/SSE2; driver: 3.3.0 NVIDIA 390.116
   0.215   [Extensions] s3tc:yes; KHR_debug:yes; ARB_clear_texture:yes, ARB_copy_image:yes
   0.215   [Version] 3.3
   0.233 Graphics settings preset: very-high
   0.233   Dedicated video memory size 8192 MB
   0.233 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 100%] [DXT: high-quality]
   0.233                   [Max load threads: 32] [Max texture size: 0] [Tex.Stream.: 0] [Rotation quality: normal] [Color: 32bit]
   0.338 Info ModManager.cpp:240: Found duplicate mod AutoTrash, using higher version (4.0.6 > 4.0.5).
   0.362 Info ModManager.cpp:240: Found duplicate mod MultipleUnitTrainControl, using higher version (0.1.16 > 0.1.12).
   0.398 Loading mod core 0.0.0 (data.lua)
   0.444 Loading mod base 0.17.38 (data.lua)
   0.571 Loading mod base 0.17.38 (data-updates.lua)
   0.629 Checksum for core: 300852956
   0.629 Checksum of base: 2048447865
   0.976 Loading sounds...
   0.991 Info PlayerData.cpp:67: Local player-data.json available, timestamp 1557735722
   0.991 Info PlayerData.cpp:74: Cloud player-data.json unavailable
   1.068 Initial atlas bitmap size is 16384
   1.090 Created atlas bitmap 16384x16380 [none]
   1.093 Created atlas bitmap 16384x11464 [none]
   1.093 Created atlas bitmap 8192x3884 [decal]
   1.093 Created atlas bitmap 16384x4288 [low-object]
   1.093 Created atlas bitmap 2048x192 [icon-background, not-compressed, linear-minification, linear-magnification, linear-mip-level, , no-crop, no-scale]
   1.093 Created atlas bitmap 8192x3552 [mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   1.094 Created atlas bitmap 16384x6880 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   1.094 Created atlas bitmap 4096x1600 [smoke, mipmap, linear-minification, linear-magnification]
   1.094 Created atlas bitmap 4096x1408 [not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   1.094 Created atlas bitmap 8192x1496 [alpha-mask]
   1.097 Created atlas bitmap 16384x12644 [shadow, linear-magnification, alpha-mask]
   1.097 Created atlas bitmap 8192x2352 [shadow, mipmap, linear-magnification, alpha-mask]
   1.682 Atlases loaded from disk cache.
   1.689 Texture processor created (2048). GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
   1.690 Parallel Sprite Loader initialized (threads: 0)
   1.718 Sprites loaded
   1.744 Generated mipmaps (4) for atlas [3] of size 16384x4288   
   1.751 Generated mipmaps (3) for atlas [5] of size 8192x3552   
   1.773 Generated mipmaps (3) for atlas [6] of size 16384x6880   
   1.775 Generated mipmaps (3) for atlas [7] of size 4096x1600   
   1.780 Generated mipmaps (3) for atlas [8] of size 4096x1408   
   1.783 Generated mipmaps (3) for atlas [11] of size 8192x2352   
   1.785 Custom inputs active: 6
   1.828 Factorio initialised
   1.828 Info HttpSharedState.cpp:54: Downloading https://updater.factorio.com/updater/get-available-versions?username=Choumiko&token=<private>&apiVersion=2
   2.645 0 packages available to download (experimental updates enabled).

[Dominik]

Hi, it is true that the event to update the trash slots is missing. But I am now reworking the whole gui including the logistics system and that notification would be pointless, so I will not be adding it now.