[kovarex] [0.17.32] LuaGuiElement.caption not updating correctly

[Choumiko]

Setting the caption for a label to "" doesn't always update the GUI:

Screenshot from 2019-04-20 12-42-33.png (17.29 KiB) Viewed 2074 times

clicking the clear button should set the labels to be displayed as empty, actual result:

Screenshot from 2019-04-20 12-43-18.png (13.84 KiB) Viewed 2074 times

It seems like if a label has style.width AND style.height defined, setting the caption to "" doesn't update the display.
Setting the caption to any other string works as expected for all 3 labels

To reproduce: start new game with attached mod, click the clear button

When it get's fixed, could you explain what was wrong? This seems like such a strange thing to happen

log

Code: Select all

  0.000 2019-04-20 12:48:32; Factorio 0.17.32 (build 44530, linux64, alpha)
   0.045 Operating system: Linux (Ubuntu 18.04)
   0.045 Program arguments: "./factorio" 
   0.046 Read data path: /home/choumiko/factorio/data
   0.046 Write data path: /home/choumiko/factorio [27536/195884MB]
   0.046 Binaries path: /home/choumiko/factorio/bin
   0.050 System info: [CPU: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz, 8 cores, RAM: 15990 MB]
   0.050 Environment: DISPLAY=:1 WAYLAND_DISPLAY=<unset> DESKTOP_SESSION=ubuntu XDG_SESSION_DESKTOP=ubuntu XDG_CURRENT_DESKTOP=ubuntu:GNOME
   0.050 Display options: [FullScreen: 0] [VSync: 0] [UIScale: custom (100.0%)] [Native DPI: 1] [Screen: 0] [Special: 00] [Lang: en]
   0.312 Available displays: 2
   0.312  [0]: PLX2783H 27" - {[1920,0], 1920x1080, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.312  [1]: SMBX2450 24" - {[0,0], 1920x1080, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.492 Initialised OpenGL:[0] GeForce GTX 1070/PCIe/SSE2; driver: 3.3.0 NVIDIA 390.116
   0.492   [Extensions] s3tc:yes; KHR_debug:yes; ARB_clear_texture:yes, ARB_copy_image:yes
   0.492   [Version] 3.3
   0.513 Graphics settings preset: very-high
   0.513   Dedicated video memory size 8192 MB
   0.513 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 100%] [DXT: high-quality]
   0.513                   [Max load threads: 32] [Max texture size: 0] [Tex.Stream.: 0] [Rotation quality: normal] [Color: 32bit]
   0.694 Info ModManager.cpp:240: Found duplicate mod alien-biomes, using higher version (0.4.11 > 0.4.10).
   0.728 Info ModManager.cpp:240: Found duplicate mod alien-biomes, using higher version (0.4.13 > 0.4.11).
   0.740 Info ModManager.cpp:240: Found duplicate mod Bottleneck, using higher version (0.10.3 > 0.10.0).
   0.752 Info ModManager.cpp:240: Found duplicate mod MultipleUnitTrainControl, using higher version (0.1.15 > 0.1.13).
   0.802 Loading mod core 0.0.0 (data.lua)
   0.850 Loading mod base 0.17.32 (data.lua)
   0.978 Loading mod TestModGui 3.0.0 (data.lua)
   1.036 Loading mod base 0.17.32 (data-updates.lua)
   1.105 Checksum for core: 161597740
   1.105 Checksum of base: 3343873766
   1.105 Checksum of TestModGui: 1108552575
   1.470 Loading sounds...
   1.482 Info PlayerData.cpp:67: Local player-data.json available, timestamp 1555757310
   1.482 Info PlayerData.cpp:74: Cloud player-data.json unavailable
   1.555 Initial atlas bitmap size is 16384
   1.577 Created atlas bitmap 16384x16376 [none]
   1.581 Created atlas bitmap 16384x11376 [none]
   1.581 Created atlas bitmap 8192x3872 [decal]
   1.581 Created atlas bitmap 16384x3808 [low-object]
   1.582 Created atlas bitmap 2048x192 [icon-background, not-compressed, linear-minification, linear-magnification, linear-mip-level, , no-crop, no-scale]
   1.582 Created atlas bitmap 8192x3488 [mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   1.582 Created atlas bitmap 16384x6880 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   1.582 Created atlas bitmap 4096x1600 [smoke, mipmap, linear-minification, linear-magnification]
   1.583 Created atlas bitmap 4096x1392 [not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   1.583 Created atlas bitmap 8192x1496 [alpha-mask]
   1.585 Created atlas bitmap 16384x12632 [shadow, linear-magnification, alpha-mask]
   1.585 Created atlas bitmap 8192x2320 [shadow, mipmap, linear-magnification, alpha-mask]
   1.593 Texture processor created. GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
   1.877 Parallel Sprite Loader initialized (threads: 7)
  12.106 Sprites loaded
  12.161 Generated mipmaps for atlas of size 16384x3808
  12.173 Generated mipmaps for atlas of size 8192x3488
  12.191 Generated mipmaps for atlas of size 16384x6880
  12.194 Generated mipmaps for atlas of size 4096x1600
  12.202 Generated mipmaps for atlas of size 4096x1392
  12.206 Generated mipmaps for atlas of size 8192x2320
  12.258 Custom inputs active: 6
  12.301 Factorio initialised
  12.301 Info HttpSharedState.cpp:54: Downloading https://updater.factorio.com/updater/get-available-versions?username=Choumiko&token=<private>&apiVersion=2
  13.533 0 packages available to download (experimental updates enabled).

[kovarex]

Thanks for the report, it is fixed for the next version now.

All the variants didn't clear its internal data, but the bug was only visible on the last one. Why?

Because when drawing widgets, we only draw those, that have intersection with the current clipping rectangle. This is an optimisation so things are not drown in scrollable area when out of the view
By an (lucky) accident and definition, any area with surface 0 (so when width is 0 or height is 0) has always no intersection with any rectangle you give it, so widgets with this size are never rendered.