[kovarex] [0.17.6] Crash moving train station: "Rail::RailConnection::isConnectedTo"

[FeistyTeapot]

A crash happens when I'm moving a train station. It looks like a null pointer exception and my guess is that it's related to train pathfinding.

Version 0.17.6 running under Steam on Linux

Steps to reproduce from the attached save:
1. Send the train to next station
2. Mine the lower track left to right and the crash should occur when attempting to mine the first bend

How to avoid:
1. Send the train to next station
2. Finish the upper track before mining the lower track

[Loewchen]

Code: Select all

   0.000 2019-03-06 11:11:23; Factorio 0.17.6 (build 43339, linux64, steam)
   0.000 Operating system: Linux
   0.000 Program arguments: "/home/stefan/.local/share/Steam/steamapps/common/Factorio/bin/x64/factorio" 
   0.000 Read data path: /home/stefan/.local/share/Steam/steamapps/common/Factorio/data
   0.000 Write data path: /home/stefan/.factorio [239392/366731MB]
   0.000 Binaries path: /home/stefan/.local/share/Steam/steamapps/common/Factorio/bin
   0.008 System info: [CPU: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz, 8 cores, RAM: 15932 MB]
   0.008 Environment: DISPLAY=:0, WAYLAND_DISPLAY=<unset>
   0.008 Display options: [FullScreen: 0] [VSync: 1] [UIScale: automatic (100.0%)] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.038 Available displays: 1
   0.038  [0]: 0 - {[0,0], 1920x1080, SDL_PIXELFORMAT_RGB888, 60Hz}
   0.066 Initialised OpenGL:[0] Mesa DRI Intel(R) UHD Graphics 620 (Kabylake GT2) ; driver: 4.5 (Core Profile) Mesa 18.3.3
   0.066   [Extensions] s3tc:yes; KHR_debug:yes; ARB_clear_texture:yes, ARB_copy_image:yes
   0.066   [Version] 4.5
   0.168 Graphics settings preset: medium
   0.168   Dedicated video memory size 0 MB
   0.168 Graphics options: [Graphics quality: high] [Video memory usage: high] [Light scale: 25%] [DXT: low-quality]
   0.168                   [Max load threads: 32] [Max texture size: 0] [Tex.Stream.: 1] [Low quality rotation: 1]
   0.384 Loading mod core 0.0.0 (data.lua)
   0.471 Loading mod base 0.17.6 (data.lua)
   0.721 Loading mod base 0.17.6 (data-updates.lua)
   0.834 Checksum for core: 2038926808
   0.834 Checksum of base: 3541142062
   1.468 Loading sounds...
   1.593 Info PlayerData.cpp:69: Local player-data.json unavailable
   1.593 Info PlayerData.cpp:72: Cloud player-data.json available, timestamp 1551777938
   1.691 Crop bitmaps.
   3.487 Parallel Sprite Loader initialized (threads: 7)
  21.594 Initial atlas bitmap size is 16384
  21.707 Created atlas bitmap 16384x16384 [none]
  21.735 Created atlas bitmap 16384x4492 [none]
  21.749 Created atlas bitmap 16384x2116 [decal]
  21.773 Created atlas bitmap 16384x3808 [low-object]
  21.784 Created atlas bitmap 16384x1888 [mipmap, linear-minification, linear-magnification, linear-mip-level]
  21.823 Created atlas bitmap 16384x6880 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
  21.827 Created atlas bitmap 16384x480 [smoke, mipmap, linear-minification, linear-magnification]
  21.839 Created atlas bitmap 16384x456 [not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
  21.842 Created atlas bitmap 16384x748 [alpha-mask]
  21.875 Created atlas bitmap 16384x11236 [shadow, linear-magnification, alpha-mask]
  21.879 Created atlas bitmap 16384x1264 [shadow, mipmap, linear-magnification, alpha-mask]
  22.029 Created virtual atlas pages 4096x4096x5
  22.147 Texture processor created. GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
  22.659 Parallel Sprite Loader initialized (threads: 7)
  41.279 Sprites loaded
  41.651 Generated mipmaps for atlas of size 16384x3808
  41.816 Generated mipmaps for atlas of size 16384x1888
  42.101 Generated mipmaps for atlas of size 16384x6880
  42.247 Generated mipmaps for atlas of size 16384x480
  42.362 Generated mipmaps for atlas of size 16384x456
  42.434 Generated mipmaps for atlas of size 16384x1264
  42.509 Generated mipmaps for virtual atlas of size 8192x12288
  42.570 Custom inputs active: 0
  42.653 Factorio initialised
 293.679 Loading map /home/stefan/.factorio/saves/RWM3__.zip: 13230521 bytes.
 293.726 Loading Level.dat: 26037129 bytes.
 293.733 Info Scenario.cpp:147: Map version 0.17.5-1
 294.736 Loading script.dat: 390 bytes.
 294.742 Checksum for script /home/stefan/.factorio/temp/currently-playing/control.lua: 1848333929
 294.742 Applying migration: Base Mod: 2019-03-05_Factorio_0.17.6.lua
 507.173 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
 508.220 Info AppManagerStates.cpp:1766: Saving finished
 808.206 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
 809.176 Info AppManagerStates.cpp:1766: Saving finished
1109.175 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
1110.221 Info AppManagerStates.cpp:1766: Saving finished
1410.207 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
1411.267 Info AppManagerStates.cpp:1766: Saving finished
1711.257 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
1712.295 Info AppManagerStates.cpp:1766: Saving finished
2012.311 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
2013.392 Info AppManagerStates.cpp:1766: Saving finished
2325.657 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
2326.770 Info AppManagerStates.cpp:1766: Saving finished
2627.190 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
2628.273 Info AppManagerStates.cpp:1766: Saving finished
2928.273 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
2929.317 Info AppManagerStates.cpp:1766: Saving finished
3235.974 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
3237.146 Info AppManagerStates.cpp:1766: Saving finished
3537.157 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
3538.247 Info AppManagerStates.cpp:1766: Saving finished
3838.240 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
3839.277 Info AppManagerStates.cpp:1766: Saving finished
4139.273 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
4140.276 Info AppManagerStates.cpp:1766: Saving finished
4440.274 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
4441.396 Info AppManagerStates.cpp:1766: Saving finished
4741.457 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
4742.499 Info AppManagerStates.cpp:1766: Saving finished
5087.975 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
5088.970 Info AppManagerStates.cpp:1766: Saving finished
5391.307 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
5392.387 Info AppManagerStates.cpp:1766: Saving finished
5692.374 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
5693.449 Info AppManagerStates.cpp:1766: Saving finished
5993.440 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
5994.515 Info AppManagerStates.cpp:1766: Saving finished
6294.508 Info AppManager.cpp:267: Saving to _autosave2 (blocking).
6295.390 Info AppManagerStates.cpp:1766: Saving finished
6595.390 Info AppManager.cpp:267: Saving to _autosave3 (blocking).
6596.477 Info AppManagerStates.cpp:1766: Saving finished
6896.473 Info AppManager.cpp:267: Saving to _autosave1 (blocking).
6897.535 Info AppManagerStates.cpp:1766: Saving finished
7065.357 Error CrashHandler.cpp:515: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
Raw stacktrace: 0xaf9efb, 0xc6091d, 0xb51566, 0xb51920, 0xb51949, 0x37e00, 0x6896b3, 0xab99eb, 0xe7eb92, 0xe7f0bf, 0xe817b8, 0xe81c13, 0x783205, 0xbd3248, 0xc664e9, 0xcaca6b, 0xcae4ce, 0x6b974d, 0x945305, 0xe98d27, 0xecc1f5, 0xecc68d, 0xecc9e7, 0xefcae4, 0xefd0a0, 0xb01c31, 0x17cdfbf, 0x7a9d, 0
7070.177 Warning Logger.cpp:542: Symbols.size() == 44, usedSize == 28
#0  0x0000000000c6091d in std::__uniq_ptr_impl<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::_M_ptr() const at /usr/include/c++/8/bits/unique_ptr.h:150
#1  0x0000000000b51566 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::get() const at /usr/include/c++/8/bits/unique_ptr.h:343
#2  0x0000000000b51920 in std::unique_ptr<LoggerFileWriteStream, std::default_delete<LoggerFileWriteStream> >::operator->() const at /usr/include/c++/8/bits/unique_ptr.h:337
#3  0x0000000000b51949 in Logger::flush() at /tmp/factorio-build-6kQNu9/src/Util/Logger.cpp:578
#4  0x0000000000037e00 in Logger::logStacktrace(StackTraceInfo*) at /tmp/factorio-build-6kQNu9/src/Util/Logger.cpp:566
#5  0x00000000006896b3 in GlobalContext::getMap() at /tmp/factorio-build-6kQNu9/src/GlobalContext.cpp:1747
#6  0x0000000000ab99eb in CrashHandler::writeStackTrace(CrashHandler::CrashReason) at /tmp/factorio-build-6kQNu9/src/Util/CrashHandler.cpp:173
#7  0x0000000000e7eb92 in CrashHandler::commonSignalHandler(int) at /tmp/factorio-build-6kQNu9/src/Util/CrashHandler.cpp:518
#8  0x0000000000e7f0bf in CrashHandler::SignalHandler(int) at /tmp/factorio-build-6kQNu9/src/Util/CrashHandler.cpp:532
#9  0x0000000000e817b8 in ?? at ??:0
#10 0x0000000000e81c13 in Rail::RailConnection::isConnectedTo(Rail const*) const at /tmp/factorio-build-6kQNu9/src/Entity/Rail.hpp:38 (discriminator 2)
#11 0x0000000000783205 in Rail::isConnectedTo(Rail const*) const at /tmp/factorio-build-6kQNu9/src/Entity/Rail.hpp:57 (discriminator 2)
#12 0x0000000000bd3248 in RailPath::allRailsExist() const at /tmp/factorio-build-6kQNu9/src/Rail/RailPath.cpp:126 (discriminator 2)
#13 0x0000000000c664e9 in Train::isPathValid() at /tmp/factorio-build-6kQNu9/src/Rail/Train.cpp:1330
#14 0x0000000000caca6b in Train::recalculatePath(Train::AllowDirectionChange, bool, Rail const*) at /tmp/factorio-build-6kQNu9/src/Rail/Train.cpp:1953 (discriminator 5)
#15 0x0000000000cae4ce in TrainManager::recalculatePaths() at /tmp/factorio-build-6kQNu9/src/Rail/TrainManager.cpp:891 (discriminator 2)
#16 0x00000000006b974d in std::_Rb_tree<RailSegment*, RailSegment*, std::_Identity<RailSegment*>, TrainManager::SegmentRemoveData::LessSegmentById, std::allocator<RailSegment*> >::~_Rb_tree() at /usr/include/c++/8/bits/stl_tree.h:965
#17 0x0000000000945305 in std::set<RailSegment*, TrainManager::SegmentRemoveData::LessSegmentById, std::allocator<RailSegment*> >::~set() at /usr/include/c++/8/bits/stl_set.h:281
#18 0x0000000000e98d27 in TrainManager::SegmentRemoveData::~SegmentRemoveData() at /tmp/factorio-build-6kQNu9/src/Rail/TrainManager.hpp:83
#19 0x0000000000ecc1f5 in TrainManager::onRailDestroyed(Rail*) at /tmp/factorio-build-6kQNu9/src/Rail/TrainManager.cpp:513
#20 0x0000000000ecc68d in Rail::onDestroy() at /tmp/factorio-build-6kQNu9/src/Entity/Rail.cpp:390
#21 0x0000000000ecc9e7 in Entity::forceDestroy() at /tmp/factorio-build-6kQNu9/src/Entity/Entity.cpp:298
#22 0x0000000000efcae4 in Entity::destroy() at /tmp/factorio-build-6kQNu9/src/Entity/Entity.cpp:268
#23 0x0000000000efd0a0 in Entity::mine(Entity*, MiningCollector&, ForceData*, Player*, ConstructionRobot*) at /tmp/factorio-build-6kQNu9/src/Entity/Entity.cpp:888
#24 0x0000000000b01c31 in Entity::mine(Entity*, MiningCollector&, ForceData*, Player*) at /tmp/factorio-build-6kQNu9/src/Entity/Entity.cpp:861
#25 0x00000000017cdfbf in ManualStorage::handleMinedEntity(Entity*, bool) at /tmp/factorio-build-6kQNu9/src/ManualStorage.cpp:212
#26 0x0000000000007a9d in ManualMiner::performMining(unsigned int) at /tmp/factorio-build-6kQNu9/src/ManualMiner.cpp:123
#27 (nil) in Character::update() at /tmp/factorio-build-6kQNu9/src/Entity/Character.cpp:673
#28 (nil) in Chunk::updateActiveEntities(IntrusiveList<UpdatableEntity, void, false>&) at /tmp/factorio-build-6kQNu9/src/Surface/Chunk.cpp:554
#29 0x0000000000000001 in Chunk::isConditionallyActive(unsigned int) const at /tmp/factorio-build-6kQNu9/src/Surface/Chunk.cpp:885
#30 0x00007fd79509170a in Chunk::updateEntities(unsigned int) at /tmp/factorio-build-6kQNu9/src/Surface/Chunk.cpp:603
#31 0x000000000000000e in Surface::update() at /tmp/factorio-build-6kQNu9/src/Surface/Surface.cpp:1369
#32 (nil) in Map::updateEntities() at /tmp/factorio-build-6kQNu9/src/Map/Map.cpp:1435 (discriminator 2)
#33 0x00007fd75a0721d0 in Map::update() at /tmp/factorio-build-6kQNu9/src/Map/Map.cpp:1399
#34 0x0000000000548206 in Game::update() at /tmp/factorio-build-6kQNu9/src/Game.cpp:189
#35 0x00007fd759f8b5d0 in Scenario::update() at /tmp/factorio-build-6kQNu9/src/Scenario/Scenario.cpp:1077
#36 0x00007fd7db7fbf60 in Scenario::updateStep() at /tmp/factorio-build-6kQNu9/src/Scenario/Scenario.cpp:975
#37 0x0000000000000001 in MainLoop::gameUpdateStep(MultiplayerManagerBase*, Scenario*, AppManager*, MainLoop::HeavyMode) at /tmp/factorio-build-6kQNu9/src/MainLoop.cpp:1101
#38 0x0000000000546a1f in MainLoop::gameUpdateLoop(MainLoop::HeavyMode) at /tmp/factorio-build-6kQNu9/src/MainLoop.cpp:968
#39 0x00007fd795089938 in std::function<void ()>::operator=(decltype(nullptr)) at /usr/include/c++/8/bits/std_function.h:495
#40 (nil) in WorkerThread::loop() at /tmp/factorio-build-6kQNu9/src/Util/WorkerThread.cpp:42
#41 (nil) in execute_native_thread_routine at blake2s.c:?
#42 0x0000000000546c94 in ?? at ??:0
#43 0xb58867b8b82c0cc7 in ?? at ??:0
Stack trace logging done
7074.912 Warning Logger.cpp:542: Symbols.size() == 39, usedSize == 27
7074.913 Error CrashHandler.cpp:174: Map tick at moment of crash: 9854816
7074.913 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
7142.426 Uploading log file

[kovarex]

Thanks for the report, it is fixed for 0.17.7 now.