[0.16] Ingame mod portal patch version

[Jelmergu]

When specifying a patch version in `factorio_version` of a mods info.json file, the ingame mod portal display's 'no released version' even when the game's version is greater than that version.

Example:

• Game's version: 0.16.22
  info.json

  Code: Select all

  {
      "name": "mod",
      "version": "0.0.1",
      "title": "mod",
      "author": "author",
      "homepage": "on-the-internet",
      "factorio_version": "0.16.7",
      "dependencies": ["base >= 0.16.7"],
      "description": "Example"
  }
  

The web mod portal shows that the version of Factorio needed is 0.16.7 as expected, however when viewed on the ingame mod portal it shows no released version, even though the games version is way over the specified version

I discovered this because of this bug report to one of my mods https://mods.factorio.com/mod/there-is- ... 000d35e70e

[Klonan]

When specifying a patch version in `factorio_version` of a mods info.json file, the ingame mod portal display's 'no released version' even when the game's version is greater than that version.

Example:

• Game's version: 0.16.22
  info.json

  Code: Select all

  {
      "name": "mod",
      "version": "0.0.1",
      "title": "mod",
      "author": "author",
      "homepage": "on-the-internet",
      "factorio_version": "0.16.7",
      "dependencies": ["base >= 0.16.7"],
      "description": "Example"
  }
  

The web mod portal shows that the version of Factorio needed is 0.16.7 as expected, however when viewed on the ingame mod portal it shows no released version, even though the games version is way over the specified version

I discovered this because of this bug report to one of my mods https://mods.factorio.com/mod/there-is- ... 000d35e70e

I believe you are just doing it wrong, 'factorio_version' shouldn't have a minor version, and isn't like the dependency system.

It should only be major version, so '0.16'

[eradicator]

Imho it wouldn't hurt if the json parsing stage had a tiny bit more sanity checking. This and the whole "your mod is silently ignored if the json is formatted incorrectly" feels so much like unnessecary stumbling blocks for new modders... :oops: