[Rseding91] [0.14.9] Combining ammo stacks leaves stack size minus one

[Kirk]

I'm not sure exactly how I combined two stacks of (bullet) ammo, but it was with one stack under the cursor and the other stack in the inventory, and at least one of the two stacks had a partially used magazine. I ended up with a stack of 99 magazines in my inventory, instead of the 100 one would expect, with the rest in my hand. It's possible it combined some magazines in some way.

[Rseding91]

I don't understand what you're saying.

Do you have steps to reproduce the issue along with what happens and what you expect to happen?

[Kirk]

Ok, I encountered it again, and this is what I think happens: When you combine two stacks of ammo, both of which have a magazine that when combined would be less than 100% full, the stack that is not in your hand ends up as a stack of 99.

Steps to reproduce:
1. In the attached autosave, find the piercing bullet ammo box. It is in the lower middle of the base.
2. Take the ammo from the box in hand (under the cursor).
3. Click the submachinegun ammo on the lower right of the screen.
4. Observe a stack of 99 under the submachine gun.

I suppose I expected a stack of 100.

[Loewchen]

No idea if that needs fixing:

Animation.gif (114.89 KiB) Viewed 2676 times

[Rseding91]

I looked into the logic a little and any fix for the issue would add a lot of complexity to the item transfer logic that I don't think is worth it. If you click again on the stack it will transfer the durability over once the stack is full.

[Kirk]

Good idea Loewchen, I should just make a GIF next time!