[0.14.7] [Oxyd] Inconsistent cmd parameters --load-game/--benchmark

[Zulan]

Apparently --load-game requires a path to a safe file including the zip extension (e.g.

Code: Select all

./factorio --load-game TEST

results in a GUI notice "Opening zip TEST failed: No such file or directory". Or:

Code: Select all

Error Util.cpp:57: Opening zip TEST_BASELINE failed: No such file or directory

In conjunction with --until-tick.

Correct is

Code: Select all

./factorio --load-game path/to/saves/TEST.zip

On the other hand:

Code: Select all

./factorio --benchmark path/to/saves/TEST.zip

results in:

Code: Select all

Error Util.cpp:57: Opening zip /path/to/saves/path/to/saves/TEST.zip.zip failed: No such file or directory

The correct form being

Code: Select all

./factorio --benchmark TEST

That is midly annoying.

Suggested fix: Unify opening of save games using
1) Try to open the parameter as file open({param})
2) Try to open({write-data}/saves/{param}.zip)
3) Fail

[Oxyd]

Fixed in 0.14.8 – --benchmark will behave like --load-game and others do.