[MOD 0.14.x] SJT-DirtyOre

[SeelenJaegerTee]

Type: Mod
Name: Dirty Ore
Description: Adds dynamically created contaminated ores. Ore processing. More chemical plants and refineries. Features can be toggled with config file. Should work with (almost) all mod ores, conditional recipes if bobmods is present.
License: CC BY-NC 4.0 (https://creativecommons.org/licenses/by-nc/4.0/)
Version: 0.5.2
Release: 2016-08-14
Tested-With-Factorio-Version: 0.13.15
Category: Item, SimpleExtension, Gameplay, Convenience
Tags: Resource, Ore, oil refinery, chemical plant, assembling machine
Download-Url: https://mods.factorio.com/mods/SeelenJa ... /downloads
Website: viewtopic.php?f=94&t=30954

Changelog:
0.7.3

• Fixed a bug where when a trace deposit dropped to the minimum yield value an error occured.

0.7.2

• changed info.json to work with 0.14 - let's hope that everything still works with the new version

0.7.1

• fixed a bug in the generator indexing function

0.7.0: Feature complete. (original idea for production tree rework is impossible as i dynamically create my stuff, changed it in another way.)

• added corrosion and environmental pollution when using waste-water in generators
• added missing techs for higher tiers of chemical-plants and oil-refineries

0.6.0

• Rewrote the logic for item generation and ore spawning (now it should really duplicate the mined items, it is now compatible with liquid resources)
• Added config option for localisation

Roadmap:
The only thing to do now is bug-squishing and perhaps re-balancing. 1.0.0 could in theory be released once I have my own graphics.

License

License
You are free to:
Share — copy and redistribute the material in any medium or format
Adapt — remix, transform, and build upon the material

Under the following terms:
Attribution — You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use.
NonCommercial — You may not use the material for commercial purposes.
No additional restrictions — You may not apply legal terms or technological measures that legally restrict others from doing anything the license permits.

Long description

Long description
This mod takes the idea of the dirty ores and introduces them into the game.
When a ore deposit is depleted it is replaced by a dirty ore variant. When a dirty ore deposit is depleated it is replaced by a trace ore variant with infintie yield.
Dirty and trace ores need to be processed before smelting into plates.
The ores are dynamically created on load up this has advantages and disadvantages.
(+) it should generate dirty ore variants of all mods that load before mine
(+) we're getting such hilariously sensible things like trace stone deposits that need to be refined into stone and have as a byproduct stone
[s](-) I am unable to use "good" icons as it is impossible to overlay two icons at the present time (if I'm wrong and you know how this works please tell me). Right now I'm using the icon of the "parent" ore.[/s] This actually is possible

The mod also introduces higher tiers of chemical plants and oil refineries, two new assembling machines and buildings for the processing of dirty ores.
Features can be toggled in the config file.


The research costs and recipies for ore processing may still need rebalancing. Please report any bugs or balancing issues you may find.

readme

readme
License: CC BY-NC 4.0 (https://creativecommons.org/licenses/by-nc/4.0/)

References:
Inspiration came from the dirty ore mod from Fentus (viewtopic.php?f=179&t=21354)
Ore Flotation cell and ore leaching plant are taken from Arch666Angel's refining mod (viewtopic.php?f=185&t=24906), that was released under CC BY-NC 4.0 License (https://creativecommons.org/licenses/by-nc/4.0/). Artwork is by YuokiTani(ore floatation, ore leaching), ADKrieg (clarification plant).

special thanks to
Arch666Angel for releasing his mod under CC so that I could steal ... errr I mean borrow his assets and part of his code.
Kyranf, Rsendig91, Degraine - helped me a lot in the #factorio-modding channel

[ZombieMooose]

Love the concept, but can you limit visibility of ores that don't spawn so there isn't a bunch of recipes that aren't relevant.

Also the names are their un localized names.

Cheers

[SeelenJaegerTee]

Could you elaborate on that:

[...] of ores that don't spawn so there isn't a bunch of recipes that aren't relevant.
[...]

What mods are you using and what ore doesn't spawn?
It seems strange to me that a mod brings an ore that doesn't spawn.
Perhaps you could attach a screenshot?

[...]
Also the names are their un localized names.
Cheers

Yes as far as I can see there is nothing I can do about that.

To my knowledge it works the following way: Localised names are loaded after the entities are created. This means that when I am dynamically creating the ores the localised name is not yet added to the entity and because of this I can't read it to create my own localised name. For this reason I need to generate my localised name from the "raw-data-name" of the ore.
This is unfortunate and I'd like it to be different but - at least to my knowlede of how the game works - this is the only way I can do it.

[ZombieMooose]

Could you elaborate on that:

[...] of ores that don't spawn so there isn't a bunch of recipes that aren't relevant.
[...]

What mods are you using and what ore doesn't spawn?
It seems strange to me that a mod brings an ore that doesn't spawn.
Perhaps you could attach a screenshot?

I'm just saying when I have Angel's installed, it also has recipes for Copper and Iron which don't spawn in the world, and you don't need the recipes.

[ZombieMooose]

Found another bug.

Because you override the ore floatation cell (mk1,2,3) they cannot create Angel's recipes - nameley Sapharite Hydro Refining (to create Sapharite Chunks) and similar recipes which are necessary for higher tier bob's mods ores.

[SeelenJaegerTee]

Could you elaborate on that:

[...] of ores that don't spawn so there isn't a bunch of recipes that aren't relevant.
[...]

What mods are you using and what ore doesn't spawn?
It seems strange to me that a mod brings an ore that doesn't spawn.
Perhaps you could attach a screenshot?

I'm just saying when I have Angel's installed, it also has recipes for Copper and Iron which don't spawn in the world, and you don't need the recipes.

Added a blacklisting option in the config file to hide recipies you don't want.

Found another bug.

Because you override the ore floatation cell (mk1,2,3) they cannot create Angel's recipes - nameley Sapharite Hydro Refining (to create Sapharite Chunks) and similar recipes which are necessary for higher tier bob's mods ores.

Should be fixed now.
My buildings now have different names.

Unfortunately the huge rewrites for the 0.6.0 version mean that migration is not within my limited capabilities.

[PS] I initially didn't account for an interaction between my mod and Angel's as it is totally beyond my why someone would want to use my mod when already using Angel's refining. I mean he already has his own infinite ore companion mod. But I guess more power to the peple.[/PS]

[ZombieMooose]

Rad. I'll post a Angel's config when I can get on the computer.

[PS] I initially didn't account for an interaction between my mod and Angel's as it is totally beyond my why someone would want to use my mod when already using Angel's refining. I mean he already has his own infinite ore companion mod. But I guess more power to the peple.[/PS]

More complexity = more better

[SeelenJaegerTee]

Updated to 0.14.
I just changed the required factorio version and fired up a new game and loaded a save game, seems to work.

[SeelenJaegerTee]

Fixed a bug where when a trace deposit dropped to the minimum yield value an error occured.

If this bug is occurring for you and you are still playing the .13 Version of factorio: Download the 0.7.3 version of my mod for Factorio .14. Then open the info.json file in my mod's folder. Change "factorio_version": "0.14" to "factorio_version": "0.13". This should work for you.

[ZombieMooose]

Still angels again: There's a bug where when angels is installed it doesn't allow you to research the techs required to process dirty and trace ores. Both versions still spawn though so you're left with chests full of dirty ore with nothing to do about it.

I wonder if it's an issue on their end? I'll contact Angel in the meantime and see if there is anything they can do.

EDIT: according to Angel it is an issue with your mod. I would love to see compatibility between the two if at all possible.

[Usernm]

Oil patch shouldn't depleted, but your mod try to replace it with dirty wariant and everything fails.

[id1740]

https://drive.google.com/file/d/0B8YPcJ ... p=drivesdk
Fixed with blacklisting crude oil.

[Anson]

a very nice addon, giving lots of ore, not for free, but having to build some big setup to handle the dirty ores.

some remarks and maybe a bug on the water and contaminated water :
(for the BUG, skip to the last paragraph after the second screenshot)

general fact: concentration units convert 5 water to 5 contaminated water, and the clarification plant does the opposite. thus those two machines can be combined to a loop that doesn't need more water, nor does it produce any surplus water.
since the concentration unit only needs 3/4 second per cycle (1 second x 0.75 crafting speed) one such machine converts 3.75 units of water in 5 seconds. the slower clarification plants need 5 seconds per cycle (5 seconds x 1.0 crafting speed) and thus we need 4 clarification plants for each concentration unit (in a bigger setup, we need only 15 clarification units instead of 16 for each 4 concentration units) to run the concentration units at max speed, using an endless loop for water which only has to be filled with some water in the beginning to start the process.

my first thought about that setup with five big machines: why do i have to use so many machines when i simply can destroy the contaminated water (eg with the usual method of piping it to a steam engine, maybe even using boilers on the dirtwater to power my orecleaning machines :-) but i didn't test that yet). i would have to refill fresh water, but with an offshore pump that would be easy and i would need only 1 big machine and some small other stuff. is my environmental conscience the only thing that keeps me from dumping wastewater?
EDIT: in the meantime, i have tried and failed : really nice that the contaminated water damages steam engines over time and thus I really have to clean the water ... unless i get too annoyed in the long run and simply use another mod that destroys any liquid :-) :-(
Maybe cleaning the water should be expensive, but not that expensive, taking almost 4 times as much effort, machines and space than concentrating the dirty ore ...

Another disadvantage of such a big setup to use the dirty ore: on my map, i had only one of each type of ore patch, and almost right from the beginning, there was some dirty coal (and other ores) among the normal coal/ore. i had to fix that manually by picking up the dirty coal and ore when they stopped my power generation and my first smelters. until i could use green science and had researched steel, oil production and oil handling, i already had some chests full of dirty coal and dirty ores. the technologies themselves for using the dirty ore are cheap and easy to research, but not before having researched a lot of other things, including a lot of oily stuff to make red circuits, etc ...
is there any way to not get dirty ore in the early game, or could the MK1 versions of the mod be changed so that they work purely mechanical (without need for doing the oil tree first) ? what about a MK0 version that allows simply washing the dirty ore (of course with lower amounts of cleaned ore than the current MK1) ?

next i just watched that setup, letting it run for some time and noticed that it lost water and i had to refill water from time to time. shouldn't the closed loop convert back and forth between fresh water and contaminated water with no loss (5 fresh -> 5 contaminated -> 5 fresh -> etc) ???

to check in detail, i set up the following loop (using 5 instead of 3.75 clarification plants since at first i had forgotten to include the crafting speed in my calculations), attaching nixies to my chests and the two buffer tanks (one each for fresh and contaminated water). I also added some combinators to start a counter and thus measure leakage per time. result: it takes around 8800 ticks until i have lost 500 water from the closed loop (roughly 3 water per second)
where is the leak ? are vanilla pipes and tanks leaking, or your machines ?

Test setup to find out how much water is leaked from a closed loop

DirtyOre-Leak.PNG (302.22 KiB) Viewed 8891 times

the solution, what caused the problem: to do the above screenshot, i built the loop a second time at some free space on my map, and let it run ... and there was NO leakage! ... after trying a lot of things, i found the cause of the leak:

the cause of the bug

Dirtwater.PNG (67.6 KiB) Viewed 8891 times

The bug is, that there are two icons for contaminated water, one of them working properly with no leak, but when i select the other icon to start the clarification plant, the above leakage happens and i have to refill water all the time.
maybe the two icons have some reason, like two joined outputs or something, but as user it is impossible to see which icon should be used and that one of the icons has bad side effects.

[StormTAG]

Oddity: Using Bob's modules, the machines will only accept raw-speed, pollution creation and pollution reduction modules. Regular speed modules do not work, which is odd to me. I understand why productivity might not apply although I could understand equally arguments that it should ie. more effective scrubbing, etc. Although it would create water as magic.

Suggestion: If Angel's mods are enabled, rather than stone as a by-product, crushed stone would be a more appropriate byproduct to fit in with the rest of the chain.

[ZombieMooose]

Is this mod dead? I would love to see this updated for Angel's.

[m23]

Is it posibile to make trace ore fintie?

[kingarthur]

ive updated this mod to v.16.

forum post:
viewtopic.php?f=190&t=64077

mod portal page:
https://mods.factorio.com/mod/SJT-DirtyOre-Remastered