[0.12.33] Crash setting offline players force

[binbinhfr]

Hi,

During my new mod testings, I have a bug that I can reproduce.
Here is the link on the MP map :
https://mega.nz/#!BMEUyJSa!brv-GfX3aPNj ... 9x6-fBAe5w

It's a map with several mods, but you can open it with no mods. The crash is the same weither original mods are installed or not.

Then here is the mod I tried to install to open the map (just a very simple control.lua , that I simplified specially for you ).
This mod creates a force "guests" during on_configuration_changed (or on_init), and then, during on_player_created, it affects the player to this force (call to init_player).
But infact the call to init_player is done twice when I just load the map for the first time, because the mod AND the player are new and trigger both events.

This mod works fine on new maps and other maps I use, but not on this existing big one that I retrieve from a real multiplayer game for my testing needs...

So it seems that doing this duplicated call to "player.force = global.force_guests" creates the crash.

An idea ? I am quite blocked at the moment because I want these players to test my mod, but it crashes the game for a mysterious reason...

Anyway, thx for the game.

mod and log in attachemenst

[Klonan]

Thanks for the report,

I reproduced it using these commands in a MP map with offline players:

Code: Select all

/c global.force_guests = global.force_guests or game.create_force( "guests" )
function init_player(player)
  player.force = global.force_guests
end
	
for _, player in pairs(game.players) do
  init_player( player )
end	
	

This crashes because you are trying to change the force of a player who isn't connected,

I prevented the crash by adding this line

Code: Select all

for _, player in pairs(game.players) do
  if player.connected then
    init_player( player )
  end
end

But that doesn't do as your mod would intend,
You need to change all the players forces to guest, regardless of if they are connected...

At the very least, the game shouldn't crash out

[binbinhfr]

Ok, I see. Cannot change force of a deco player... I did not figure out that one.
Well, waiting for the on_player_connect event of the 0.13 (you will add it, won't you ?), it would be great to offer this possibility in the next 0.12 subrelease (without crash of course ).

I see a lot of people going to MP and enjoying it, but wanting to do a little RP or PvP : that's why I work on a MP mod, but without the possibility to track connections/deconnexion it's not easy. For the moment, I poll connected status in on-tick, but it does not work for the last player deconnecting from the server.

Because when nobody is connected, the server goes directly on pause and does not run the few necessary ticks to detect last player deconnexion, so that at reconnexion, I could check that his last connected status was false, and conclude to reconnexion. So it could be great that, before pausing, the headless server runs a few more ticks (let say 60*5) to be sure that mods polling for connected players can update their global connexion/deconnexion variables).

Of course, with a future on_player_connect event would be part of the solution, but we would also need a on_player_disconnect to be precise, no ?

Anyway, keep on with this nice game ! These bugs are minor and globally this program is very stable (i can tell you, because I do a LOT of testings).

[binbinhfr]

Hi Klonan, I come back on this post because I remember that you wrote :
"This crashes because you are trying to change the force of a player who isn't connected,"

The fact is that in my mod, I succeed in changing the force on a non-connected player, but not if I do it too close from the force creation (in the same function).
So I suppose that this bug has something to do with the delay between the force creation an the affectation of disconnected players to this force. Factorio program has to take back focus between both actions to avoid the bug.

I hope this help. It would be nice to have this bug corrected.

Have a nice day.

[Rseding91]

Thanks for the report. This is now fixed for the next version.

[binbinhfr]

Thanks for the report. This is now fixed for the next version.

OK. But can you confirmed that we're allowed to change a player force if he is deconnected ? Because it seems that we can, and it's nice for me.

[Rseding91]

Thanks for the report. This is now fixed for the next version.

OK. But can you confirmed that we're allowed to change a player force if he is deconnected ? Because it seems that we can, and it's nice for me.

Yes, that's what I fixed - the crash when setting the force of an offline player with roboport equipment.