[0.12.32] set_circuit_condition doesn't work on constant combinators

[Adil]

set_circuit_condition function doesn't alter constant combinator's state.
It's unclear whether it should, however, but the following code simply does nothing silently.
If not fixed it'd be good to have at least clear information on that function in docs.

Code

Code: Select all

const=defines.circuitconditionindex.constant_combinator
string2logic=function(ent,str)
    local par={}
    for i = 1, #str,2 do
        par[i]={
            count=1,
            index=i,
            signal={
                type="virtual",
                name=num2sign[str:sub(i, i)],
                }
            }
    end
    ent.set_circuit_condition(const,{parameters=par})
end

sign2num={
    ["signal-1"]=1,
    ["signal-2"]=2,
    ["signal-3"]=3,
    ["signal-4"]=4,
    ["signal-5"]=5,
    ["signal-6"]=6,
    ["signal-7"]=7,
    ["signal-8"]=8,
    ["signal-9"]=9,
    ["signal-0"]=0,
}
num2sign={}
for k,v in pairs(sign2num) do num2sign[v]=k end

To reproduce

In addition to pushing the above code to console, the following command will be needed.

Code: Select all

/c p=game.player; c=p.surface.create_entity{name="constant-combinator", position={0,0}, force=p.force}; string2logic(c,"412") 

[Oxyd]

LuaEntity::set_circuit_condition epects parameters to be just one ConstantCombinatorParameters, yet you appear to be passing an array of them.

I think the documentation is quite clear in this regard. If you can propose an exact wording to make this more obvious, I might add it there.

Moving to Not a Bug.

[Rseding91]

Are you sure your code is correct? It works perfectly for me and in fact we have tests to ensure it stays working:

Code: Select all

/c game.player.selected.set_circuit_condition(1, {parameters={{signal={type="item",name="steel-chest"},count=69,index=1}}})

[Adil]

Indeed there was an error in code.
And docs for 0.12.32 seem quite informative on the matter.
Excuse me for bothering.