[0.12.7] icon = "" causes unhelpful crash.

[vzybilly]

I was doing some work and had a place holder

Code: Select all

icon = ""

in my mod, it caused a crash log of:

crash

4.022 Warning Logger.cpp:315: Symbols.size() == 15, usedSize == 8
Factorio crashed. Generating symbolized stacktrace, please wait ...
4.690 Warning Logger.cpp:315: Symbols.size() == 14, usedSize == 7
#0 0x7f6c0f663d40 in ?? at ??:0
#1 0x970d44 in cropBitmaps at /tmp/factorio-OYbEE9/src/Graphics/AtlasSystem.cpp:199
#2 0x978d65 in build at /tmp/factorio-OYbEE9/src/Graphics/AtlasSystem.cpp:472
#3 0xa0190c in clear at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/function/function_template.hpp:881
#4 0xa4fa5d in _ZN5boost9function1IvdED4Ev at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/function/function_template.hpp:765
#5 0x7f6c0f64eec5 in _ZN5boost8functionIFvdEED4Ev at /home/build/build_environment/boost_1_58_0/output_linux64/include/boost/function/function_template.hpp:1056
#6 0x40a389 in init at /tmp/factorio-OYbEE9/src/GlobalContext.cpp:354
4.690 Error Util.cpp:46: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

simple fix, put a print line telling if icon == "" or nil, or auto-fill with the empty image in base.

[Oxyd]

Okay, in 0.12.8 this won't crash. You'll still get an error about invalid path, of course.