[2.0.66] Pasting train stop settings allows train to bypass limit

[urquelle]

1. I used copy-paste settings (shift+RMB) to copy train station name and limit to another train stop (video included).
2. Settings are copied correctly, however, trains ignore the train station limit initially (as if they were dispatched before the limit was applied).
3. I wanted the train station limit to be applied before any train can possibly be dispatched.
4. It happens always on copy-paste settings tool.

I uploaded the video showcasing this bug on my google drive, since the site rejects .mkv files: https://drive.google.com/file/d/1TPAiLW ... sp=sharing

I have also included my save file.

[naahuc]

Attached a minimal example.

Repro:
Bottom right are two stations Set and Up.
Trains are waiting at the stops to the north.
Trains are waiting to go to Set, but Train Limit is 0 so they are waiting for a station to free up.
Up has a train limit > 0

When copying Set to Up, both trains will be dispatched immediately towards the former Up station.
This even happens with the game paused.

I could guess that the dispatcher is operating on an intermediate state before all the data has been fully copied over and it's not limited by tick barriers, hence the dispatch on the same tick as the change is happening. But in the end it's not even an educated guess.

[boskid]

Thanks for the report. I did some tiny adjustments to the train stop copy logic and the issue should be now fixed for 2.0.67.