[2.0.58] [mac-x64] Grammatical error in value for key `macos-preferred-graphics-backend`

[fardshid420]

Hey there! I recently went through the entirety of my config.ini to look for settings that don't appear in the settings UI, as I do every so often. The newest key under the [graphics] header, macos-preferred-graphics-backend, has a grammatical error in one of the options for valid values.

Code: Select all

; Options: open-gl, metal
macos-preferred-graphics-backend=metal

The valid values listed for macos-preferred-graphics-backend are open-gl and metal. Regardless of context, I think it's evident that the hyphen in the open-gl value should be removed, as the API's name is OpenGL. However, in addition to it being intuitive, there is precedent for this stylisation elsewhere in the Factorio configuration file, as seen here:

Code: Select all

; Options: true, false
; force-opengl=false

Just 130 lines above the macos-preferred-graphics-backend key, there is another key under the same [graphics] header named force-opengl. I think this makes this a pretty open-and-shut issue. Thank you to all of the developers for their continued support of Factorio.

[Rseding91]

Thanks for the report however changing this is only going to break existing configurations that are using the old naming scheme.

It functionally has no impact to be what it is so it’s best left alone and best to *not* break existing player setups.

[fardshid420]

Thanks for the report however changing this is only going to break existing configurations that are using the old naming scheme.

It functionally has no impact to be what it is so it’s best left alone and best to *not* break existing player setups.

I admit this may be a bit too overcomplicated, but I know of more than one game that does things this way, and it's not like you guys shy away from overcomplicated design. Would it be possible to change the value to opengl at the same time as implementing a configuration schema updater to fix things like this on-the-fly on launch of the game? Might be a bit out of scope for a bug report. But even if so, I'd just be interested in your thoughts, if you have a minute.

[Jap2.0]

I admit this may be a bit too overcomplicated, but I know of more than one game that does things this way, and it's not like you guys shy away from overcomplicated design. Would it be possible to change the value to opengl at the same time as implementing a configuration schema updater to fix things like this on-the-fly on launch of the game? Might be a bit out of scope for a bug report. But even if so, I'd just be interested in your thoughts, if you have a minute.

I'll give you 90% odds the answer is "we could but it's not worth it".