[Rseding91] [2.0.28] Missing supply area visualization for quality electric poles?

This subforum contains all the issues which we already resolved.
0n0w1c
Inserter
Inserter
Posts: 28
Joined: Sat Sep 09, 2023 1:43 pm
Contact:

[Rseding91] [2.0.28] Missing supply area visualization for quality electric poles?

Post by 0n0w1c »

When a mod creates transmission only electric poles, the quality poles do not display the supply area visualization when attempting to place them.

Transmission only defined as: supply_area_distance = 0
Making no changes to the radius_visualisation_picture.

I hope when considering the issue, the solution might also address this interface request (viewtopic.php?f=28&t=124669).
Screenshot 2024-12-20 at 7.29.02 PM.png
Screenshot 2024-12-20 at 7.29.02 PM.png (4.54 MiB) Viewed 826 times
Last edited by 0n0w1c on Sat Dec 21, 2024 4:53 am, edited 1 time in total.
Muche
Filter Inserter
Filter Inserter
Posts: 539
Joined: Fri Jun 02, 2017 6:20 pm
Contact:

Re: [2.0.28] Missing supply area visualization for quality electric poles

Post by Muche »

This seems to happen when prototype's supply_area_distance is exactly zero. Making it nonzero, e.g. 0.0001 enables visualization.

On the other hand, making it negative also shows it - effective area -4x-4 is visualized the same as 4x4.
0n0w1c
Inserter
Inserter
Posts: 28
Joined: Sat Sep 09, 2023 1:43 pm
Contact:

Re: [2.0.28] Missing supply area visualization for quality electric poles

Post by 0n0w1c »

I concur with your findings. However, as was pointed out to me, at least I think it is what they were trying to tell me... the bug is not about the particular value assigned to the base prototype, although it does have a significance. As can be seen in the screenshot, the Info window displays the quality bonus, the code that determines if the pole will supply the nearby entities recognizes the quality bonus, but the rendering engine does not.
0n0w1c
Inserter
Inserter
Posts: 28
Joined: Sat Sep 09, 2023 1:43 pm
Contact:

Re: [2.0.28] Missing supply area visualization for quality electric poles

Post by 0n0w1c »

In thinking about this, it is possible the rendering engine is correct and the other two pieces of code are incorrect.
When the supply_area_distance = 0, there should be no bonus. (Personally, I hope for this.)
Rseding91
Factorio Staff
Factorio Staff
Posts: 14770
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [2.0.28] Missing supply area visualization for quality electric poles?

Post by Rseding91 »

Thanks for the report. I've changed it for the next release so quality will not increase the supply area if it was 0 to begin with.
If you want to get ahold of me I'm almost always on Discord.
0n0w1c
Inserter
Inserter
Posts: 28
Joined: Sat Sep 09, 2023 1:43 pm
Contact:

Re: [Rseding91] [2.0.28] Missing supply area visualization for quality electric poles?

Post by 0n0w1c »

The change seems to be working properly, thank you very much!
Post Reply

Return to “Resolved Problems and Bugs”