[2.0.24] Crash saving, ItemRequestProxy check fails (ItemRequestProxy::save)

[thedoh]

I have a 2.0.24 vanilla game with four mods (bp100-2.1.1, helmod-2.0.12, RateCalculator-3.3.2, flib-0.15.0) that crashed while saving my game. I have several artifacts from this: The savegame, the partial savegame from the crash (eg the .tmp.zip), the factorio-dump-current.dmp file, the game log, and a Twitch.tv clip. If the dump and .tmp.zip file are of use to looking into this, I can make them available to devs.

[thedoh]

This seems to be fairly reproduceable. The save from which the reproduction is made is attached. Video, including user inputs, are also available on YouTube.

Note: This savegame is from bp100-2.1.2 whereas the original savegame is bp100-2.1.1.

[GlassBricks]

I've narrowed it down a bit more:

- Load the save without mods
- .destroy() train shown in the youtube video
/c game.player.selected.destroy()
- Try to save game -- crash

Removing the item request before destroying the train avoids the crash (as suggested by the logs saying stuff with item request proxies)

I'm guessing deleting that train causes an item request proxy in a bad state. Not sure how it got like that in the first place.

[Rseding91]

Thanks for the report. This is due to the mod you're using which has set the item request proxy as active = false which is an invalid state for item request proxies to be in. I've fixed it for the next release so if a mod tries to do that, it simply does nothing.