[2.0.19] Crash flipping modded pump: flipResult.direction != Direction::None

[Stringweasel]

What happened
If you flip some of the modded pumps (the valves from the Valves mod mod) the game crashes with

Code: Select all

  76.354 Error Entity.cpp:2337: flipResult.direction != Direction::None was not true

Reproduction

• Install mod
• Go into /editor (need editor to flip pumps which are set as operable=false)
• Place a Overflow or Top-Up valve (any direction)
• Flip (any direction, H or V)
• Crash!

The modded pumps
I believe it's caused by the linked + normal connection. The two pumps that crash's pipe connections look like this, or the inverse of this where the normal connection is the input, and the linked the output.

Code: Select all

    { direction = defines.direction.south, position = {0, 0}, flow_direction = "output" },
    { connection_type = "linked", flow_direction = "input", linked_connection_id=31113 - 1 }

It's probably due to this combination. The one-way valve has two linked connections and doesn't cause a crash, but it doesn't mirror correctly, instead it sort-off rotates.

Ref.: 125146

[Stringweasel]

For easy reproduction try to flip a modified pump with the following pipe connections:

Code: Select all

  pipe_connections =
  {
    { connection_type = "linked", flow_direction = "output", linked_connection_id=31113 },
    { direction = defines.direction.south, position = {0, 0.5}, flow_direction = "input" }
  }

[StormTAG]

Also ran into this issue. Was not actually connected to any pipes.

Attached a minimum-steps save file.

1. Load save file
2. Copy valve
3. Flip

[Krydax]

I am running into this HARD CRASH as well. All you need to do is copy a valve with ctrl+c and flip with H or V and boom, crash to desktop.

It's extra frustrating because you can't copy blueprints without living in fear you might have accidentally grabbed a valve and will crash your game. Hoping the devs can fix this one soon!

(this is also my second time writing this comment. My previous one seems to have been deleted by some unknown factor with no notification/explanation and I'm very confused by that)