[Rseding91] [2.0.16] Crash from Wriggler dying to attack_reaction "Error ShootingTarget.cpp:12: Unset shooting target"

[randomflyingtaco]

Enemies with 2 damaging target_effects that die when attacking an entity with a damaging attack_reaction will crash the game. Originally came up with Wrigglers attacking Laser Fences from https://mods.factorio.com/mod/laserfence but I've isolated and replicated it in a test mod that doesn't use any of the additional scripting present in Laser Fence (see attached testmod).

The crash seems dependent on the order of the damage trigger effects in target_effects, because Wrigglers will crash when dying to something with attack_reaction.damage_type = "physical" but not when dying to something with attack_reaction.damage_type = "poison"

Not present in vanilla, since no entities in vanilla have attack_reactions that I can see.

[Rseding91]

Thanks for the report. This is now fixed for the next release.