[boskid][2.0.14] Bogus pipeline overextended warnings where there shouldn't be any

[Yoyobuae]

Noticed that when building certain L-shaped pipelines that are too long, some additional "Pipeline has been overextended" warnings may pop-up in a place that makes no sense at all considering the pipeline limit rules. The attached save file is already focused on the bogus warning when you load it.

I've used the "show-fluid-segment-extend-limit" debug setting to verify the pipeline limits and the bogus warning does not match with any of the lines that show the extend limits.

And if one inserts a pump into the pipeline close to the warning, the warning will re-appear at a different but still non-sensical location. This process can be repeated over and over each time generating a new bogus pipeline over extended warning. The bogus warning will each time move closer and closer to the real warning.

Now reload the attached save file, add one pump to the pipeline close to the bogus warning then remove the pump from the pipeline (reverting the pipeline to the original state). The warning does not re-appear (further showing the warning was bogus to begin with).

EDIT: Forgot to mention that the straight pipeline besides the L-shaped one (both of same length) does not show that behavior

[boskid]

Thanks for the report. Issue is now fixed for 2.0.16.

It was caused by code that handles an unrelated corner case where extent bounding box was close to being 2*max extent in which case a connections could go from one side of overextent to other side of overextent. This was incorrectly handled by checking if connection is crossing a line spanned on extent's bounding box center point since both pipes were in the overextent, the connection was crossing this critical line however this was not correctly detecting this is not that exact case and the alert was incorrectly triggered.

[Yoyobuae]

Thanks!