[Klonan] [1.1.69] Crash scaling GUI with GUI debug enabled

Things that we don't consider worth fixing at this moment.
User avatar
_CodeGreen
Long Handed Inserter
Long Handed Inserter
Posts: 74
Joined: Sat Mar 05, 2022 11:30 am
Contact:

[Klonan] [1.1.69] Crash scaling GUI with GUI debug enabled

Post by _CodeGreen »

I was inspecting the locomotive GUI for a mod I'm working on when the game froze for a second due to an endless call stack and promptly crashed.

Steps to reproduce:
  1. Open locomotive GUI
  2. Enable GUI Debug with Ctrl + F5
  3. Scale up GUI with Ctrl + Numpad+
  4. GOTO 3
It seems to only be after scaling up exactly nine times that it crashes.
It also seems like it doesn't matter what order you do the steps in, as long as the locomotive GUI is opened with the debug enabled and the GUI scaled up nine times.
Attachments
factorio-current.log
(189.92 KiB) Downloaded 67 times
My Mods | If you can't make it perfect, make it adjustable
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 3453
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [1.1.69] Crash scaling GUI with GUI debug enabled

Post by boskid »

Scaling up 9 times is just a coincidence on your end, for me it is 11 times. Crash is basically a stack overflow because TabbedPane during resizing is recursively resizing itself which in this particular case causes it to blow up as every other nested call gets larger width.
User avatar
_CodeGreen
Long Handed Inserter
Long Handed Inserter
Posts: 74
Joined: Sat Mar 05, 2022 11:30 am
Contact:

Re: [1.1.69] Crash scaling GUI with GUI debug enabled

Post by _CodeGreen »

Figures as much, GUI scaling issues are bound to change on different displays.
My Mods | If you can't make it perfect, make it adjustable
User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5331
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.69] Crash scaling GUI with GUI debug enabled

Post by Klonan »

I decided I don't really want to look into this, its deep in the layouting and only presents in specific GUIs with the debug option enabled
User avatar
_CodeGreen
Long Handed Inserter
Long Handed Inserter
Posts: 74
Joined: Sat Mar 05, 2022 11:30 am
Contact:

Re: [Klonan] [1.1.69] Crash scaling GUI with GUI debug enabled

Post by _CodeGreen »

That's fine, we don't have the ability to scale the GUI up that high anymore anyway (nor did we have much reason to in the first place), so it's probably not even an issue anymore.
My Mods | If you can't make it perfect, make it adjustable
Post Reply

Return to “Won't fix.”