Hello.
I have made 3 PR:
https://github.com/Yousei9/Logistic-Tra ... k/pull/293
https://github.com/Yousei9/Logistic-Tra ... k/pull/294
https://github.com/Yousei9/Logistic-Tra ... k/pull/295
And I was near to public it as preview, but read license:
- No Modification - Although I can't stop you from looking at my code, you are not allowed to distribute anything altered, or derived from my code without explicit permission first.
Therefore, I explicitly ask for permission to publish a preview of the changes that I made and continue my game with them.
Otherwise, I will be forced to write a similar mod from scratch. Long, painful and sad... )
Can I public preview for my pull requests?
Moderator: Optera
- Stringweasel
- Filter Inserter
- Posts: 401
- Joined: Thu Apr 27, 2017 8:22 pm
- Contact:
Re: Can I public preview for my pull requests?
You can make these changes on locally on your PC and play with the modified LTN, that's fine. As long as you don't publish that to other people, like adding it to the mod portal.
I'm not the creator of LTN though, just some guy. But that's how it typically works.
I'm not the creator of LTN though, just some guy. But that's how it typically works.
Alt-F4 Author | Factorio Modder
My Mods: Hall of Fame | Better Victory Screen | Fluidic Power | Biter Power | Space Spidertron | Spidertron Dock |Weasel's Demolition Derby
Official Contributor to Space Exploration
My Mods: Hall of Fame | Better Victory Screen | Fluidic Power | Biter Power | Space Spidertron | Spidertron Dock |
Official Contributor to Space Exploration
Re: Can I public preview for my pull requests?
Thank you. This is how I debugged my changes )Stringweasel wrote: ↑Fri Jun 17, 2022 6:04 amYou can make these changes on locally on your PC and play with the modified LTN, that's fine. As long as you don't publish that to other people, like adding it to the mod portal.
From time to time I invite a friend to come to my game. It will not be very convenient to send a modified mod.
Re: Can I public preview for my pull requests?
Correct, you may play test modifications, but publishing forks is not allowed.
Sorry not opening that can of worms.
Sorry not opening that can of worms.
My Mods: mods.factorio.com
Re: Can I public preview for my pull requests?
Ok
On the one hand, I want to lay out to make it easier. On the other hand, I agree with your approach. If I do anything worthwhile, I'll probably steal your license