[boskid][1.1.50] Desync with belt_neighbours and ghosts

[DaveMcW]

Steps to reproduce:

1. /toggle-heavy-mode
2.

Code: Select all

/c 
belt = game.player.surface.create_entity{name="transport-belt", force=game.player.force, position={0.5,0.5}}
ghost = game.player.surface.create_entity{name="entity-ghost", inner_name="transport-belt", force=game.player.force, position={0.5,-0.5}}
belt.belt_neighbours.outputs[1].order_deconstruction(game.player.force)

Result
Heavy mode check before-update-109 failed.
Heavy mode check after-gameactionhandler-update-109 failed.
Heavy mode check after-scenario-update-110 failed.

[boskid]

Thanks for the report. Issue is now fixed for 1.1.51.

Primary issue was that LuaEntity::belt_neighbours would return broken objects for ghosts. Secondary issue was (most likely) you missed `local` on the `belt` and `ghost` violating requirement of not holding LuaObjects in the lua's global scope from where it cannot be serialized.