[image] is wider / taller than 8192 px

[FuryoftheStars]

Before I go posting a bug report on it...

I'm using some mods that upgrade the texture files and I'm seeing the following in the logs:

Code: Select all

  45.276 Loading mod factoriohd_base 0.0.8 (data-final-fixes.lua)
  51.413 Script @__factoriohd_base__/data-final-fixes.lua:257: [ERROR]: Image @ __factoriohd_base__/data/base/graphics/entity/rocket-silo/hr-08-rocket-silo-arms-back.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  51.414 Script @__factoriohd_base__/data-final-fixes.lua:257: [ERROR]: Image @ __factoriohd_base__/data/base/graphics/entity/rocket-silo/hr-08-rocket-silo-arms-right.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  58.305 Loading mod factoriohd_logistics 0.0.8 (data-final-fixes.lua)
  80.983 Loading mod factoriohd_military 0.0.7 (data-final-fixes.lua)
  88.931 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  88.932 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising-mask.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  88.957 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  88.958 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising-mask.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  88.975 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  88.976 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising-mask.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  88.999 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  89.000 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/gun-turret/hr-gun-turret-raising-mask.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  89.252 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/laser-turret/hr-laser-turret-raising.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  89.253 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/laser-turret/hr-laser-turret-raising-mask.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  89.258 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/laser-turret/hr-laser-turret-raising.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  89.259 Script @__factoriohd_military__/data-final-fixes.lua:263: [ERROR]: Image @ __factoriohd_military__/data/base/graphics/entity/laser-turret/hr-laser-turret-raising-mask.png is wider / taller than 8192 px (maximum)! It can't be loaded into the game!
  92.871 Loading mod factoriohd_production 0.0.8 (data-final-fixes.lua)

When I went to report it to the mod author, I noticed that for one of them someone already had and the mod author commented there was nothing they could do because the images were already smaller than the 8192 px referenced. This was over a year ago and I don't see any indication of activity from the mod author since, hence I'm coming here.

When I took a look at the images myself, I've found the following sizes:

• FactorioHD:Base
  • /data/base/graphics/entity/rocket-silo/hr-08-rocket-silo-arms-back.png - 8192 x 300
  • /data/base/graphics/entity/rocket-silo/hr-08-rocket-silo-arms-right.png - 11648 x 376 (this one is legit over)
• FactorioHD:Military
  • /data/base/graphics/entity/gun-turret/hr-gun-turret-raising.png - 1300 x 1008
  • /data/base/graphics/entity/gun-turret/hr-gun-turret-raising-mask.png - 480 x 496
  • /data/base/graphics/entity/laser-turret/hr-laser-turret-raising.png - 3900 x 1008
  • /data/base/graphics/entity/laser-turret/hr-laser-turret-raising-mask.png - 2580 x 640

Is anyone able to help me understand why these errors are being reported on the images that are definitely under the 8192x8192 size limit?

[Bilka]

The errors are created by the mod (not Factorio), so I'd guess that the mod's logic is broken somewhere. The code in the data-final-fixes.lua isn't immediately obvious to me, though, so I can't verify that.

Edit: Oh, it's all line 263 in the military one. That line multiplies height by line_length, which results in a number that is larger than the real height of the sprite file. Probably they meant to multiply by something like (frame_count / line_length) to get how many frames are stacked in the y direction (more things than that may affect the calculated sprite file height.)

[FuryoftheStars]

D'oh... thanks Bilka! I guess I need to start paying better attention. :/ The way the mod author's response was worded made me think it was Factorio reporting it.

Indeed, I see these now in the referenced file. And commenting out these checks (at least in the military one) doesn't seem to create any errors and everything looks fine, so yeah, their logic must've been off on some of it.

Thanks again!