[0.12.0] [Rseding91] Changing player character while crafting crash.

[ljdp]

Factorio version: 0.12.0
How to reproduce: Change the player character (via the lua API) while the current character is crafting. I.e:

Code: Select all

local old_character = player.character
player.character = nil

Log file:

Log File

0.000 2015-07-17 18:06:13; Factorio 0.12.0 (Build 103, win64)
0.000 Operating system: Windows 7 Service Pack 1
0.001 Read data path: C:/Program Files/Factorio/data
0.001 Write data path: C:/Users/lukepekin/AppData/Roaming/Factorio
0.001 Binaries path: C:/Program Files/Factorio/bin
0.065 Initialised Direct3D: NVIDIA GeForce GTX 660 ; driver: nvd3dumx.dll 9.18.13.5306
0.111 Graphics options: [FullScreen: true] [VSync: false] [UIScale: 100%] [MultiSampling: X 2] [Graphics quality: normal] [Video memory usage: high]
0.183 Loading mod core 0.0.0 (data.lua)
0.186 Loading mod base 0.12.0 (data.lua)
0.254 Loading mod commandcontrol 1.0.2 (data.lua)
0.906 Initial atlas bitmap size is 16384
0.908 Created atlas bitmap 16384x5407
13.982 Info Updater.cpp:720: Downloading https://www.factorio.com/updater/get-av ... iVersion=2
14.694 0 packages available to download (experimental updates enabled).
14.743 Factorio initialised
77.913 Loading map
77.913 Info Scenario.cpp:160: Map version 0.12.0-36

Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\temp\factorio-5829127a\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\temp\factorio-5829127a\src\util\logger.cpp (283): Logger::writeStacktrace
c:\temp\factorio-5829127a\src\util\logger.cpp (337): Logger::logStacktrace
c:\temp\factorio-5829127a\src\util\crashhandler.cpp (79): CrashHandler::writeStackTrace
c:\temp\factorio-5829127a\src\util\crashhandler.cpp (88): CrashHandler::SehHandler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000007739B940)
000000007739B940 (kernel32): (filename not available): UnhandledExceptionFilter
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000775B3398)
00000000775B3398 (ntdll): (filename not available): MD5Final
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000775385C8)
00000000775385C8 (ntdll): (filename not available): _C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077549D2D)
0000000077549D2D (ntdll): (filename not available): RtlDecodePointer
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000775391CF)
00000000775391CF (ntdll): (filename not available): RtlUnwindEx
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 0000000077571248)
0000000077571248 (ntdll): (filename not available): KiUserExceptionDispatcher
c:\temp\factorio-5829127a\src\manualcrafter.cpp (107): ManualCrafter::performCrafting
c:\temp\factorio-5829127a\src\entity\character.cpp (483): Character::update
c:\temp\factorio-5829127a\src\surface\chunk.cpp (438): Chunk::update
c:\temp\factorio-5829127a\src\surface\surface.cpp (733): Surface::update
c:\temp\factorio-5829127a\src\map\map.cpp (897): Map::update
c:\temp\factorio-5829127a\src\game.cpp (135): Game::update
c:\temp\factorio-5829127a\src\scenario\scenario.cpp (736): Scenario::update
c:\temp\factorio-5829127a\src\mainloop.cpp (250): MainLoop::gameUpdateStep
c:\temp\factorio-5829127a\src\mainloop.cpp (351): MainLoop::updateLoop
c:\boost_1_58_0\boost\function\function_template.hpp (160): boost::detail::function::void_function_obj_invoker0<boost::_bi::bind_t<void,void (__cdecl*)(ThreadBarrier * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64,bool * __ptr64,bool),boost::_bi::list5<boost::_bi::value<ThreadBarrier * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<boost::chrono::time_point<boost::chrono::steady_clock,boost::chrono::duration<__int64,boost::ratio<1,1000000000> > > * __ptr64>,boost::_bi::value<bool * __ptr64>,boost::_bi::value<bool> > >,void>::invoke
c:\temp\factorio-5829127a\src\util\thread.cpp (34): Thread::loop
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000013F9AB163)
000000013F9AB163 (Factorio): (filename not available): boost::`anonymous namespace'::thread_start_function
f:\dd\vctools\crt\crtw32\startup\threadex.c (376): _callthreadstartex
f:\dd\vctools\crt\crtw32\startup\threadex.c (354): _threadstartex
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00000000773159ED)
00000000773159ED (kernel32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 000000007754C541)
000000007754C541 (ntdll): (filename not available): RtlUserThreadStart
18421.789 Error Util.cpp:45: Unexpected error occurred. You can help us to solve the problem by posting the contents of the log file on the Factorio forums.

Note, this can be fixed by asserting

Code: Select all

player.crafting_queue_size == 0

However I assume this is not intended behaviour.

[bobingabout]

player.character = nil doesn't sound like a good idea to me.

[Rseding91]

player.character = nil doesn't sound like a good idea to me.

That's actually supported and detaches the controller from the character (switches to god mode).

I'll look into the crash and work on getting it fixed.

[Rseding91]

Thanks for the report. This is now fixed for 0.12.1.