[2.1.19] Crash changing tank equipment "ItemStackOrID.hpp:13: this->id was not true"

[Jiriakel]

The game crashed while moving a solar panel in the tank setup to a new spot.

[Klonan]

The game crashed while moving a solar panel in the tank setup to a new spot.

Hello, welcome to the forum,

Thank you for the report,
Are you able to reproduce the crash?
Could you attach a save game before it happens and steps you take to make it happen?

[Jiriakel]

Hi !

I attached my savefile. I can reproduce it somewhat consistently by doing the following steps :

1. My character is inside the tank (not sure if this is relevant), close enough to a roboport for logistic bots.
2. In map view, I open the tank's inventory (the one where you can equip various things such as shields, personnal roboports...)
3. I copy a solar panel under my mouse in the inventory with A (pipette keybinding) and start placing/deleting solar panels

At some point the game will crash - I can't pinpoint exactly what's different between the placement/deletion iteration where it crashes vs the previous ones however.

[boskid]

Thanks for the report and reproduction steps. I was able to reproduce the issue and observe that the problem happens when its a construction robot sent from tank's personal roboport that trigger the issue. Looks like when construction robot repositions one of the equipment, it returns to a tank with empty cargo but this empty cargo is attempted to be delivered to a tank causing a crash because cargo inserted is attempted to be put into fuel slot and this code was not prepared to see an empty stack being inserted.

Issue is now fixed for 2.1.20.