[2.1.17] Hover visualization of "Each" in decider combinator does not agree with output

[ignatio]

If a combinator is wired up with signals as in the screenshot below, it outputs nothing, yet hovering over the green "I" signal shows the output as green, which suggests that I=3 should be output.

decider_each_other_cable_2.1.png (59.98 KiB) Viewed 494 times

I believe the output is correct and it's just the visualization when hovering over the input signal that is wrong (or at least confusing).

I.e., restricting "Each" to one wire both should and does make it iterate only over the signals on that wire. That can be useful, and it's easy to get the other behaviour by just adding a condition using "Each" on the other wire that's always true.

[boskid]

It kind of is correct, because when you hover over a signal, all conditions and outputs are highlighted as if the each signal was substituted with selected signal. What it does not account for is that the selected signal is not a valid substitute because all instances of each signal on conditions side have value of 0. There are 2 possible solutions: either highlight conditions and outputs using signal under cursor regardless if a substitute is valid (current behavior) causing confusion why output is active yet it is not present on the output, or not highlight anything because substitute is invalid (proposed behavior) that i think would cause different type of confusion because it would not be showing anything about conditions nor outputs suggesting why are all conditions false while the condition would be true when substituted.

[ignatio]

Thanks for the quick response.

I agree both are confusing, because understanding what's going on requires thinking about the signal set being iterated over, and appreciating that there's a third state that's neither true nor false - it's just outside altogether.

A third option could be to indicate that by a different colour on the "Each" conditions that the signal is outside the set of (and highlight nothing on the output side). That way it'd be more clear that something else is going on, at least.

[boskid]

Thanks for the report. For 2.1.21 i changed this highlight logic such that it does not highlight conditions and outputs when hovering a signal that is not a valid substitute.