[SA] Imrove module effect rounding when affected by quality

Post your ideas and suggestions how to improve the game.

Moderator: ickputzdirwech

User avatar
Hares
Filter Inserter
Filter Inserter
Posts: 904
Joined: Sat Oct 22, 2022 8:05 pm
Contact:

[SA] Imrove module effect rounding when affected by quality

Post by Hares »

TL;DR
Module effect's rounding should happen before applying quality.
What?
The rounding precision should be done for all prototypes before applying quality, and always apply full quality bonus for module effect. The prototypes API & display values may be kept with the old level precision (i.e., rounding when displayed).
Why?
Currently, rounding happens both before and after applying quality. Since each level of quality adds +30% bonus, the later digits are usually lost even if even number of modules would round it to a valid integer percent.

Example: Tier 3 Quality module has +2.5% quality for common quality. With 4 of these, you get +10% Quality. Legendary quality increases this by x2.5, to a nice rounded number of +25% quality per machine. However, due to strict rounding before multiplying by the number of modules, we end up with upggly +24.8%.
04-28-2025, 21-55-40.png
04-28-2025, 21-55-40.png (157.97 KiB) Viewed 472 times
Fulgora is the best planet. Vulcanus needs rework. Feel free to prove me wrong.
eugenekay
Smart Inserter
Smart Inserter
Posts: 1332
Joined: Tue May 15, 2018 2:14 am
Contact:

Re: [SA] Imrove module effect rounding when affected by quality

Post by eugenekay »

eugenekay wrote: Sat Sep 05, 2026 2:29 pm 125320, which says:
boskid wrote: Tue Feb 24, 2026 12:59 pm This will be fixed in 2.1.
Version 2.0.77:
Screenshot 2026-09-05 102911.png
Screenshot 2026-09-05 102911.png (112.97 KiB) Viewed 169 times
Version 2.1.17:
Screenshot 2026-09-05 101936.png
Screenshot 2026-09-05 101936.png (103.38 KiB) Viewed 169 times
So the Fix does not appear to be limited to Beacons, but Module Effects in general. :mrgreen:

Good Luck!
Alfonse215
Fast Inserter
Fast Inserter
Posts: 132
Joined: Mon Dec 23, 2024 6:53 pm
Contact:

Re: [SA] Imrove module effect rounding when affected by quality

Post by Alfonse215 »

Also, prod modules now get 1 decimal of precision. So rare prod 2s now give +9.6% prod instead of just +9%.
Post Reply

Return to “Ideas and Suggestions”